Re: [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log

[Tom Tromey <tom@tromey.com>]

>>>>> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:

> When started with the --remote-debug flag, gdbserver enables the debug
> logs for the received and sent remote packets.  If the packet contents
> are too long or contain verbatim binary data, printing the contents
> may create noise in the logs or even distortion in the terminal output.

I'm sort of meh about this patch.  However, there are already other ways
to get more complete logs (my fave is "set remotelogfile", since that
can be replayed), so I guess the concept is alright.

> +void
> +suppress_next_putpkt_log ()
> +{
> +  suppressed_remote_debug = true;
> +}

I think returning a scoped_restore here would be better.
Or just letting clients do this directly.

> +  SCOPE_EXIT { suppressed_remote_debug = false; };

Then you wouldn't need a SCOPE_EXIT here.

Tom