From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>,
Simon Marchi <simon.marchi@polymtl.ca>,
gdb-patches@sourceware.org, Lancelot SIX <lsix@lancelotsix.com>
Subject: Re: [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging
Date: Mon, 6 Feb 2023 12:47:55 +0100 [thread overview]
Message-ID: <dafde1f0-9d34-7d1b-23e0-1997b34e9b38@suse.de> (raw)
In-Reply-To: <f2f6e1d2-459a-dd26-fe37-87b74524e2e3@simark.ca>
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
On 2/2/23 16:08, Simon Marchi via Gdb-patches wrote:
>
> On 1/25/23 12:03, Simon Marchi via Gdb-patches wrote:
>>
>> On 1/5/23 15:02, Simon Marchi wrote:
>>> This is the v2 of:
>>>
>>> https://inbox.sourceware.org/gdb-patches/20221206135729.3937767-1-simon.marchi@efficios.com/
>>>
>>> I pushed patches 5, 7, 8 and 9, since I considered them good chances even
>>> outside of this series.
>>>
>>> Most other preparatory patches have been reviewed and LGTM'ed by Andrew
>>> Burgess, but they are not really useful on their own, so they are still
>>> in this series. There are no changes in them, except a typo fix in
>>> patch 3.
>>>
>>> The only preparatory patch which was not reviewed is "gdb/solib-svr4:
>>> don't disable probes interface if probe not found".
>> Ping.
>>
>> I plan to push the series in a week from now, if there are no more
>> comments on this. Note that this code has been heavily scrutinized by
>> Pedro and Lancelot, so I am confident that it is in good shape already.
>>
>> Simon
> I pushed the series.
>
> Simon
Hi,
as I mentioned earlier to Lancelot off-list, I'm now seeing:
...
Running /data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.exp ...
gdb compile failed,
/data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.cpp:18:10: fatal
error: hip/hip_runtime.h: No such file or directory
#include "hip/hip_runtime.h"
^~~~~~~~~~~~~~~~~~~
compilation terminated.
...
Thanks,
- Tom
next prev parent reply other threads:[~2023-02-06 11:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 20:02 Simon Marchi
2023-01-05 20:02 ` [PATCH v2 1/8] gdb: add supports_arch_info callback to gdbarch_register Simon Marchi
2023-01-05 20:02 ` [PATCH v2 2/8] gdb: make install_breakpoint return a non-owning reference Simon Marchi
2023-01-05 20:02 ` [PATCH v2 3/8] gdbsupport: add type definitions for pid, lwp and tid Simon Marchi
2023-01-05 20:02 ` [PATCH v2 4/8] gdb: add inferior_pre_detach observable Simon Marchi
2023-01-05 20:02 ` [PATCH v2 5/8] gdb: add gdbarch_up Simon Marchi
2023-01-05 20:31 ` Tom Tromey
2023-01-05 20:36 ` Simon Marchi
2023-01-05 20:41 ` Tom Tromey
2023-01-06 0:48 ` Simon Marchi
2023-01-05 20:02 ` [PATCH v2 6/8] gdb/solib-svr4: don't disable probes interface if probe not found Simon Marchi
2023-01-05 20:02 ` [PATCH v2 7/8] gdb: make gdb_printing_disassembler::stream public Simon Marchi
2023-01-05 20:02 ` [PATCH v2 8/8] gdb: initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2023-01-05 20:17 ` Simon Marchi
2023-01-25 17:03 ` [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Simon Marchi
2023-02-02 15:08 ` Simon Marchi
2023-02-06 11:47 ` Tom de Vries [this message]
2023-02-06 14:01 ` Lancelot Six
2023-02-06 16:53 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dafde1f0-9d34-7d1b-23e0-1997b34e9b38@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simark@simark.ca \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).