* undefined reference to `set_breakpoint'
@ 2010-03-17 17:34 Gene Smith
2010-03-17 17:57 ` Tom Tromey
0 siblings, 1 reply; 13+ messages in thread
From: Gene Smith @ 2010-03-17 17:34 UTC (permalink / raw)
To: insight
With CVS head, see this error when, I think, linking gdb:
rm -f gdb
gcc -g -O2 \
-o gdb gdb.o libgdb.a \
../sim/arm/libsim.a ../readline/libreadline.a
../opcodes/libopcodes.a ../bfd/libbfd.a ../libiberty/libiberty.a
../libdecnumber/libdecnumber.a ../libgui/src/libgui.a
-L/home/gene/addons/insight-cvs/insight_build/tk/unix -ltk8.4
-L/home/gene/addons/insight-cvs/insight_build/tcl/unix -ltcl8.4 -lX11
-ldl -lieee -lm -lncurses -lz -lm -lpython2.6 -lexpat
../libiberty/libiberty.a gnulib/libgnu.a
libgdb.a(gdbtk-bp.o): In function `gdb_set_bp':
/home/gene/addons/insight-cvs/insight_build/gdb/../../insight_sources/gdb/gdbtk/generic/gdbtk-bp.c:533:
undefined reference to `set_breakpoint'
Configured like this:
configure -v --quiet --prefix=$PREFIX \
--target=$TARGET --enable-interwork --enable-multilib \
--with-gnu-ld --with-gnu-as \
--disable-werror
Is this due to a missing package? This is on 64bit fedora 12. tk and tcl
dev packages installed.
Thanks,
-gene
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: undefined reference to `set_breakpoint' 2010-03-17 17:34 undefined reference to `set_breakpoint' Gene Smith @ 2010-03-17 17:57 ` Tom Tromey 2010-03-18 3:39 ` Keith Seitz 0 siblings, 1 reply; 13+ messages in thread From: Tom Tromey @ 2010-03-17 17:57 UTC (permalink / raw) To: Gene Smith; +Cc: insight >>>>> "Gene" == Gene Smith <gds@chartertn.net> writes: Gene> /home/gene/addons/insight-cvs/insight_build/gdb/../../insight_sources/gdb/gdbtk/generic/gdbtk-bp.c:533: Gene> undefined reference to `set_breakpoint' Gene> Is this due to a missing package? This is on 64bit fedora 12. tk and Gene> tcl dev packages installed. No, this is due to a change to gdb without a corresponding fix to insight. This happens from time to time. Tom ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-17 17:57 ` Tom Tromey @ 2010-03-18 3:39 ` Keith Seitz 2010-03-18 4:58 ` Gene Smith 2010-03-19 4:32 ` Gene Smith 0 siblings, 2 replies; 13+ messages in thread From: Keith Seitz @ 2010-03-18 3:39 UTC (permalink / raw) To: Gene Smith; +Cc: insight [-- Attachment #1: Type: text/plain, Size: 562 bytes --] On 03/17/2010 10:33 AM, Tom Tromey wrote: >>>>>> "Gene" == Gene Smith<gds@chartertn.net> writes: > No, this is due to a change to gdb without a corresponding fix to > insight. This happens from time to time. Do you want to test the attach patch? [I'm off the rest of the week, or I would probably have occasion to put it through its paces.] Let me know if this works -- it was okay in preliminary testing. Keith ChangeLog 2010-03-17 Keith Seitz <keiths@redhat.com> * generic/gdbtk-bp.c (gdb_set_bp): set_breakpoint is no more. Use create_breakpoint. [-- Attachment #2: set_breakpoint.patch --] [-- Type: text/plain, Size: 1181 bytes --] Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.33 diff -u -p -r1.33 gdbtk-bp.c --- generic/gdbtk-bp.c 15 Jan 2010 22:37:18 -0000 1.33 +++ generic/gdbtk-bp.c 17 Mar 2010 17:56:54 -0000 @@ -1,5 +1,5 @@ /* Tcl/Tk command definitions for Insight - Breakpoints. - Copyright (C) 2001, 2002, 2008, 2009 Free Software Foundation, Inc. + Copyright (C) 2001, 2002, 2008, 2009, 2010 Free Software Foundation, Inc. This file is part of GDB. @@ -530,9 +530,16 @@ gdb_set_bp (ClientData clientData, Tcl_I TRY_CATCH (e, RETURN_MASK_ALL) { - set_breakpoint (get_current_arch (), address, condition, - 0 /* hardwareflag */, temp, thread, ignore_count, - pending, enabled); + create_breakpoint (get_current_arch (), address, condition, thread, + 0 /* condition and thread are valid */, + temp, + 0 /* hardware flag */, + 0 /* trace flag */, + ignore_count, + (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE), + NULL /* breakpoint ops */, + 0 /* from_tty */, + enabled); } if (e.reason < 0) ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-18 3:39 ` Keith Seitz @ 2010-03-18 4:58 ` Gene Smith 2010-03-19 4:32 ` Gene Smith 1 sibling, 0 replies; 13+ messages in thread From: Gene Smith @ 2010-03-18 4:58 UTC (permalink / raw) To: insight Keith Seitz wrote, On 03/17/2010 01:57 PM: > > Do you want to test the attach patch? [I'm off the rest of the week, or > I would probably have occasion to put it through its paces.] > > Let me know if this works -- it was okay in preliminary testing. > > Keith It builds and runs. Still need to try it in embedded mode using openocd. Thanks, -gene ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-18 3:39 ` Keith Seitz 2010-03-18 4:58 ` Gene Smith @ 2010-03-19 4:32 ` Gene Smith 2010-03-20 5:33 ` Hui Zhu 1 sibling, 1 reply; 13+ messages in thread From: Gene Smith @ 2010-03-19 4:32 UTC (permalink / raw) To: insight Keith Seitz wrote, On 03/17/2010 01:57 PM: > Do you want to test the attach patch? [I'm off the rest of the week, or > I would probably have occasion to put it through its paces.] > > Let me know if this works -- it was okay in preliminary testing. > > Keith Built OK on/for f12-64bit native. Tried my build for mingw32 (using f12 cross compiler pkg that works OK for insight 6.8) and see this error when entering the itcl directory and apparently trying to "make all": i686-pc-mingw32-windres -o wish.res.o --include "../../../insight_sources/tk/win/../generic" --include "/home/gene/addons/insight-cvs/insight_sources/tcl/generic" --include "../../../insight_sources/tk/win/rc" ../../../insight_sources/tk/win/rc/wish.rc i686-pc-mingw32-gcc -g -O2 -D__USE_MINGW_ACCESS winMain.o "/home/gene/addons/insight-cvs/insight_build/tcl/win/libtcl84.a" libtk84.a -lgdi32 -lcomdlg32 -limm32 -lcomctl32 -lshell32 \ wish.res.o -o wish84.exe -mwindows -mwin32 make[3]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/tk/win' make[2]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/tk' make[2]: Entering directory `/home/gene/addons/insight-cvs/insight_build/itcl' Making all in itcl make[3]: Entering directory `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' make[3]: *** No rule to make target `all'. Stop. make[3]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' Making all in itk make[3]: Entering directory `/home/gene/addons/insight-cvs/insight_build/itcl/itk' make[3]: *** No rule to make target `all'. Stop. make[3]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/itcl/itk' Making all in iwidgets make[3]: Entering directory `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' make[3]: *** No rule to make target `all'. Stop. make[3]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' make[3]: Entering directory `/home/gene/addons/insight-cvs/insight_build/itcl' make[3]: Nothing to be done for `all-am'. make[3]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/itcl' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/itcl' make[1]: *** [all-itcl] Error 2 make[1]: Leaving directory `/home/gene/addons/insight-cvs/insight_build' make: *** [all] Error 2 Configured like this: ./configure -v --quiet --prefix=$PREFIX \ --target=$TARGET --enable-interwork --enable-multilib \ --with-gnu-ld --with-gnu-as \ --disable-werror \ --host=i686-pc-mingw32 --build=i686-pc-linux-gnu \ CC="i686-pc-mingw32-gcc" ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-19 4:32 ` Gene Smith @ 2010-03-20 5:33 ` Hui Zhu 2010-03-30 8:29 ` Hui Zhu 0 siblings, 1 reply; 13+ messages in thread From: Hui Zhu @ 2010-03-20 5:33 UTC (permalink / raw) To: Gene Smith, Keith Seitz; +Cc: insight It looks like another issue. Does this patch can check in? Thanks, Hui On Thu, Mar 18, 2010 at 12:58, Gene Smith <gds@chartertn.net> wrote: > Keith Seitz wrote, On 03/17/2010 01:57 PM: >> >> Do you want to test the attach patch? [I'm off the rest of the week, or >> I would probably have occasion to put it through its paces.] >> >> Let me know if this works -- it was okay in preliminary testing. >> >> Keith > > Built OK on/for f12-64bit native. Tried my build for mingw32 (using f12 > cross compiler pkg that works OK for insight 6.8) and see this error when > entering the itcl directory and apparently trying to "make all": > > i686-pc-mingw32-windres -o wish.res.o --include > "../../../insight_sources/tk/win/../generic" --include > "/home/gene/addons/insight-cvs/insight_sources/tcl/generic" --include > "../../../insight_sources/tk/win/rc" > ../../../insight_sources/tk/win/rc/wish.rc > i686-pc-mingw32-gcc -g -O2 -D__USE_MINGW_ACCESS winMain.o > "/home/gene/addons/insight-cvs/insight_build/tcl/win/libtcl84.a" libtk84.a > -lgdi32 -lcomdlg32 -limm32 -lcomctl32 -lshell32 \ > wish.res.o -o wish84.exe -mwindows -mwin32 > make[3]: Leaving directory > `/home/gene/addons/insight-cvs/insight_build/tk/win' > make[2]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/tk' > make[2]: Entering directory > `/home/gene/addons/insight-cvs/insight_build/itcl' > Making all in itcl > make[3]: Entering directory > `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' > make[3]: *** No rule to make target `all'. Stop. > make[3]: Leaving directory > `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' > Making all in itk > make[3]: Entering directory > `/home/gene/addons/insight-cvs/insight_build/itcl/itk' > make[3]: *** No rule to make target `all'. Stop. > make[3]: Leaving directory > `/home/gene/addons/insight-cvs/insight_build/itcl/itk' > Making all in iwidgets > make[3]: Entering directory > `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' > make[3]: *** No rule to make target `all'. Stop. > make[3]: Leaving directory > `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' > make[3]: Entering directory > `/home/gene/addons/insight-cvs/insight_build/itcl' > make[3]: Nothing to be done for `all-am'. > make[3]: Leaving directory > `/home/gene/addons/insight-cvs/insight_build/itcl' > make[2]: *** [all-recursive] Error 1 > make[2]: Leaving directory > `/home/gene/addons/insight-cvs/insight_build/itcl' > make[1]: *** [all-itcl] Error 2 > make[1]: Leaving directory `/home/gene/addons/insight-cvs/insight_build' > make: *** [all] Error 2 > > Configured like this: > ./configure -v --quiet --prefix=$PREFIX \ > --target=$TARGET --enable-interwork --enable-multilib \ > --with-gnu-ld --with-gnu-as \ > --disable-werror \ > --host=i686-pc-mingw32 --build=i686-pc-linux-gnu \ > CC="i686-pc-mingw32-gcc" > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-20 5:33 ` Hui Zhu @ 2010-03-30 8:29 ` Hui Zhu 2010-03-30 16:48 ` Hui Zhu 0 siblings, 1 reply; 13+ messages in thread From: Hui Zhu @ 2010-03-30 8:29 UTC (permalink / raw) To: Keith Seitz; +Cc: insight gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib -DMI_OUT=1 -DTUI=1 -DGDBTK -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Werror -c -o gdbtk-bp.o -MT gdbtk-bp.o -MMD -MP -MF .deps/gdbtk-bp.Tpo -I../../src/gdb/../libgui/src -I/home/teawater/gdb/cvs/src/tcl/generic -I/home/teawater/gdb/cvs/src/tk/generic -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" -DSRC_DIR=\"/home/teawater/gdb/cvs/src/gdb\" ../../src/gdb/gdbtk/generic/gdbtk-bp.c cc1: warnings being treated as errors ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_breakpoint_info': ../../src/gdb/gdbtk/generic/gdbtk-bp.c:365: warning: passing argument 1 of 'get_breakpoint_commands' from incompatible pointer type ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_actions_command': ../../src/gdb/gdbtk/generic/gdbtk-bp.c:688: warning: passing argument 1 of 'free_command_lines' from incompatible pointer type ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_tracepoint_info': ../../src/gdb/gdbtk/generic/gdbtk-bp.c:776: warning: assignment from incompatible pointer type make[2]: *** [gdbtk-bp.o] Error 1 make[2]: Leaving directory `/home/teawater/gdb/cvs/bgdball/gdb' make[1]: *** [all-gdb] Error 2 make[1]: Leaving directory `/home/teawater/gdb/cvs/bgdball' make: *** [all] Error 2 On Fri, Mar 19, 2010 at 17:01, Hui Zhu <teawater@gmail.com> wrote: > It looks like another issue. > > Does this patch can check in? > > Thanks, > Hui > > On Thu, Mar 18, 2010 at 12:58, Gene Smith <gds@chartertn.net> wrote: >> Keith Seitz wrote, On 03/17/2010 01:57 PM: >>> >>> Do you want to test the attach patch? [I'm off the rest of the week, or >>> I would probably have occasion to put it through its paces.] >>> >>> Let me know if this works -- it was okay in preliminary testing. >>> >>> Keith >> >> Built OK on/for f12-64bit native. Tried my build for mingw32 (using f12 >> cross compiler pkg that works OK for insight 6.8) and see this error when >> entering the itcl directory and apparently trying to "make all": >> >> i686-pc-mingw32-windres -o wish.res.o --include >> "../../../insight_sources/tk/win/../generic" --include >> "/home/gene/addons/insight-cvs/insight_sources/tcl/generic" --include >> "../../../insight_sources/tk/win/rc" >> ../../../insight_sources/tk/win/rc/wish.rc >> i686-pc-mingw32-gcc -g -O2 -D__USE_MINGW_ACCESS winMain.o >> "/home/gene/addons/insight-cvs/insight_build/tcl/win/libtcl84.a" libtk84.a >> -lgdi32 -lcomdlg32 -limm32 -lcomctl32 -lshell32 \ >> wish.res.o -o wish84.exe -mwindows -mwin32 >> make[3]: Leaving directory >> `/home/gene/addons/insight-cvs/insight_build/tk/win' >> make[2]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/tk' >> make[2]: Entering directory >> `/home/gene/addons/insight-cvs/insight_build/itcl' >> Making all in itcl >> make[3]: Entering directory >> `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' >> make[3]: *** No rule to make target `all'. Stop. >> make[3]: Leaving directory >> `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' >> Making all in itk >> make[3]: Entering directory >> `/home/gene/addons/insight-cvs/insight_build/itcl/itk' >> make[3]: *** No rule to make target `all'. Stop. >> make[3]: Leaving directory >> `/home/gene/addons/insight-cvs/insight_build/itcl/itk' >> Making all in iwidgets >> make[3]: Entering directory >> `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' >> make[3]: *** No rule to make target `all'. Stop. >> make[3]: Leaving directory >> `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' >> make[3]: Entering directory >> `/home/gene/addons/insight-cvs/insight_build/itcl' >> make[3]: Nothing to be done for `all-am'. >> make[3]: Leaving directory >> `/home/gene/addons/insight-cvs/insight_build/itcl' >> make[2]: *** [all-recursive] Error 1 >> make[2]: Leaving directory >> `/home/gene/addons/insight-cvs/insight_build/itcl' >> make[1]: *** [all-itcl] Error 2 >> make[1]: Leaving directory `/home/gene/addons/insight-cvs/insight_build' >> make: *** [all] Error 2 >> >> Configured like this: >> ./configure -v --quiet --prefix=$PREFIX \ >> --target=$TARGET --enable-interwork --enable-multilib \ >> --with-gnu-ld --with-gnu-as \ >> --disable-werror \ >> --host=i686-pc-mingw32 --build=i686-pc-linux-gnu \ >> CC="i686-pc-mingw32-gcc" >> >> >> >> >> >> > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-30 8:29 ` Hui Zhu @ 2010-03-30 16:48 ` Hui Zhu 2010-03-31 3:20 ` Keith Seitz 0 siblings, 1 reply; 13+ messages in thread From: Hui Zhu @ 2010-03-30 16:48 UTC (permalink / raw) To: Keith Seitz; +Cc: insight Ping. Did I miss something? Thanks, Hui On Thu, Mar 25, 2010 at 15:06, Hui Zhu <teawater@gmail.com> wrote: > gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common > -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" > -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode > -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd > -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber > -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib > -DMI_OUT=1 -DTUI=1 -DGDBTK -Wall -Wdeclaration-after-statement > -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused > -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts > -Werror -c -o gdbtk-bp.o -MT gdbtk-bp.o -MMD -MP -MF > .deps/gdbtk-bp.Tpo -I../../src/gdb/../libgui/src > -I/home/teawater/gdb/cvs/src/tcl/generic > -I/home/teawater/gdb/cvs/src/tk/generic > -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" > -DSRC_DIR=\"/home/teawater/gdb/cvs/src/gdb\" > ../../src/gdb/gdbtk/generic/gdbtk-bp.c > cc1: warnings being treated as errors > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_breakpoint_info': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:365: warning: passing argument > 1 of 'get_breakpoint_commands' from incompatible pointer type > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_actions_command': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:688: warning: passing argument > 1 of 'free_command_lines' from incompatible pointer type > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_tracepoint_info': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:776: warning: assignment from > incompatible pointer type > make[2]: *** [gdbtk-bp.o] Error 1 > make[2]: Leaving directory `/home/teawater/gdb/cvs/bgdball/gdb' > make[1]: *** [all-gdb] Error 2 > make[1]: Leaving directory `/home/teawater/gdb/cvs/bgdball' > make: *** [all] Error 2 > > > On Fri, Mar 19, 2010 at 17:01, Hui Zhu <teawater@gmail.com> wrote: >> It looks like another issue. >> >> Does this patch can check in? >> >> Thanks, >> Hui >> >> On Thu, Mar 18, 2010 at 12:58, Gene Smith <gds@chartertn.net> wrote: >>> Keith Seitz wrote, On 03/17/2010 01:57 PM: >>>> >>>> Do you want to test the attach patch? [I'm off the rest of the week, or >>>> I would probably have occasion to put it through its paces.] >>>> >>>> Let me know if this works -- it was okay in preliminary testing. >>>> >>>> Keith >>> >>> Built OK on/for f12-64bit native. Tried my build for mingw32 (using f12 >>> cross compiler pkg that works OK for insight 6.8) and see this error when >>> entering the itcl directory and apparently trying to "make all": >>> >>> i686-pc-mingw32-windres -o wish.res.o --include >>> "../../../insight_sources/tk/win/../generic" --include >>> "/home/gene/addons/insight-cvs/insight_sources/tcl/generic" --include >>> "../../../insight_sources/tk/win/rc" >>> ../../../insight_sources/tk/win/rc/wish.rc >>> i686-pc-mingw32-gcc -g -O2 -D__USE_MINGW_ACCESS winMain.o >>> "/home/gene/addons/insight-cvs/insight_build/tcl/win/libtcl84.a" libtk84.a >>> -lgdi32 -lcomdlg32 -limm32 -lcomctl32 -lshell32 \ >>> wish.res.o -o wish84.exe -mwindows -mwin32 >>> make[3]: Leaving directory >>> `/home/gene/addons/insight-cvs/insight_build/tk/win' >>> make[2]: Leaving directory `/home/gene/addons/insight-cvs/insight_build/tk' >>> make[2]: Entering directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl' >>> Making all in itcl >>> make[3]: Entering directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' >>> make[3]: *** No rule to make target `all'. Stop. >>> make[3]: Leaving directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl/itcl' >>> Making all in itk >>> make[3]: Entering directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl/itk' >>> make[3]: *** No rule to make target `all'. Stop. >>> make[3]: Leaving directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl/itk' >>> Making all in iwidgets >>> make[3]: Entering directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' >>> make[3]: *** No rule to make target `all'. Stop. >>> make[3]: Leaving directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl/iwidgets' >>> make[3]: Entering directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl' >>> make[3]: Nothing to be done for `all-am'. >>> make[3]: Leaving directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl' >>> make[2]: *** [all-recursive] Error 1 >>> make[2]: Leaving directory >>> `/home/gene/addons/insight-cvs/insight_build/itcl' >>> make[1]: *** [all-itcl] Error 2 >>> make[1]: Leaving directory `/home/gene/addons/insight-cvs/insight_build' >>> make: *** [all] Error 2 >>> >>> Configured like this: >>> ./configure -v --quiet --prefix=$PREFIX \ >>> --target=$TARGET --enable-interwork --enable-multilib \ >>> --with-gnu-ld --with-gnu-as \ >>> --disable-werror \ >>> --host=i686-pc-mingw32 --build=i686-pc-linux-gnu \ >>> CC="i686-pc-mingw32-gcc" >>> >>> >>> >>> >>> >>> >> > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-30 16:48 ` Hui Zhu @ 2010-03-31 3:20 ` Keith Seitz 2010-03-31 4:12 ` Hui Zhu 0 siblings, 1 reply; 13+ messages in thread From: Keith Seitz @ 2010-03-31 3:20 UTC (permalink / raw) To: Hui Zhu; +Cc: insight [-- Attachment #1: Type: text/plain, Size: 748 bytes --] On 03/30/2010 01:29 AM, Hui Zhu wrote: > Ping. Did I miss something? > Nope -- I did. After the breakpoint commands API was fiddled with, I worked up the original patch. Some (brief) time after committing my patch, the API was fiddled with again. I apologize about the confusion. Try this patch, which I've committed. Keith ChangeLog 2010-03-30 Keith Seitz <keiths@redhat.com> * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Breakpoint commands are now reference counted. Adjust data pointers. (gdb_get_tracepoint_info): Likewise. (gdb_actions_command): Don't free previous actions. If the commands aren't valid, we would prefer to keep the old ones any way. break_point_set_commands will also clobber any previous results anyway. [-- Attachment #2: more-bp-cmd-fixes.patch --] [-- Type: text/plain, Size: 1678 bytes --] Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.34 diff -u -p -r1.34 gdbtk-bp.c --- generic/gdbtk-bp.c 24 Mar 2010 20:18:28 -0000 1.34 +++ generic/gdbtk-bp.c 30 Mar 2010 16:45:30 -0000 @@ -362,7 +362,7 @@ gdb_get_breakpoint_info (ClientData clie Tcl_NewIntObj (b->ignore_count)); Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, - get_breakpoint_commands (b->commands)); + get_breakpoint_commands (b->commands ? b->commands->commands : NULL)); Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Tcl_NewStringObj (b->cond_string, -1)); @@ -684,9 +684,6 @@ gdb_actions_command (ClientData clientDa return TCL_ERROR; } - /* Free any existing actions. */ - free_command_lines (&tp->commands); - /* Validate and set new tracepoint actions. */ Tcl_ListObjGetElements (interp, objv[2], &gdbtk_obj_array_cnt, &gdbtk_obj_array); @@ -773,12 +770,15 @@ gdb_get_tracepoint_info (ClientData clie /* Append a list of actions */ action_list = Tcl_NewObj (); - for (cl = tp->commands; cl != NULL; cl = cl->next) + if (tp->commands != NULL) { - Tcl_ListObjAppendElement (interp, action_list, - Tcl_NewStringObj (cl->line, -1)); + for (cl = tp->commands->commands; cl != NULL; cl = cl->next) + { + Tcl_ListObjAppendElement (interp, action_list, + Tcl_NewStringObj (cl->line, -1)); + } + Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, action_list); } - Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, action_list); return TCL_OK; } ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-31 3:20 ` Keith Seitz @ 2010-03-31 4:12 ` Hui Zhu 2010-03-31 4:28 ` Keith Seitz 0 siblings, 1 reply; 13+ messages in thread From: Hui Zhu @ 2010-03-31 4:12 UTC (permalink / raw) To: Keith Seitz; +Cc: insight [-- Attachment #1: Type: text/plain, Size: 1047 bytes --] On Wed, Mar 31, 2010 at 00:48, Keith Seitz <keiths@redhat.com> wrote: > On 03/30/2010 01:29 AM, Hui Zhu wrote: >> >> Ping. Did I miss something? >> > > Nope -- I did. After the breakpoint commands API was fiddled with, I worked > up the original patch. Some (brief) time after committing my patch, the API > was fiddled with again. > > I apologize about the confusion. Try this patch, which I've committed. > > Keith > > ChangeLog > 2010-03-30 Keith Seitz <keiths@redhat.com> > > * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Breakpoint > commands are now reference counted. Adjust data pointers. > (gdb_get_tracepoint_info): Likewise. > (gdb_actions_command): Don't free previous actions. If the > commands aren't valid, we would prefer to keep the old ones > any way. break_point_set_commands will also clobber any > previous results anyway. > Hi Keith, I try this patch bug cannot patch to cvs-head. The attachment is the rej file that I got. Thanks, Hui [-- Attachment #2: gdbtk-bp.c.rej --] [-- Type: application/x-reject, Size: 2002 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-31 4:12 ` Hui Zhu @ 2010-03-31 4:28 ` Keith Seitz 2010-03-31 5:33 ` Hui Zhu 0 siblings, 1 reply; 13+ messages in thread From: Keith Seitz @ 2010-03-31 4:28 UTC (permalink / raw) To: Hui Zhu; +Cc: insight On 03/30/2010 08:19 PM, Hui Zhu wrote: > I try this patch bug cannot patch to cvs-head. The attachment is the > rej file that I got. Wow, it looks like the whole patch was rejected! I've committed this patch to CVS HEAD: can you pull it into your tree from there? Keith ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-31 4:28 ` Keith Seitz @ 2010-03-31 5:33 ` Hui Zhu 2010-03-31 5:37 ` Keith Seitz 0 siblings, 1 reply; 13+ messages in thread From: Hui Zhu @ 2010-03-31 5:33 UTC (permalink / raw) To: Keith Seitz; +Cc: insight On Wed, Mar 31, 2010 at 12:12, Keith Seitz <keiths@redhat.com> wrote: > On 03/30/2010 08:19 PM, Hui Zhu wrote: >> >> I try this patch bug cannot patch to cvs-head. The attachment is the >> rej file that I got. > > Wow, it looks like the whole patch was rejected! > > I've committed this patch to CVS HEAD: can you pull it into your tree from > there? > > Keith > Hi Keith, I tried to patch this patch to cvs-head that already have this patch. Sorry for my mistake. My part is OK now. Thanks for your work. Best, Hui ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: undefined reference to `set_breakpoint' 2010-03-31 5:33 ` Hui Zhu @ 2010-03-31 5:37 ` Keith Seitz 0 siblings, 0 replies; 13+ messages in thread From: Keith Seitz @ 2010-03-31 5:37 UTC (permalink / raw) To: Hui Zhu; +Cc: insight On 03/30/2010 10:25 PM, Hui Zhu wrote: > I tried to patch this patch to cvs-head that already have this patch. That would certainly explain why the whole patch failed to apply! :-) Keith ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2010-03-31 5:33 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-03-17 17:34 undefined reference to `set_breakpoint' Gene Smith 2010-03-17 17:57 ` Tom Tromey 2010-03-18 3:39 ` Keith Seitz 2010-03-18 4:58 ` Gene Smith 2010-03-19 4:32 ` Gene Smith 2010-03-20 5:33 ` Hui Zhu 2010-03-30 8:29 ` Hui Zhu 2010-03-30 16:48 ` Hui Zhu 2010-03-31 3:20 ` Keith Seitz 2010-03-31 4:12 ` Hui Zhu 2010-03-31 4:28 ` Keith Seitz 2010-03-31 5:33 ` Hui Zhu 2010-03-31 5:37 ` Keith Seitz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).