* [PATCH v2] stdio-common/printf-prs.c: Reword comment [not found] <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com> @ 2021-03-24 18:29 ` Alejandro Colomar 2021-03-29 21:04 ` Adhemerval Zanella 0 siblings, 1 reply; 4+ messages in thread From: Alejandro Colomar @ 2021-03-24 18:29 UTC (permalink / raw) To: libc-alpha; +Cc: Alejandro Colomar 'this' can be understood as the current parameter, but in this case it is meaning the other one, the one holding the width/precission. 'it' better describes that parameter, differentiating it from the one corresponding to the current specifier. Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> --- stdio-common/printf-prs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c index 1d4e00553d..8ebf09a0a9 100644 --- a/stdio-common/printf-prs.c +++ b/stdio-common/printf-prs.c @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) /* Parse this spec. */ nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); - /* If the width is determined by an argument this is an int. */ + /* If the width is determined by an argument, it is an int. */ if (spec.width_arg != -1 && (size_t) spec.width_arg < n) argtypes[spec.width_arg] = PA_INT; - /* If the precision is determined by an argument this is an int. */ + /* If the precision is determined by an argument, it is an int. */ if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) argtypes[spec.prec_arg] = PA_INT; -- 2.31.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] stdio-common/printf-prs.c: Reword comment 2021-03-24 18:29 ` [PATCH v2] stdio-common/printf-prs.c: Reword comment Alejandro Colomar @ 2021-03-29 21:04 ` Adhemerval Zanella 2021-03-29 21:53 ` Alejandro Colomar (man-pages) 0 siblings, 1 reply; 4+ messages in thread From: Adhemerval Zanella @ 2021-03-29 21:04 UTC (permalink / raw) To: Alejandro Colomar, libc-alpha On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: > 'this' can be understood as the current parameter, but in this case it > is meaning the other one, the one holding the width/precission. > > 'it' better describes that parameter, differentiating it from the > one corresponding to the current specifier. > > Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> We don't use SCO, but rather Copyright assignment. The rest looks good to me (although I am not a native speaker). Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > stdio-common/printf-prs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c > index 1d4e00553d..8ebf09a0a9 100644 > --- a/stdio-common/printf-prs.c > +++ b/stdio-common/printf-prs.c > @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) > /* Parse this spec. */ > nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); > > - /* If the width is determined by an argument this is an int. */ > + /* If the width is determined by an argument, it is an int. */ > if (spec.width_arg != -1 && (size_t) spec.width_arg < n) > argtypes[spec.width_arg] = PA_INT; > > - /* If the precision is determined by an argument this is an int. */ > + /* If the precision is determined by an argument, it is an int. */ > if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) > argtypes[spec.prec_arg] = PA_INT; > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] stdio-common/printf-prs.c: Reword comment 2021-03-29 21:04 ` Adhemerval Zanella @ 2021-03-29 21:53 ` Alejandro Colomar (man-pages) 2021-03-30 12:12 ` Adhemerval Zanella 0 siblings, 1 reply; 4+ messages in thread From: Alejandro Colomar (man-pages) @ 2021-03-29 21:53 UTC (permalink / raw) To: Adhemerval Zanella, libc-alpha On 3/29/21 11:04 PM, Adhemerval Zanella wrote: > > > On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: >> 'this' can be understood as the current parameter, but in this case it >> is meaning the other one, the one holding the width/precission. >> >> 'it' better describes that parameter, differentiating it from the >> one corresponding to the current specifier. >> >> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> > > We don't use SCO, but rather Copyright assignment. The rest looks good > to me (although I am not a native speaker). I hope you don't need a copyright assignment for such a small change :). I guess a simple statement in this email that you can do as you wish with this patch should be enough. Anyway, I hereby assign copyright of this patch to the glibc copyright holder(s). Cheers, Alex > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > >> --- >> stdio-common/printf-prs.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c >> index 1d4e00553d..8ebf09a0a9 100644 >> --- a/stdio-common/printf-prs.c >> +++ b/stdio-common/printf-prs.c >> @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) >> /* Parse this spec. */ >> nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); >> >> - /* If the width is determined by an argument this is an int. */ >> + /* If the width is determined by an argument, it is an int. */ >> if (spec.width_arg != -1 && (size_t) spec.width_arg < n) >> argtypes[spec.width_arg] = PA_INT; >> >> - /* If the precision is determined by an argument this is an int. */ >> + /* If the precision is determined by an argument, it is an int. */ >> if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) >> argtypes[spec.prec_arg] = PA_INT; >> >> -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] stdio-common/printf-prs.c: Reword comment 2021-03-29 21:53 ` Alejandro Colomar (man-pages) @ 2021-03-30 12:12 ` Adhemerval Zanella 0 siblings, 0 replies; 4+ messages in thread From: Adhemerval Zanella @ 2021-03-30 12:12 UTC (permalink / raw) To: Alejandro Colomar (man-pages), libc-alpha On 29/03/2021 18:53, Alejandro Colomar (man-pages) wrote: > > > On 3/29/21 11:04 PM, Adhemerval Zanella wrote: >> >> >> On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: >>> 'this' can be understood as the current parameter, but in this case it >>> is meaning the other one, the one holding the width/precission. >>> >>> 'it' better describes that parameter, differentiating it from the >>> one corresponding to the current specifier. >>> >>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> >> >> We don't use SCO, but rather Copyright assignment. The rest looks good >> to me (although I am not a native speaker). > > I hope you don't need a copyright assignment for such a small change :). > I guess a simple statement in this email that you can do as you wish > with this patch should be enough. I don't think it would require for such changes, it is more a warning that we do use 'Signed-off-by:' in the patch submission. > > Anyway, I hereby assign copyright of this patch to the glibc copyright > holder(s). This change is simple and fits in the trivial one, I will push it for you. > > Cheers, > > Alex > > > >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> >> >>> --- >>> stdio-common/printf-prs.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c >>> index 1d4e00553d..8ebf09a0a9 100644 >>> --- a/stdio-common/printf-prs.c >>> +++ b/stdio-common/printf-prs.c >>> @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) >>> /* Parse this spec. */ >>> nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); >>> >>> - /* If the width is determined by an argument this is an int. */ >>> + /* If the width is determined by an argument, it is an int. */ >>> if (spec.width_arg != -1 && (size_t) spec.width_arg < n) >>> argtypes[spec.width_arg] = PA_INT; >>> >>> - /* If the precision is determined by an argument this is an int. */ >>> + /* If the precision is determined by an argument, it is an int. */ >>> if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) >>> argtypes[spec.prec_arg] = PA_INT; >>> >>> > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-30 12:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com>
2021-03-24 18:29 ` [PATCH v2] stdio-common/printf-prs.c: Reword comment Alejandro Colomar
2021-03-29 21:04 ` Adhemerval Zanella
2021-03-29 21:53 ` Alejandro Colomar (man-pages)
2021-03-30 12:12 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).