From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, libc-alpha@sourceware.org
Cc: "Florian Weimer" <fweimer@redhat.com>,
"Cristian Rodríguez" <crrodriguez@opensuse.org>,
"Paul Eggert" <eggert@cs.ucla.edu>,
"Mark Harris" <mark.hsj@gmail.com>,
"Eric Biggers" <ebiggers@kernel.org>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v4] arc4random: simplify design for better safety
Date: Tue, 26 Jul 2022 13:20:11 -0300 [thread overview]
Message-ID: <45ef8ca0-12ca-4853-98a0-9f52dfca8c57@linaro.org> (raw)
In-Reply-To: <20220726133049.1145913-1-Jason@zx2c4.com>
On 26/07/22 10:30, Jason A. Donenfeld wrote:
> + l = __getrandom_nocancel (p, n, 0);
> + if (l > 0)
> + {
> + if ((size_t) l == n)
> + return; /* Done reading, success. */
> + p = (uint8_t *) p + l;
> + n -= l;
> + continue; /* Interrupted by a signal; keep going. */
> + }
> + else if (l == 0)
> + arc4random_getrandom_failure (); /* Weird, should never happen. */
> + else if (l == -EINTR)
> + continue; /* Interrupted by a signal; keep going. */
> + else if (!__ASSUME_GETRANDOM && l == -ENOSYS)
> + {
> + atomic_store_relaxed (&have_getrandom, false);
I still think there is no much gain in this optimization, the syscall will
most likely be present and it is one less static data. Also, we avoid to
use __ASSUME_GETRANDOM on generic code (all __ASSUME usage within
sysdeps and/or nptl).
> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
> index 2ccc92b6b8..2f4f9784ee 100644
> --- a/sysdeps/unix/sysv/linux/Makefile
> +++ b/sysdeps/unix/sysv/linux/Makefile
> @@ -380,7 +380,8 @@ sysdep_routines += xstatconv internal_statvfs \
> open_nocancel open64_nocancel \
> openat_nocancel openat64_nocancel \
> read_nocancel pread64_nocancel \
> - write_nocancel statx_cp stat_t64_cp
> + write_nocancel statx_cp stat_t64_cp \
> + ppoll_nocancel
>
> sysdep_headers += bits/fcntl-linux.h
>
> diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions
> index 65d2ceda2c..febe1ad421 100644
> --- a/sysdeps/unix/sysv/linux/Versions
> +++ b/sysdeps/unix/sysv/linux/Versions
> @@ -320,6 +320,7 @@ libc {
> __read_nocancel;
> __pread64_nocancel;
> __close_nocancel;
> + __ppoll_infinity_nocancel;
> __sigtimedwait;
> # functions used by nscd
> __netlink_assert_response;
There is no need to export on GLIBC_PRIVATE, since it is not currently usage
libc.so. Just define is a hidden (attribute_hidden).
> diff --git a/sysdeps/unix/sysv/linux/kernel-features.h b/sysdeps/unix/sysv/linux/kernel-features.h
> index 74adc3956b..75d5f953d4 100644
> --- a/sysdeps/unix/sysv/linux/kernel-features.h
> +++ b/sysdeps/unix/sysv/linux/kernel-features.h
> @@ -236,4 +236,11 @@
> # define __ASSUME_FUTEX_LOCK_PI2 0
> #endif
>
> +/* The getrandom() syscall was added in 3.17. */
> +#if __LINUX_KERNEL_VERSION >= 0x031100
> +# define __ASSUME_GETRANDOM 1
> +#else
> +# define __ASSUME_GETRANDOM 0
> +#endif
> +
> #endif /* kernel-features.h */
> diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h
> index 2c58d5ae2f..d3df8fa79e 100644
> --- a/sysdeps/unix/sysv/linux/not-cancel.h
> +++ b/sysdeps/unix/sysv/linux/not-cancel.h
> @@ -23,6 +23,7 @@
> #include <sysdep.h>
> #include <errno.h>
> #include <unistd.h>
> +#include <sys/poll.h>
> #include <sys/syscall.h>
> #include <sys/wait.h>
> #include <time.h>
> @@ -77,6 +78,10 @@ __getrandom_nocancel (void *buf, size_t buflen, unsigned int flags)
> /* Uncancelable fcntl. */
> __typeof (__fcntl) __fcntl64_nocancel;
>
> +/* Uncancelable ppoll. */
> +int
> +__ppoll_infinity_nocancel (struct pollfd *fds, nfds_t nfds);
Use attribute_hidden here and remove it from sysdeps/unix/sysv/linux/Versions.
> +
> #if IS_IN (libc) || IS_IN (rtld)
> hidden_proto (__open_nocancel)
> hidden_proto (__open64_nocancel)
> @@ -87,6 +92,7 @@ hidden_proto (__pread64_nocancel)
> hidden_proto (__write_nocancel)
> hidden_proto (__close_nocancel)
> hidden_proto (__fcntl64_nocancel)
> +hidden_proto (__ppoll_infinity_nocancel)
> #endif
>
> #endif /* NOT_CANCEL_H */
Also update the hurd sysdeps/mach/hurd/not-cancel.h with a wrapper to
__poll (since it does not really support pthread cancellation).
> diff --git a/sysdeps/generic/chacha20_arch.h b/sysdeps/unix/sysv/linux/ppoll_nocancel.c
> similarity index 62%
> rename from sysdeps/generic/chacha20_arch.h
> rename to sysdeps/unix/sysv/linux/ppoll_nocancel.c
> index 1b4559ccbc..28c8761566 100644
> --- a/sysdeps/generic/chacha20_arch.h
> +++ b/sysdeps/unix/sysv/linux/ppoll_nocancel.c
> @@ -1,5 +1,5 @@
> -/* Chacha20 implementation, generic interface for encrypt.
> - Copyright (C) 2022 Free Software Foundation, Inc.
> +/* Linux ppoll syscall implementation -- non-cancellable.
> + Copyright (C) 2018-2022 Free Software Foundation, Inc.
> This file is part of the GNU C Library.
>
> The GNU C Library is free software; you can redistribute it and/or
> @@ -16,9 +16,16 @@
> License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> -static inline void
> -chacha20_crypt (uint32_t *state, uint8_t *dst, const uint8_t *src,
> - size_t bytes)
> +#include <unistd.h>
> +#include <sysdep-cancel.h>
> +#include <not-cancel.h>
> +
> +int
> +__ppoll_infinity_nocancel (struct pollfd *fds, nfds_t nfds)
> {
> - chacha20_crypt_generic (state, dst, src, bytes);
> +#ifndef __NR_ppoll_time64
> +# define __NR_ppoll_time64 __NR_ppoll
> +#endif
> + return INLINE_SYSCALL_CALL (ppoll_time64, fds, nfds, NULL, NULL, 0);
> }
> +hidden_def (__ppoll_infinity_nocancel)
Maybe just add an inline wrapper on sysdeps/unix/sysv/linux/not-cancel.h,
as for __getrandom_nocancel:
static inline int
__ppoll_infinity_nocancel (struct pollfd *fds, nfds_t nfds)
{
#ifndef __NR_ppoll_time64
# define __NR_ppoll_time64 __NR_ppoll
#endif
return INLINE_SYSCALL_CALL (ppoll_time64, fds, nfds, NULL, NULL, 0);
}
It avoids a lot of boilerplate code to add the internal symbol.
next prev parent reply other threads:[~2022-07-26 16:20 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YtwgTySJyky0OcgG@zx2c4.com>
2022-07-23 16:25 ` arc4random - are you sure we want these? Jason A. Donenfeld
2022-07-23 17:18 ` Paul Eggert
2022-07-24 23:55 ` Jason A. Donenfeld
2022-07-25 20:31 ` Paul Eggert
2022-07-23 17:39 ` Adhemerval Zanella Netto
2022-07-23 22:54 ` Jason A. Donenfeld
2022-07-25 15:33 ` Rich Felker
2022-07-25 15:59 ` Adhemerval Zanella Netto
2022-07-25 17:41 ` Rich Felker
2022-07-25 16:18 ` Sandy Harris
2022-07-25 16:40 ` Florian Weimer
2022-07-25 16:49 ` Adhemerval Zanella Netto
2022-07-25 16:51 ` Jason A. Donenfeld
2022-07-25 17:44 ` Rich Felker
2022-07-25 18:33 ` Cristian Rodríguez
2022-07-25 18:49 ` Rich Felker
2022-07-27 1:54 ` Theodore Ts'o
2022-07-27 2:16 ` Rich Felker
2022-07-27 2:45 ` Theodore Ts'o
2022-07-27 11:34 ` Adhemerval Zanella Netto
2022-07-27 12:32 ` Theodore Ts'o
2022-07-27 12:49 ` Florian Weimer
2022-07-27 20:15 ` Theodore Ts'o
2022-07-27 21:59 ` Rich Felker
2022-07-28 0:30 ` Theodore Ts'o
2022-07-28 0:39 ` Cristian Rodríguez
2022-07-27 15:39 ` Rich Felker
2022-07-23 19:04 ` Cristian Rodríguez
2022-07-23 22:59 ` Jason A. Donenfeld
2022-07-24 16:23 ` Cristian Rodríguez
2022-07-24 21:57 ` Jason A. Donenfeld
2022-07-25 10:14 ` Florian Weimer
2022-07-25 10:11 ` Florian Weimer
2022-07-25 11:04 ` Jason A. Donenfeld
2022-07-25 12:39 ` Florian Weimer
2022-07-25 13:43 ` Jason A. Donenfeld
2022-07-25 13:58 ` Cristian Rodríguez
2022-07-25 16:06 ` Rich Felker
2022-07-25 16:43 ` Florian Weimer
2022-07-26 14:27 ` Overwrittting AT_RANDOM after use (was Re: arc4random - are you sure we want these?) Yann Droneaud
2022-07-26 14:35 ` arc4random - are you sure we want these? Yann Droneaud
2022-07-25 13:25 ` Jeffrey Walton
2022-07-25 13:48 ` Jason A. Donenfeld
2022-07-25 14:56 ` Rich Felker
2022-07-25 22:57 ` [PATCH] arc4random: simplify design for better safety Jason A. Donenfeld
2022-07-25 23:11 ` Jason A. Donenfeld
2022-07-25 23:28 ` [PATCH v2] " Jason A. Donenfeld
2022-07-25 23:59 ` Eric Biggers
2022-07-26 10:26 ` Jason A. Donenfeld
2022-07-26 1:10 ` Mark Harris
2022-07-26 10:41 ` Jason A. Donenfeld
2022-07-26 11:06 ` Florian Weimer
2022-07-26 16:51 ` Mark Harris
2022-07-26 18:42 ` Jason A. Donenfeld
2022-07-26 19:18 ` Adhemerval Zanella Netto
2022-07-26 19:24 ` Jason A. Donenfeld
2022-07-26 9:55 ` Florian Weimer
2022-07-26 11:04 ` Jason A. Donenfeld
2022-07-26 11:07 ` [PATCH v3] " Jason A. Donenfeld
2022-07-26 11:11 ` Jason A. Donenfeld
2022-07-26 11:12 ` [PATCH v2] " Florian Weimer
2022-07-26 11:20 ` Jason A. Donenfeld
2022-07-26 11:35 ` Adhemerval Zanella Netto
2022-07-26 11:33 ` Adhemerval Zanella Netto
2022-07-26 11:54 ` Jason A. Donenfeld
2022-07-26 12:08 ` Jason A. Donenfeld
2022-07-26 12:20 ` Jason A. Donenfeld
2022-07-26 12:34 ` Adhemerval Zanella Netto
2022-07-26 12:47 ` Jason A. Donenfeld
2022-07-26 13:11 ` Adhemerval Zanella Netto
2022-07-26 13:30 ` [PATCH v4] " Jason A. Donenfeld
2022-07-26 15:21 ` Yann Droneaud
2022-07-26 16:20 ` Adhemerval Zanella Netto [this message]
2022-07-26 18:36 ` Jason A. Donenfeld
2022-07-26 19:08 ` [PATCH v5] " Jason A. Donenfeld
2022-07-26 19:58 ` [PATCH v6] " Jason A. Donenfeld
2022-07-26 20:17 ` Adhemerval Zanella Netto
2022-07-26 20:56 ` Adhemerval Zanella Netto
2022-07-28 10:29 ` Szabolcs Nagy
2022-07-28 10:36 ` Szabolcs Nagy
2022-07-28 11:01 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ef8ca0-12ca-4853-98a0-9f52dfca8c57@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Jason@zx2c4.com \
--cc=crrodriguez@opensuse.org \
--cc=ebiggers@kernel.org \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-crypto@vger.kernel.org \
--cc=mark.hsj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).