* [PATCH v2] riscv: Update nofpu libm test ulps
@ 2024-03-06 18:08 Darius Rad
2024-03-11 13:19 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Darius Rad @ 2024-03-06 18:08 UTC (permalink / raw)
To: libc-alpha
Fix two test failures.
---
Changes since v1:
- Rebase to master
- Fix corrupted diff line in patch
sysdeps/riscv/nofpu/libm-test-ulps | 1 +
1 file changed, 1 insertion(+)
diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
index 16106f10b0..bc7e615177 100644
--- a/sysdeps/riscv/nofpu/libm-test-ulps
+++ b/sysdeps/riscv/nofpu/libm-test-ulps
@@ -1043,6 +1043,7 @@ ldouble: 8
Function: "hypot":
double: 1
+float: 1
ldouble: 1
Function: "hypot_downward":
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] riscv: Update nofpu libm test ulps
2024-03-06 18:08 [PATCH v2] riscv: Update nofpu libm test ulps Darius Rad
@ 2024-03-11 13:19 ` Florian Weimer
2024-03-11 18:56 ` Darius Rad
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2024-03-11 13:19 UTC (permalink / raw)
To: libc-alpha
* Darius Rad:
> Fix two test failures.
> ---
> Changes since v1:
> - Rebase to master
> - Fix corrupted diff line in patch
>
> sysdeps/riscv/nofpu/libm-test-ulps | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> index 16106f10b0..bc7e615177 100644
> --- a/sysdeps/riscv/nofpu/libm-test-ulps
> +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> @@ -1043,6 +1043,7 @@ ldouble: 8
>
> Function: "hypot":
> double: 1
> +float: 1
> ldouble: 1
>
> Function: "hypot_downward":
Looks okay.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Do you have sourceware commit access? If not, I can push the change for
you.
(ULP updates like this can also be pushed without review as obvious, I
think.)
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] riscv: Update nofpu libm test ulps
2024-03-11 13:19 ` Florian Weimer
@ 2024-03-11 18:56 ` Darius Rad
2024-03-18 10:29 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Darius Rad @ 2024-03-11 18:56 UTC (permalink / raw)
To: libc-alpha
On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote:
> * Darius Rad:
>
> > Fix two test failures.
> > ---
> > Changes since v1:
> > - Rebase to master
> > - Fix corrupted diff line in patch
> >
> > sysdeps/riscv/nofpu/libm-test-ulps | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> > index 16106f10b0..bc7e615177 100644
> > --- a/sysdeps/riscv/nofpu/libm-test-ulps
> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> > @@ -1043,6 +1043,7 @@ ldouble: 8
> >
> > Function: "hypot":
> > double: 1
> > +float: 1
> > ldouble: 1
> >
> > Function: "hypot_downward":
>
> Looks okay.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
>
> Do you have sourceware commit access? If not, I can push the change for
> you.
I do not. If you could commit it, I would appreciate it.
>
> (ULP updates like this can also be pushed without review as obvious, I
> think.)
>
> Thanks,
> Florian
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] riscv: Update nofpu libm test ulps
2024-03-11 18:56 ` Darius Rad
@ 2024-03-18 10:29 ` Florian Weimer
0 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer @ 2024-03-18 10:29 UTC (permalink / raw)
To: libc-alpha
* Darius Rad:
> On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote:
>> * Darius Rad:
>>
>> > Fix two test failures.
>> > ---
>> > Changes since v1:
>> > - Rebase to master
>> > - Fix corrupted diff line in patch
>> >
>> > sysdeps/riscv/nofpu/libm-test-ulps | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
>> > index 16106f10b0..bc7e615177 100644
>> > --- a/sysdeps/riscv/nofpu/libm-test-ulps
>> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps
>> > @@ -1043,6 +1043,7 @@ ldouble: 8
>> >
>> > Function: "hypot":
>> > double: 1
>> > +float: 1
>> > ldouble: 1
>> >
>> > Function: "hypot_downward":
>>
>> Looks okay.
>>
>> Reviewed-by: Florian Weimer <fweimer@redhat.com>
>>
>> Do you have sourceware commit access? If not, I can push the change for
>> you.
>
> I do not. If you could commit it, I would appreciate it.
I pushed it on your behalf.
Thanks,
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-18 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 18:08 [PATCH v2] riscv: Update nofpu libm test ulps Darius Rad
2024-03-11 13:19 ` Florian Weimer
2024-03-11 18:56 ` Darius Rad
2024-03-18 10:29 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).