[PATCH v2] riscv: Update nofpu libm test ulps

[PATCH v2] riscv: Update nofpu libm test ulps

[Darius Rad]

Fix two test failures.
---
Changes since v1:
  - Rebase to master
  - Fix corrupted diff line in patch

 sysdeps/riscv/nofpu/libm-test-ulps | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
index 16106f10b0..bc7e615177 100644
--- a/sysdeps/riscv/nofpu/libm-test-ulps
+++ b/sysdeps/riscv/nofpu/libm-test-ulps
@@ -1043,6 +1043,7 @@ ldouble: 8
 
 Function: "hypot":
 double: 1
+float: 1
 ldouble: 1
 
 Function: "hypot_downward":
-- 
2.43.0

Re: [PATCH v2] riscv: Update nofpu libm test ulps

[Florian Weimer]

* Darius Rad:

> Fix two test failures.
> ---
> Changes since v1:
>   - Rebase to master
>   - Fix corrupted diff line in patch
>
>  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> index 16106f10b0..bc7e615177 100644
> --- a/sysdeps/riscv/nofpu/libm-test-ulps
> +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> @@ -1043,6 +1043,7 @@ ldouble: 8
>  
>  Function: "hypot":
>  double: 1
> +float: 1
>  ldouble: 1
>  
>  Function: "hypot_downward":

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Do you have sourceware commit access?  If not, I can push the change for
you.

(ULP updates like this can also be pushed without review as obvious, I
think.)

Thanks,
Florian

Re: [PATCH v2] riscv: Update nofpu libm test ulps

[Darius Rad]

On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote:
> * Darius Rad:
> 
> > Fix two test failures.
> > ---
> > Changes since v1:
> >   - Rebase to master
> >   - Fix corrupted diff line in patch
> >
> >  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> > index 16106f10b0..bc7e615177 100644
> > --- a/sysdeps/riscv/nofpu/libm-test-ulps
> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> > @@ -1043,6 +1043,7 @@ ldouble: 8
> >  
> >  Function: "hypot":
> >  double: 1
> > +float: 1
> >  ldouble: 1
> >  
> >  Function: "hypot_downward":
> 
> Looks okay.
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
> 
> Do you have sourceware commit access?  If not, I can push the change for
> you.

I do not.  If you could commit it, I would appreciate it.

> 
> (ULP updates like this can also be pushed without review as obvious, I
> think.)
> 
> Thanks,
> Florian
> 

Re: [PATCH v2] riscv: Update nofpu libm test ulps

[Florian Weimer]

* Darius Rad:

> On Mon, Mar 11, 2024 at 02:19:03PM +0100, Florian Weimer wrote:
>> * Darius Rad:
>> 
>> > Fix two test failures.
>> > ---
>> > Changes since v1:
>> >   - Rebase to master
>> >   - Fix corrupted diff line in patch
>> >
>> >  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
>> > index 16106f10b0..bc7e615177 100644
>> > --- a/sysdeps/riscv/nofpu/libm-test-ulps
>> > +++ b/sysdeps/riscv/nofpu/libm-test-ulps
>> > @@ -1043,6 +1043,7 @@ ldouble: 8
>> >  
>> >  Function: "hypot":
>> >  double: 1
>> > +float: 1
>> >  ldouble: 1
>> >  
>> >  Function: "hypot_downward":
>> 
>> Looks okay.
>> 
>> Reviewed-by: Florian Weimer <fweimer@redhat.com>
>> 
>> Do you have sourceware commit access?  If not, I can push the change for
>> you.
>
> I do not.  If you could commit it, I would appreciate it.

I pushed it on your behalf.

Thanks,
Florian

Re: [PATCH v2] riscv: Update nofpu libm test ulps

[Andreas K. Huettel]

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

Pushed, thanks!

Am Mittwoch, 8. Januar 2025, 21:03:56 Mitteleuropäische Normalzeit schrieb Darius Rad:
> Fixes math test failures.
> 
> ---
> I would appreciate it if someone could commit this for me as I do not have
> access.
> 
> ---
>  sysdeps/riscv/nofpu/libm-test-ulps | 44 ++++++++++++++++++++++++++++++++++----
>  1 file changed, 40 insertions(+), 4 deletions(-)
> 
> diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> index 055826625c..d971ee20b9 100644
> --- a/sysdeps/riscv/nofpu/libm-test-ulps
> +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> @@ -33,6 +33,11 @@ Function: "acosh_upward":
>  double: 2
>  ldouble: 2
>  
> +Function: "acospi":
> +double: 2
> +float: 1
> +ldouble: 2
> +
>  Function: "asin":
>  double: 1
>  ldouble: 1
> @@ -65,6 +70,11 @@ Function: "asinh_upward":
>  double: 3
>  ldouble: 4
>  
> +Function: "asinpi":
> +double: 1
> +float: 1
> +ldouble: 2
> +
>  Function: "atan":
>  double: 1
>  ldouble: 1
> @@ -84,6 +94,11 @@ Function: "atan2_upward":
>  double: 1
>  ldouble: 2
>  
> +Function: "atan2pi":
> +double: 1
> +float: 1
> +ldouble: 3
> +
>  Function: "atan_downward":
>  double: 1
>  ldouble: 2
> @@ -112,6 +127,11 @@ Function: "atanh_upward":
>  double: 3
>  ldouble: 4
>  
> +Function: "atanpi":
> +double: 2
> +float: 1
> +ldouble: 2
> +
>  Function: "cabs":
>  double: 1
>  ldouble: 1
> @@ -632,6 +652,11 @@ Function: "cosh_upward":
>  double: 1
>  ldouble: 3
>  
> +Function: "cospi":
> +double: 2
> +float: 2
> +ldouble: 2
> +
>  Function: Real part of "cpow":
>  double: 2
>  float: 5
> @@ -677,6 +702,7 @@ float: 1
>  ldouble: 1
>  
>  Function: Imaginary part of "csin":
> +float: 1
>  ldouble: 1
>  
>  Function: Real part of "csin_downward":
> @@ -925,8 +951,8 @@ float: 1
>  ldouble: 3
>  
>  Function: "exp10m1":
> -double: 2
> -ldouble: 1
> +double: 3
> +ldouble: 3
>  
>  Function: "exp2":
>  double: 1
> @@ -946,8 +972,8 @@ float: 1
>  ldouble: 2
>  
>  Function: "exp2m1":
> -double: 1
> -ldouble: 1
> +double: 2
> +ldouble: 2
>  
>  Function: "exp_downward":
>  double: 1
> @@ -1248,6 +1274,11 @@ Function: "sinh_upward":
>  double: 3
>  ldouble: 4
>  
> +Function: "sinpi":
> +double: 2
> +float: 2
> +ldouble: 2
> +
>  Function: "tan":
>  ldouble: 1
>  
> @@ -1279,6 +1310,11 @@ Function: "tanh_upward":
>  double: 3
>  ldouble: 3
>  
> +Function: "tanpi":
> +double: 3
> +float: 3
> +ldouble: 3
> +
>  Function: "tgamma":
>  double: 9
>  ldouble: 4
> 


-- 
PD Dr. Andreas K. Huettel
Institute for Experimental and Applied Physics
University of Regensburg
93040 Regensburg
Germany

tel. +49 151 241 67748 (mobile)
tel. +49 941 943 1618 (office)
e-mail andreas.huettel@ur.de
https://www.akhuettel.de/
https://www.akhuettel.de/group/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

[PATCH v2] riscv: Update nofpu libm test ulps

[Darius Rad]

Fixes math test failures.

---
I would appreciate it if someone could commit this for me as I do not have
access.

---
 sysdeps/riscv/nofpu/libm-test-ulps | 44 ++++++++++++++++++++++++++++++++++----
 1 file changed, 40 insertions(+), 4 deletions(-)

diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
index 055826625c..d971ee20b9 100644
--- a/sysdeps/riscv/nofpu/libm-test-ulps
+++ b/sysdeps/riscv/nofpu/libm-test-ulps
@@ -33,6 +33,11 @@ Function: "acosh_upward":
 double: 2
 ldouble: 2
 
+Function: "acospi":
+double: 2
+float: 1
+ldouble: 2
+
 Function: "asin":
 double: 1
 ldouble: 1
@@ -65,6 +70,11 @@ Function: "asinh_upward":
 double: 3
 ldouble: 4
 
+Function: "asinpi":
+double: 1
+float: 1
+ldouble: 2
+
 Function: "atan":
 double: 1
 ldouble: 1
@@ -84,6 +94,11 @@ Function: "atan2_upward":
 double: 1
 ldouble: 2
 
+Function: "atan2pi":
+double: 1
+float: 1
+ldouble: 3
+
 Function: "atan_downward":
 double: 1
 ldouble: 2
@@ -112,6 +127,11 @@ Function: "atanh_upward":
 double: 3
 ldouble: 4
 
+Function: "atanpi":
+double: 2
+float: 1
+ldouble: 2
+
 Function: "cabs":
 double: 1
 ldouble: 1
@@ -632,6 +652,11 @@ Function: "cosh_upward":
 double: 1
 ldouble: 3
 
+Function: "cospi":
+double: 2
+float: 2
+ldouble: 2
+
 Function: Real part of "cpow":
 double: 2
 float: 5
@@ -677,6 +702,7 @@ float: 1
 ldouble: 1
 
 Function: Imaginary part of "csin":
+float: 1
 ldouble: 1
 
 Function: Real part of "csin_downward":
@@ -925,8 +951,8 @@ float: 1
 ldouble: 3
 
 Function: "exp10m1":
-double: 2
-ldouble: 1
+double: 3
+ldouble: 3
 
 Function: "exp2":
 double: 1
@@ -946,8 +972,8 @@ float: 1
 ldouble: 2
 
 Function: "exp2m1":
-double: 1
-ldouble: 1
+double: 2
+ldouble: 2
 
 Function: "exp_downward":
 double: 1
@@ -1248,6 +1274,11 @@ Function: "sinh_upward":
 double: 3
 ldouble: 4
 
+Function: "sinpi":
+double: 2
+float: 2
+ldouble: 2
+
 Function: "tan":
 ldouble: 1
 
@@ -1279,6 +1310,11 @@ Function: "tanh_upward":
 double: 3
 ldouble: 3
 
+Function: "tanpi":
+double: 3
+float: 3
+ldouble: 3
+
 Function: "tgamma":
 double: 9
 ldouble: 4