* [PATCH] PR 107189 Remove useless _Alloc_node
@ 2022-10-12 20:18 François Dumont
2022-11-14 17:56 ` François Dumont
0 siblings, 1 reply; 5+ messages in thread
From: François Dumont @ 2022-10-12 20:18 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]
libstdc++-v3/ChangeLog:
PR libstdc++/107189
* include/bits/stl_tree.h
(_Rb_tree<>::_M_insert_range_equal): Remove
unused _Alloc_node instance.
Ok to commit ?
François
[-- Attachment #2: pr107189.patch --]
[-- Type: text/x-patch, Size: 510 bytes --]
diff --git a/libstdc++-v3/include/bits/stl_tree.h b/libstdc++-v3/include/bits/stl_tree.h
index a4de6141765..33d25089a1d 100644
--- a/libstdc++-v3/include/bits/stl_tree.h
+++ b/libstdc++-v3/include/bits/stl_tree.h
@@ -1123,7 +1123,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
__enable_if_t<!__same_value_type<_InputIterator>::value>
_M_insert_range_equal(_InputIterator __first, _InputIterator __last)
{
- _Alloc_node __an(*this);
for (; __first != __last; ++__first)
_M_emplace_equal(*__first);
}
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PR 107189 Remove useless _Alloc_node
2022-10-12 20:18 [PATCH] PR 107189 Remove useless _Alloc_node François Dumont
@ 2022-11-14 17:56 ` François Dumont
2023-01-04 21:13 ` François Dumont
0 siblings, 1 reply; 5+ messages in thread
From: François Dumont @ 2022-11-14 17:56 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
Gentle reminder.
Sorry if I should have committed it as trivial but I cannot do it
anymore now that I asked :-)
On 12/10/22 22:18, François Dumont wrote:
> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]
>
> libstdc++-v3/ChangeLog:
>
> PR libstdc++/107189
> * include/bits/stl_tree.h
> (_Rb_tree<>::_M_insert_range_equal): Remove
> unused _Alloc_node instance.
>
> Ok to commit ?
>
> François
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PR 107189 Remove useless _Alloc_node
2022-11-14 17:56 ` François Dumont
@ 2023-01-04 21:13 ` François Dumont
2023-01-12 12:01 ` Jonathan Wakely
0 siblings, 1 reply; 5+ messages in thread
From: François Dumont @ 2023-01-04 21:13 UTC (permalink / raw)
To: libstdc++; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Still no chance to review ?
On 14/11/22 18:56, François Dumont wrote:
> Gentle reminder.
>
> Sorry if I should have committed it as trivial but I cannot do it
> anymore now that I asked :-)
>
>
> On 12/10/22 22:18, François Dumont wrote:
>> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]
>>
>> libstdc++-v3/ChangeLog:
>>
>> PR libstdc++/107189
>> * include/bits/stl_tree.h
>> (_Rb_tree<>::_M_insert_range_equal): Remove
>> unused _Alloc_node instance.
>>
>> Ok to commit ?
>>
>> François
>
>
[-- Attachment #2: pr107189.patch --]
[-- Type: text/x-patch, Size: 510 bytes --]
diff --git a/libstdc++-v3/include/bits/stl_tree.h b/libstdc++-v3/include/bits/stl_tree.h
index a4de6141765..33d25089a1d 100644
--- a/libstdc++-v3/include/bits/stl_tree.h
+++ b/libstdc++-v3/include/bits/stl_tree.h
@@ -1123,7 +1123,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
__enable_if_t<!__same_value_type<_InputIterator>::value>
_M_insert_range_equal(_InputIterator __first, _InputIterator __last)
{
- _Alloc_node __an(*this);
for (; __first != __last; ++__first)
_M_emplace_equal(*__first);
}
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PR 107189 Remove useless _Alloc_node
2023-01-04 21:13 ` François Dumont
@ 2023-01-12 12:01 ` Jonathan Wakely
2023-01-12 12:02 ` Jonathan Wakely
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Wakely @ 2023-01-12 12:01 UTC (permalink / raw)
To: François Dumont; +Cc: libstdc++, gcc-patches
OK for trunk, sorry for not getting to it sooner.
On Wed, 4 Jan 2023 at 21:13, François Dumont via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> Still no chance to review ?
>
> On 14/11/22 18:56, François Dumont wrote:
> > Gentle reminder.
> >
> > Sorry if I should have committed it as trivial but I cannot do it
> > anymore now that I asked :-)
> >
> >
> > On 12/10/22 22:18, François Dumont wrote:
> >> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]
> >>
> >> libstdc++-v3/ChangeLog:
> >>
> >> PR libstdc++/107189
> >> * include/bits/stl_tree.h
> >> (_Rb_tree<>::_M_insert_range_equal): Remove
> >> unused _Alloc_node instance.
> >>
> >> Ok to commit ?
> >>
> >> François
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PR 107189 Remove useless _Alloc_node
2023-01-12 12:01 ` Jonathan Wakely
@ 2023-01-12 12:02 ` Jonathan Wakely
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Wakely @ 2023-01-12 12:02 UTC (permalink / raw)
To: François Dumont; +Cc: libstdc++, gcc-patches
On Thu, 12 Jan 2023 at 12:01, Jonathan Wakely wrote:
>
> OK for trunk, sorry for not getting to it sooner.
P.S. I do think this one would have been OK to commit as obvious,
since it's just removing an unused variable and so has no effect on
anything.
>
> On Wed, 4 Jan 2023 at 21:13, François Dumont via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
> >
> > Still no chance to review ?
> >
> > On 14/11/22 18:56, François Dumont wrote:
> > > Gentle reminder.
> > >
> > > Sorry if I should have committed it as trivial but I cannot do it
> > > anymore now that I asked :-)
> > >
> > >
> > > On 12/10/22 22:18, François Dumont wrote:
> > >> libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]
> > >>
> > >> libstdc++-v3/ChangeLog:
> > >>
> > >> PR libstdc++/107189
> > >> * include/bits/stl_tree.h
> > >> (_Rb_tree<>::_M_insert_range_equal): Remove
> > >> unused _Alloc_node instance.
> > >>
> > >> Ok to commit ?
> > >>
> > >> François
> > >
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-12 12:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 20:18 [PATCH] PR 107189 Remove useless _Alloc_node François Dumont
2022-11-14 17:56 ` François Dumont
2023-01-04 21:13 ` François Dumont
2023-01-12 12:01 ` Jonathan Wakely
2023-01-12 12:02 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).