public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c Date: Wed, 09 Aug 2006 19:33:00 -0000 [thread overview] Message-ID: <20060809193327.2538.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2006-08-09 19:33:25 Modified files: . : WHATS_NEW lib/metadata : metadata.c Log message: Add checks for duplicate LV name, lvid and PV id before writing metadata. Report all sanity check failures, not just the first. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.415&r2=1.416 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.94&r2=1.95 --- LVM2/WHATS_NEW 2006/08/08 21:20:00 1.415 +++ LVM2/WHATS_NEW 2006/08/09 19:33:25 1.416 @@ -1,5 +1,7 @@ Version 2.02.08 - ================================ + Add checks for duplicate LV name, lvid and PV id before writing metadata. + Report all sanity check failures, not just the first. Fix missing lockfs on first snapshot creation. Add unreliable --trustcache option to reporting commands. Fix locking for mimage removal. --- LVM2/lib/metadata/metadata.c 2006/07/04 19:36:49 1.94 +++ LVM2/lib/metadata/metadata.c 2006/08/09 19:33:25 1.95 @@ -722,23 +722,68 @@ int vg_validate(struct volume_group *vg) { - struct lv_list *lvl; + struct pv_list *pvl, *pvl2; + struct lv_list *lvl, *lvl2; + char uuid[64]; + int r = 1; + + list_iterate_items(pvl, &vg->pvs) { + list_iterate_items(pvl2, &vg->pvs) { + if (pvl == pvl2) + break; + if (id_equal(&pvl->pv->id, + &pvl2->pv->id)) { + if (!id_write_format(&pvl->pv->id, uuid, + sizeof(uuid))) + stack; + log_error("Internal error: Duplicate PV id " + "%s detected for %s in %s.", + uuid, dev_name(pvl->pv->dev), + vg->name); + r = 0; + } + } + } if (!check_pv_segments(vg)) { log_error("Internal error: PV segments corrupted in %s.", vg->name); - return 0; + r = 0; + } + + list_iterate_items(lvl, &vg->lvs) { + list_iterate_items(lvl2, &vg->lvs) { + if (lvl == lvl2) + break; + if (!strcmp(lvl->lv->name, lvl2->lv->name)) { + log_error("Internal error: Duplicate LV name " + "%s detected in %s.", lvl->lv->name, + vg->name); + r = 0; + } + if (id_equal(&lvl->lv->lvid.id[1], + &lvl2->lv->lvid.id[1])) { + if (!id_write_format(&lvl->lv->lvid.id[1], uuid, + sizeof(uuid))) + stack; + log_error("Internal error: Duplicate LV id " + "%s detected for %s and %s in %s.", + uuid, lvl->lv->name, lvl2->lv->name, + vg->name); + r = 0; + } + } } list_iterate_items(lvl, &vg->lvs) { if (!check_lv_segments(lvl->lv, 1)) { log_error("Internal error: LV segments corrupted in %s.", lvl->lv->name); - return 0; + r = 0; } } - return 1; + return r; } /*
next reply other threads:[~2006-08-09 19:33 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-08-09 19:33 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-12 14:18 zkabelac 2012-02-23 0:11 agk 2012-02-13 11:01 zkabelac 2012-02-13 10:58 zkabelac 2012-02-13 10:51 zkabelac 2011-11-18 19:28 zkabelac 2011-10-24 10:24 zkabelac 2011-08-11 16:31 prajnoha 2011-08-04 15:18 zkabelac 2011-03-29 21:57 zkabelac 2011-03-11 15:06 prajnoha 2011-03-10 13:12 zkabelac 2010-12-08 10:45 zkabelac 2010-11-29 11:08 zkabelac 2010-08-19 23:03 mbroz 2010-06-22 21:10 mbroz 2010-05-21 12:45 zkabelac 2010-04-01 11:43 agk 2010-03-02 21:56 snitzer 2010-01-21 21:09 wysochanski 2010-01-05 16:01 mbroz 2009-12-18 12:45 mbroz 2009-12-18 12:44 mbroz 2009-12-11 13:14 zkabelac 2009-12-09 19:29 mbroz 2009-08-20 7:03 mbroz 2009-07-16 3:25 wysochanski 2009-05-27 13:19 agk 2009-05-12 19:09 mbroz 2009-04-22 9:31 mbroz 2009-04-10 9:56 mbroz 2009-01-26 22:43 agk 2008-09-25 15:59 mbroz 2008-06-03 17:56 agk 2008-05-08 18:06 agk 2008-04-07 22:12 agk 2008-04-04 15:41 wysochanski 2007-10-12 18:37 wysochanski 2007-07-02 21:48 wysochanski 2006-09-21 20:25 agk 2006-07-04 19:36 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20060809193327.2538.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).