public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/metadata.c Date: Tue, 29 Mar 2011 21:57:00 -0000 [thread overview] Message-ID: <20110329215757.27165.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-03-29 21:57:56 Modified files: . : WHATS_NEW lib/metadata : metadata.c Log message: Use id_equal instead of strncmp() More consistent and easier to read. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1961&r2=1.1962 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.450&r2=1.451 --- LVM2/WHATS_NEW 2011/03/29 21:34:18 1.1961 +++ LVM2/WHATS_NEW 2011/03/29 21:57:56 1.1962 @@ -1,5 +1,6 @@ Version 2.02.85 - =================================== + Replace several strncmp() calls with id_equal(). Fix lvmcache_info transfer to orphan_vginfo in _lvmcache_update_vgname(). Fix -Wold-style-definition gcc warnings. Fixes for lvconvert (including --repair) of temporary mirror stacks. --- LVM2/lib/metadata/metadata.c 2011/03/14 17:00:57 1.450 +++ LVM2/lib/metadata/metadata.c 2011/03/29 21:57:56 1.451 @@ -3043,8 +3043,7 @@ continue; } - if (strncmp((char *)vg->id.uuid, - (char *)correct_vg->id.uuid, ID_LEN)) { + if (!id_equal(&vg->id, &correct_vg->id)) { inconsistent = 1; inconsistent_vgid = 1; } @@ -3292,7 +3291,7 @@ vginfo->vgname && !is_orphan_vg(vginfo->vgname)) { if ((vg = _vg_read(cmd, NULL, vgid, 1, &consistent, precommitted)) && - !strncmp((char *)vg->id.uuid, vgid, ID_LEN)) { + id_equal(&vg->id, (const struct id *)vgid)) { if (!consistent) log_error("Volume group %s metadata is " "inconsistent", vg->name); @@ -3323,7 +3322,7 @@ consistent = 0; if ((vg = _vg_read(cmd, vgname, vgid, 1, &consistent, precommitted)) && - !strncmp((char *)vg->id.uuid, vgid, ID_LEN)) { + id_equal(&vg->id, (const struct id *)vgid)) { if (!consistent) { log_error("Volume group %s metadata is " "inconsistent", vgname);
next reply other threads:[~2011-03-29 21:57 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-29 21:57 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-12 14:18 zkabelac 2012-02-23 0:11 agk 2012-02-13 11:01 zkabelac 2012-02-13 10:58 zkabelac 2012-02-13 10:51 zkabelac 2011-11-18 19:28 zkabelac 2011-10-24 10:24 zkabelac 2011-08-11 16:31 prajnoha 2011-08-04 15:18 zkabelac 2011-03-11 15:06 prajnoha 2011-03-10 13:12 zkabelac 2010-12-08 10:45 zkabelac 2010-11-29 11:08 zkabelac 2010-08-19 23:03 mbroz 2010-06-22 21:10 mbroz 2010-05-21 12:45 zkabelac 2010-04-01 11:43 agk 2010-03-02 21:56 snitzer 2010-01-21 21:09 wysochanski 2010-01-05 16:01 mbroz 2009-12-18 12:45 mbroz 2009-12-18 12:44 mbroz 2009-12-11 13:14 zkabelac 2009-12-09 19:29 mbroz 2009-08-20 7:03 mbroz 2009-07-16 3:25 wysochanski 2009-05-27 13:19 agk 2009-05-12 19:09 mbroz 2009-04-22 9:31 mbroz 2009-04-10 9:56 mbroz 2009-01-26 22:43 agk 2008-09-25 15:59 mbroz 2008-06-03 17:56 agk 2008-05-08 18:06 agk 2008-04-07 22:12 agk 2008-04-04 15:41 wysochanski 2007-10-12 18:37 wysochanski 2007-07-02 21:48 wysochanski 2006-09-21 20:25 agk 2006-08-09 19:33 agk 2006-07-04 19:36 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110329215757.27165.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).