* [PATCH] libc/include/math.h: Remove parameter name
@ 2020-09-21 15:29 Christophe Lyon
2020-09-22 22:07 ` Jeff Johnston
0 siblings, 1 reply; 4+ messages in thread
From: Christophe Lyon @ 2020-09-21 15:29 UTC (permalink / raw)
To: newlib
As discussed in GCC bug 97088
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
prototypes of library functions should use reserved names, or no name
at all.
This patch removes the 'x' parameter name from
extern int __isinff (float);
extern int __isinfd (double);
extern int __isnanf (float);
extern int __isnand (double);
extern int __fpclassifyf (float);
extern int __fpclassifyd (double);
extern int __signbitf (float);
extern int __signbitd (double);
to avoid possible clashes with user code in case someone uses
before including Newlib's math.h (or uses some other conflicting
definition)
---
newlib/libc/include/math.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
index 5e6155c..ba1a8a1 100644
--- a/newlib/libc/include/math.h
+++ b/newlib/libc/include/math.h
@@ -201,14 +201,14 @@ extern int isnan (double);
# define math_errhandling (_MATH_ERRHANDLING_ERRNO | _MATH_ERRHANDLING_ERREXCEPT)
#endif
-extern int __isinff (float x);
-extern int __isinfd (double x);
-extern int __isnanf (float x);
-extern int __isnand (double x);
-extern int __fpclassifyf (float x);
-extern int __fpclassifyd (double x);
-extern int __signbitf (float x);
-extern int __signbitd (double x);
+extern int __isinff (float);
+extern int __isinfd (double);
+extern int __isnanf (float);
+extern int __isnand (double);
+extern int __fpclassifyf (float);
+extern int __fpclassifyd (double);
+extern int __signbitf (float);
+extern int __signbitd (double);
/* Note: isinf and isnan were once functions in newlib that took double
* arguments. C99 specifies that these names are reserved for macros
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libc/include/math.h: Remove parameter name
2020-09-21 15:29 [PATCH] libc/include/math.h: Remove parameter name Christophe Lyon
@ 2020-09-22 22:07 ` Jeff Johnston
2020-09-23 9:23 ` Christophe Lyon
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Johnston @ 2020-09-22 22:07 UTC (permalink / raw)
To: Christophe Lyon; +Cc: Newlib
Hi Christophe,
Can you please resend the patch as an attachment?
Thanks,
-- Jeff J.
On Mon, Sep 21, 2020 at 11:29 AM Christophe Lyon via Newlib <
newlib@sourceware.org> wrote:
> As discussed in GCC bug 97088
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
> prototypes of library functions should use reserved names, or no name
> at all.
>
> This patch removes the 'x' parameter name from
> extern int __isinff (float);
> extern int __isinfd (double);
> extern int __isnanf (float);
> extern int __isnand (double);
> extern int __fpclassifyf (float);
> extern int __fpclassifyd (double);
> extern int __signbitf (float);
> extern int __signbitd (double);
>
> to avoid possible clashes with user code in case someone uses
> before including Newlib's math.h (or uses some other conflicting
> definition)
> ---
> newlib/libc/include/math.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
> index 5e6155c..ba1a8a1 100644
> --- a/newlib/libc/include/math.h
> +++ b/newlib/libc/include/math.h
> @@ -201,14 +201,14 @@ extern int isnan (double);
> # define math_errhandling (_MATH_ERRHANDLING_ERRNO |
> _MATH_ERRHANDLING_ERREXCEPT)
> #endif
>
> -extern int __isinff (float x);
> -extern int __isinfd (double x);
> -extern int __isnanf (float x);
> -extern int __isnand (double x);
> -extern int __fpclassifyf (float x);
> -extern int __fpclassifyd (double x);
> -extern int __signbitf (float x);
> -extern int __signbitd (double x);
> +extern int __isinff (float);
> +extern int __isinfd (double);
> +extern int __isnanf (float);
> +extern int __isnand (double);
> +extern int __fpclassifyf (float);
> +extern int __fpclassifyd (double);
> +extern int __signbitf (float);
> +extern int __signbitd (double);
>
> /* Note: isinf and isnan were once functions in newlib that took double
> * arguments. C99 specifies that these names are reserved for
> macros
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libc/include/math.h: Remove parameter name
2020-09-22 22:07 ` Jeff Johnston
@ 2020-09-23 9:23 ` Christophe Lyon
2020-09-26 2:54 ` Jeff Johnston
0 siblings, 1 reply; 4+ messages in thread
From: Christophe Lyon @ 2020-09-23 9:23 UTC (permalink / raw)
To: Jeff Johnston; +Cc: Newlib
[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]
On Wed, 23 Sep 2020 at 00:07, Jeff Johnston <jjohnstn@redhat.com> wrote:
>
> Hi Christophe,
>
> Can you please resend the patch as an attachment?
>
Sure, here it is.
Christohe
> Thanks,
>
> -- Jeff J.
>
> On Mon, Sep 21, 2020 at 11:29 AM Christophe Lyon via Newlib <newlib@sourceware.org> wrote:
>>
>> As discussed in GCC bug 97088
>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
>> prototypes of library functions should use reserved names, or no name
>> at all.
>>
>> This patch removes the 'x' parameter name from
>> extern int __isinff (float);
>> extern int __isinfd (double);
>> extern int __isnanf (float);
>> extern int __isnand (double);
>> extern int __fpclassifyf (float);
>> extern int __fpclassifyd (double);
>> extern int __signbitf (float);
>> extern int __signbitd (double);
>>
>> to avoid possible clashes with user code in case someone uses
>> before including Newlib's math.h (or uses some other conflicting
>> definition)
>> ---
>> newlib/libc/include/math.h | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
>> index 5e6155c..ba1a8a1 100644
>> --- a/newlib/libc/include/math.h
>> +++ b/newlib/libc/include/math.h
>> @@ -201,14 +201,14 @@ extern int isnan (double);
>> # define math_errhandling (_MATH_ERRHANDLING_ERRNO | _MATH_ERRHANDLING_ERREXCEPT)
>> #endif
>>
>> -extern int __isinff (float x);
>> -extern int __isinfd (double x);
>> -extern int __isnanf (float x);
>> -extern int __isnand (double x);
>> -extern int __fpclassifyf (float x);
>> -extern int __fpclassifyd (double x);
>> -extern int __signbitf (float x);
>> -extern int __signbitd (double x);
>> +extern int __isinff (float);
>> +extern int __isinfd (double);
>> +extern int __isnanf (float);
>> +extern int __isnand (double);
>> +extern int __fpclassifyf (float);
>> +extern int __fpclassifyd (double);
>> +extern int __signbitf (float);
>> +extern int __signbitd (double);
>>
>> /* Note: isinf and isnan were once functions in newlib that took double
>> * arguments. C99 specifies that these names are reserved for macros
>> --
>> 2.7.4
>>
[-- Attachment #2: 0001-libc-include-math.h-Remove-parameter-name.patch --]
[-- Type: text/x-patch, Size: 1941 bytes --]
From 4680acecaac6a1bd2f8da06ed3e3403e8a66ed44 Mon Sep 17 00:00:00 2001
From: Christophe Lyon <christophe.lyon@linaro.org>
Date: Mon, 21 Sep 2020 15:22:30 +0000
Subject: [PATCH] libc/include/math.h: Remove parameter name
As discussed in GCC bug 97088
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
prototypes of library functions should use reserved names, or no name
at all.
This patch removes the 'x' parameter name from
extern int __isinff (float);
extern int __isinfd (double);
extern int __isnanf (float);
extern int __isnand (double);
extern int __fpclassifyf (float);
extern int __fpclassifyd (double);
extern int __signbitf (float);
extern int __signbitd (double);
to avoid possible clashes with user code in case someone uses
before including Newlib's math.h (or uses some other conflicting
definition)
---
newlib/libc/include/math.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
index 5e6155c..ba1a8a1 100644
--- a/newlib/libc/include/math.h
+++ b/newlib/libc/include/math.h
@@ -201,14 +201,14 @@ extern int isnan (double);
# define math_errhandling (_MATH_ERRHANDLING_ERRNO | _MATH_ERRHANDLING_ERREXCEPT)
#endif
-extern int __isinff (float x);
-extern int __isinfd (double x);
-extern int __isnanf (float x);
-extern int __isnand (double x);
-extern int __fpclassifyf (float x);
-extern int __fpclassifyd (double x);
-extern int __signbitf (float x);
-extern int __signbitd (double x);
+extern int __isinff (float);
+extern int __isinfd (double);
+extern int __isnanf (float);
+extern int __isnand (double);
+extern int __fpclassifyf (float);
+extern int __fpclassifyd (double);
+extern int __signbitf (float);
+extern int __signbitd (double);
/* Note: isinf and isnan were once functions in newlib that took double
* arguments. C99 specifies that these names are reserved for macros
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libc/include/math.h: Remove parameter name
2020-09-23 9:23 ` Christophe Lyon
@ 2020-09-26 2:54 ` Jeff Johnston
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnston @ 2020-09-26 2:54 UTC (permalink / raw)
To: Christophe Lyon; +Cc: Newlib
Patch pushed to master. Thanks.
-- Jeff J
On Wed, Sep 23, 2020 at 5:23 AM Christophe Lyon <christophe.lyon@linaro.org>
wrote:
> On Wed, 23 Sep 2020 at 00:07, Jeff Johnston <jjohnstn@redhat.com> wrote:
> >
> > Hi Christophe,
> >
> > Can you please resend the patch as an attachment?
> >
>
> Sure, here it is.
>
> Christohe
>
> > Thanks,
> >
> > -- Jeff J.
> >
> > On Mon, Sep 21, 2020 at 11:29 AM Christophe Lyon via Newlib <
> newlib@sourceware.org> wrote:
> >>
> >> As discussed in GCC bug 97088
> >> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
> >> prototypes of library functions should use reserved names, or no name
> >> at all.
> >>
> >> This patch removes the 'x' parameter name from
> >> extern int __isinff (float);
> >> extern int __isinfd (double);
> >> extern int __isnanf (float);
> >> extern int __isnand (double);
> >> extern int __fpclassifyf (float);
> >> extern int __fpclassifyd (double);
> >> extern int __signbitf (float);
> >> extern int __signbitd (double);
> >>
> >> to avoid possible clashes with user code in case someone uses
> >> before including Newlib's math.h (or uses some other conflicting
> >> definition)
> >> ---
> >> newlib/libc/include/math.h | 16 ++++++++--------
> >> 1 file changed, 8 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
> >> index 5e6155c..ba1a8a1 100644
> >> --- a/newlib/libc/include/math.h
> >> +++ b/newlib/libc/include/math.h
> >> @@ -201,14 +201,14 @@ extern int isnan (double);
> >> # define math_errhandling (_MATH_ERRHANDLING_ERRNO |
> _MATH_ERRHANDLING_ERREXCEPT)
> >> #endif
> >>
> >> -extern int __isinff (float x);
> >> -extern int __isinfd (double x);
> >> -extern int __isnanf (float x);
> >> -extern int __isnand (double x);
> >> -extern int __fpclassifyf (float x);
> >> -extern int __fpclassifyd (double x);
> >> -extern int __signbitf (float x);
> >> -extern int __signbitd (double x);
> >> +extern int __isinff (float);
> >> +extern int __isinfd (double);
> >> +extern int __isnanf (float);
> >> +extern int __isnand (double);
> >> +extern int __fpclassifyf (float);
> >> +extern int __fpclassifyd (double);
> >> +extern int __signbitf (float);
> >> +extern int __signbitd (double);
> >>
> >> /* Note: isinf and isnan were once functions in newlib that took double
> >> * arguments. C99 specifies that these names are reserved for
> macros
> >> --
> >> 2.7.4
> >>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-26 2:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 15:29 [PATCH] libc/include/math.h: Remove parameter name Christophe Lyon
2020-09-22 22:07 ` Jeff Johnston
2020-09-23 9:23 ` Christophe Lyon
2020-09-26 2:54 ` Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).