From: Florian Weimer <fw@deneb.enyo.de>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Tom Tromey <tom@tromey.com>,
overseers@gcc.gnu.org, Jonathan Wakely via Gcc <gcc@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
Alexander Monakov <amonakov@ispras.ru>,
Overseers mailing list <overseers@sourceware.org>,
"Frank Ch. Eigler" <fche@elastic.org>,
"Frank Ch. Eigler" <fche@redhat.com>
Subject: Re: Not usable email content encoding
Date: Thu, 19 Mar 2020 14:58:55 +0100 [thread overview]
Message-ID: <87blosphsw.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <CAFiYyc1q6wBHOfCu2tuPj+bXCQyLfmve0iACVYZghve2GMfoaQ@mail.gmail.com> (Richard Biener's message of "Thu, 19 Mar 2020 14:41:05 +0100")
* Richard Biener:
> On Thu, Mar 19, 2020 at 2:28 PM Florian Weimer <fw@deneb.enyo.de> wrote:
>>
>> * Tom Tromey:
>>
>> > Also, gerrit was pretty bad about threading messages, so it became quite
>> > hard to follow progress in email (but following all patches in the web
>> > interface is very difficult, a problem shared by all these web UIs).
>>
>> What I found most disappointing was that the web interface doesn't
>> guide you to the next reasonable step for your reviews and patches,
>> like showing comments which need addressing. Tagging messages in an
>> email client for later action actually works better than that, I think.
>
> I guess if anything we'd want something git-centric now like github
> or gitlab pull requests & reviews. The only complication is approval
> then which would still mean manual steps.
Gitlab has a “merge if CI passes” button, I think. There are similar
third-party solutions for Github.
> Patch review would also not be publicly visible and archived(?) so
> both chiming in late after visible progress and archeology would be
> harder.
The comments could be archived on a mailing list. But there is only
some threading. Maybe this can be compensated to some extent by
producing smaller patches, so that there's less reason for
mega-review-threads.
I don't know if Gitlab supports patch reviews, or if you only can
review all the squashed changes in a merge request. Github and Gerrit
support comments on individual patches, but Pagure does not, so this
is not something that has universal support in all such tools. (I
would consider such a feature critical for glibc development.)
I haven't figured out yet under what circumstances Github links
commits to pull requests in the web UI. I'm not sure if this
relationship is available outside the web UI. (Obviously, this is
missing from the current gcc-patches feed as well.)
next prev parent reply other threads:[~2020-03-19 14:00 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 13:45 Martin Liška
2020-03-16 13:47 ` Richard Earnshaw
2020-03-16 13:52 ` Martin Liška
2020-03-16 13:51 ` Florian Weimer
2020-03-16 13:52 ` Frank Ch. Eigler
2020-03-16 13:54 ` Alexander Monakov
2020-03-16 14:11 ` Martin Liška
2020-03-16 14:18 ` Jonathan Wakely
2020-03-17 19:46 ` Segher Boessenkool
2020-03-17 19:51 ` Frank Ch. Eigler
2020-03-17 21:45 ` Segher Boessenkool
2020-03-18 10:38 ` Florian Weimer
2020-03-18 11:01 ` Frank Ch. Eigler
2020-03-18 11:39 ` Florian Weimer
2020-03-18 14:19 ` Michael Matz
2020-03-18 14:22 ` Frank Ch. Eigler
2020-03-18 15:15 ` Bernd Schmidt
2020-03-18 16:22 ` Frank Ch. Eigler
2020-03-18 16:42 ` Michael Matz
2020-03-18 17:36 ` Christopher Faylor
2020-03-18 21:52 ` Jim Wilson
2020-03-18 22:29 ` Jonathan Wakely
2020-03-18 22:34 ` Jonathan Wakely
2020-03-18 22:44 ` Frank Ch. Eigler
2020-03-19 3:30 ` Christopher Faylor
2020-03-19 3:32 ` Christopher Faylor
2020-03-18 22:45 ` Joseph Myers
2020-03-18 23:02 ` Jonathan Wakely
2020-03-19 13:05 ` Tom Tromey
2020-03-19 13:26 ` Florian Weimer
2020-03-19 13:41 ` Richard Biener
2020-03-19 13:58 ` Florian Weimer [this message]
2020-03-19 18:17 ` Segher Boessenkool
2020-04-23 0:54 ` Tamar Christina
2020-04-23 5:47 ` Florian Weimer
2020-04-23 7:34 ` Richard Biener
2020-04-23 9:55 ` Tamar Christina
[not found] ` <CAH6eHdShSXwc4K7ar9HWgHu12tDQe-s2LifdvmVp8VytwYV-ew@mail.gmail.com>
2020-04-23 8:39 ` Jakub Jelinek
2020-04-23 15:32 ` Jeff Law
2020-04-23 11:46 ` Segher Boessenkool
[not found] ` <CAH6eHdTHsZWO9vuycKm22dDbSGSfzcrKbzEpb6vNdb-zXCiKjQ@mail.gmail.com>
2020-04-23 12:30 ` Segher Boessenkool
2020-04-23 15:33 ` Jeff Law
2020-04-23 16:57 ` Frank Ch. Eigler
2020-04-23 20:32 ` Segher Boessenkool
2020-04-23 20:27 ` Segher Boessenkool
2020-04-23 21:14 ` Tom Tromey
2020-04-24 15:48 ` Thomas Koenig
2020-04-24 17:09 ` Segher Boessenkool
2020-05-01 15:51 ` Jeff Law
2020-05-02 12:50 ` Segher Boessenkool
2020-03-19 18:08 ` Segher Boessenkool
2020-03-18 22:33 ` Frank Ch. Eigler
2020-03-19 0:17 ` Segher Boessenkool
2020-03-19 0:32 ` Segher Boessenkool
2020-04-06 20:58 ` Maciej W. Rozycki
2020-04-06 21:09 ` Frank Ch. Eigler
2020-04-06 21:59 ` Maciej W. Rozycki
[not found] ` <CAH6eHdTqJEM90d9+nNWrAa_zZrQQha79oMbnbVsRt_2Zd90PdA@mail.gmail.com>
2020-04-07 9:53 ` Florian Weimer
2020-04-08 12:38 ` Mark Wielaard
2020-04-08 13:50 ` Michael Matz
2020-04-08 21:15 ` Segher Boessenkool
2020-04-13 19:47 ` Christopher Faylor
2020-04-13 22:53 ` Michael Matz
2020-04-14 21:06 ` Christopher Faylor
2020-04-14 21:38 ` Maciej W. Rozycki
2020-04-15 2:59 ` Christopher Faylor
2020-04-07 15:13 ` Michael Matz
2020-04-07 15:22 ` Frank Ch. Eigler
2020-04-07 15:56 ` Michael Matz
2020-04-07 16:09 ` Christopher Faylor
2020-04-07 17:08 ` Maciej W. Rozycki
2020-04-09 18:19 ` Florian Weimer
2020-04-07 16:08 ` Christopher Faylor
2020-04-07 16:58 ` Maciej W. Rozycki
2020-04-06 23:15 ` Segher Boessenkool
2020-03-21 22:29 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blosphsw.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=amonakov@ispras.ru \
--cc=fche@elastic.org \
--cc=fche@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=overseers@gcc.gnu.org \
--cc=overseers@sourceware.org \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).