public inbox for overseers@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Jonathan Wakely via Gcc <gcc@gcc.gnu.org>
Cc: Jim Wilson <jimw@sifive.com>,
	 Jonathan Wakely <jwakely.gcc@gmail.com>,
	overseers@gcc.gnu.org,
	 Overseers mailing list <overseers@sourceware.org>,
	 Alexander Monakov <amonakov@ispras.ru>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	 "Frank Ch. Eigler" <fche@elastic.org>,
	 "Frank Ch. Eigler" <fche@redhat.com>,
	 Florian Weimer <fw@deneb.enyo.de>
Subject: Re: Not usable email content encoding
Date: Thu, 19 Mar 2020 07:05:10 -0600	[thread overview]
Message-ID: <87zhccsdfd.fsf@tromey.com> (raw)
In-Reply-To: <CAH6eHdQe5PdRe42BFeN4e9Ms9jy5Lb2R==FxENbD1TWnefnekA@mail.gmail.com> (Jonathan Wakely via Gcc's message of "Wed, 18 Mar 2020 22:29:57 +0000")

>>>>> "Jonathan" == Jonathan Wakely via Gcc <gcc@gcc.gnu.org> writes:

[gerrit]
Jonathan> I think it also only very recently gained the ability to group a
Jonathan> series of patches together, as it wants a single commit per review.

We tried gerrit for gdb for a while, and in the end decided to drop it.

The main issue for us is that gerrit's support for patch series is poor.
In particular, it doesn't have any way to provide a cover letter (like
git send-email --compose), but in gdb we rely on these to provide an
introduction to the series -- to help justify the series overall and
orient the reviewers.

Here's the gerrit bug:

    https://bugs.chromium.org/p/gerrit/issues/detail?id=924

Based on this I think we all assumed that the situation wouldn't
improve.

Also, gerrit was pretty bad about threading messages, so it became quite
hard to follow progress in email (but following all patches in the web
interface is very difficult, a problem shared by all these web UIs).

Phabricator, IME, is even worse.  Last I used it, it had extremely bad
support for patch series, to the extent that Mozilla had to write a tool
wrapping Phabricator to make it workable.

In gdb we've also considered using an updated patchworks -- with a
gerrit-like commit hook it would be possible to automatically close
patches when they land, which is patchworks' biggest weakness.  (In gdb
land we're more concerned with tracking unreviewed patches than with
online patch review.)  However, this probably would not be a good match
for the new From munging, because it would mean extra (forgettable)
steps when trying to apply patches from the patchworks repository.

TL;DR we're doomed,
Tom

  parent reply	other threads:[~2020-03-19 13:05 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 13:45 Martin Liška
2020-03-16 13:47 ` Richard Earnshaw
2020-03-16 13:52   ` Martin Liška
2020-03-16 13:51 ` Florian Weimer
2020-03-16 13:52 ` Frank Ch. Eigler
2020-03-16 13:54 ` Alexander Monakov
2020-03-16 14:11   ` Martin Liška
2020-03-16 14:18     ` Jonathan Wakely
2020-03-17 19:46   ` Segher Boessenkool
2020-03-17 19:51     ` Frank Ch. Eigler
2020-03-17 21:45       ` Segher Boessenkool
2020-03-18 10:38       ` Florian Weimer
2020-03-18 11:01         ` Frank Ch. Eigler
2020-03-18 11:39           ` Florian Weimer
2020-03-18 14:19           ` Michael Matz
2020-03-18 14:22             ` Frank Ch. Eigler
2020-03-18 15:15               ` Bernd Schmidt
2020-03-18 16:22                 ` Frank Ch. Eigler
2020-03-18 16:42                   ` Michael Matz
2020-03-18 17:36                     ` Christopher Faylor
2020-03-18 21:52                     ` Jim Wilson
2020-03-18 22:29                       ` Jonathan Wakely
2020-03-18 22:34                         ` Jonathan Wakely
2020-03-18 22:44                           ` Frank Ch. Eigler
2020-03-19  3:30                             ` Christopher Faylor
2020-03-19  3:32                               ` Christopher Faylor
2020-03-18 22:45                         ` Joseph Myers
2020-03-18 23:02                           ` Jonathan Wakely
2020-03-19 13:05                         ` Tom Tromey [this message]
2020-03-19 13:26                           ` Florian Weimer
2020-03-19 13:41                             ` Richard Biener
2020-03-19 13:58                               ` Florian Weimer
2020-03-19 18:17                                 ` Segher Boessenkool
2020-04-23  0:54                                 ` Tamar Christina
2020-04-23  5:47                                   ` Florian Weimer
2020-04-23  7:34                                     ` Richard Biener
2020-04-23  9:55                                     ` Tamar Christina
     [not found]                                     ` <CAH6eHdShSXwc4K7ar9HWgHu12tDQe-s2LifdvmVp8VytwYV-ew@mail.gmail.com>
2020-04-23  8:39                                       ` Jakub Jelinek
2020-04-23 15:32                                       ` Jeff Law
2020-04-23 11:46                                   ` Segher Boessenkool
     [not found]                                     ` <CAH6eHdTHsZWO9vuycKm22dDbSGSfzcrKbzEpb6vNdb-zXCiKjQ@mail.gmail.com>
2020-04-23 12:30                                       ` Segher Boessenkool
2020-04-23 15:33                                     ` Jeff Law
2020-04-23 16:57                                       ` Frank Ch. Eigler
2020-04-23 20:32                                         ` Segher Boessenkool
2020-04-23 20:27                                       ` Segher Boessenkool
2020-04-23 21:14                                         ` Tom Tromey
2020-04-24 15:48                                           ` Thomas Koenig
2020-04-24 17:09                                             ` Segher Boessenkool
2020-05-01 15:51                                           ` Jeff Law
2020-05-02 12:50                                             ` Segher Boessenkool
2020-03-19 18:08                               ` Segher Boessenkool
2020-03-18 22:33                       ` Frank Ch. Eigler
2020-03-19  0:17                         ` Segher Boessenkool
2020-03-19  0:32                       ` Segher Boessenkool
2020-04-06 20:58                   ` Maciej W. Rozycki
2020-04-06 21:09                     ` Frank Ch. Eigler
2020-04-06 21:59                       ` Maciej W. Rozycki
     [not found]                         ` <CAH6eHdTqJEM90d9+nNWrAa_zZrQQha79oMbnbVsRt_2Zd90PdA@mail.gmail.com>
2020-04-07  9:53                           ` Florian Weimer
2020-04-08 12:38                             ` Mark Wielaard
2020-04-08 13:50                               ` Michael Matz
2020-04-08 21:15                                 ` Segher Boessenkool
2020-04-13 19:47                                   ` Christopher Faylor
2020-04-13 22:53                                     ` Michael Matz
2020-04-14 21:06                                       ` Christopher Faylor
2020-04-14 21:38                                         ` Maciej W. Rozycki
2020-04-15  2:59                                           ` Christopher Faylor
2020-04-07 15:13                           ` Michael Matz
2020-04-07 15:22                             ` Frank Ch. Eigler
2020-04-07 15:56                               ` Michael Matz
2020-04-07 16:09                                 ` Christopher Faylor
2020-04-07 17:08                                   ` Maciej W. Rozycki
2020-04-09 18:19                                     ` Florian Weimer
2020-04-07 16:08                             ` Christopher Faylor
2020-04-07 16:58                               ` Maciej W. Rozycki
2020-04-06 23:15                     ` Segher Boessenkool
2020-03-21 22:29     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhccsdfd.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=amonakov@ispras.ru \
    --cc=fche@elastic.org \
    --cc=fche@redhat.com \
    --cc=fw@deneb.enyo.de \
    --cc=gcc@gcc.gnu.org \
    --cc=jimw@sifive.com \
    --cc=jwakely.gcc@gmail.com \
    --cc=overseers@gcc.gnu.org \
    --cc=overseers@sourceware.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).