public inbox for overseers@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: overseers@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
	Joseph Myers <joseph@codesourcery.com>,
	Carlos O'Donell <carlos@systemhalted.org>,
	Corinna Vinschen <vinschen@redhat.com>,
	Ivo Raisr <ivosh@ivosh.net>
Subject: Re: transition git-hooks on sourceware.org to Python 3.x
Date: Sun, 19 Dec 2021 08:45:39 +0400	[thread overview]
Message-ID: <Yb648+Etld0X1+sm@adacore.com> (raw)
In-Reply-To: <Ybv6GmaM/UKstg1j@adacore.com>

Quick update:

I have set up the hooks wrappers at the following location:

    /home/gdbadmin/shared-scripts/git-hooks-wrapper

For the record, here is the list of commands I used to create it:

    # Clone the git-hooks-wrapper scrips

      $ mkdir shared-scripts
      $ cd shared-scripts/
      $ git clone $HOME/GDBADMIN-BARE-REPOS/git-hooks-wrapper/
      $ cd git-hooks-wrapper/

    # Add a Python 3.9 install, and then the venv for the wrappers:

      $ tar xf ~/brobecke/py3-git-hooks/python3.9-3.9.7-x86_64-linux-bin.tar.gz
      $ mv python3.9-3.9.7-x86_64-linux-bin/ python-3.9.7
      $ export PATH=`pwd`/python-3.9.7/bin:$PATH
      $ python3 -m venv python3-for-git-hooks
      $ . ./python3-for-git-hooks/bin/activate
      $ python3 -m pip install pip --upgrade
      $ python3 -m pip install black e3-core flake8 pre-commit \
          pytest pytest-cov pytest-xdist

    # Clone the git-hooks, and run the validation test to make sure
    # the Python venv has everything the git-hooks need (note that
    # this doesn't include the wrappers in the testing, unfortunately).
    #
    # I might look at enhancing the testsuite to include the use of
    # those wrappers instead of the hooks themselves, at some point,
    # but it's a bit of work, so only if we find the regular need to
    # test the wrappers.

      $ git clone https://github.com/adacore/git-hooks
      $ cd git-hooks/testsuite/
      $ ./run-validation-tests

My plan is to transition the binutils-gdb repository to it on Monday
morning (European timezone). To do so, what I will do is:

    $ /git/binutils-gdb.git
    $ mv hooks{,.legacy-python2} \
       && ln -s /home/gdbadmin/shared-scripts/git-hooks-wrapper/hooks hooks

I'll monitor the hooks behavior throughout the end of the year,
and if all goes well, I suggest other projects who are ready
(after reviewing their python scripts used by their project's config)
do the same. I can provide assistance towards the transition,
if you'd like.

-- 
Joel

  reply	other threads:[~2021-12-19  4:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-12 11:32 Joel Brobecker
2021-12-13  9:23 ` Mark Wielaard
2021-12-15  9:30   ` Ivo Raisr
2021-12-16  2:16     ` Joel Brobecker
2021-12-13 11:35 ` Corinna Vinschen
2021-12-13 11:47   ` Joel Brobecker
2021-12-13 22:20 ` Joseph Myers
2021-12-14  3:39   ` Joel Brobecker
2021-12-17  2:46 ` Joel Brobecker
2021-12-19  4:45   ` Joel Brobecker [this message]
2021-12-20  5:10     ` Joel Brobecker
2022-01-16 10:06     ` Joel Brobecker
2022-01-17 10:02       ` Corinna Vinschen
2022-01-20  5:27         ` Joel Brobecker
2022-01-20 10:04           ` Corinna Vinschen
2022-01-20 13:54             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yb648+Etld0X1+sm@adacore.com \
    --to=brobecker@adacore.com \
    --cc=carlos@systemhalted.org \
    --cc=ivosh@ivosh.net \
    --cc=joseph@codesourcery.com \
    --cc=overseers@sourceware.org \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).