Re: transition git-hooks on sourceware.org to Python 3.x

[Joel Brobecker <brobecker@adacore.com>]

Hi everyone,

Happy New Year!

For binutils-gdb, the transition has been made a few weeks ago,
and so far so good :). So I'm inviting you all to transition
this new version at your convenience.

Remember that, if your project's configuration calls some Python
hooks, you'll probably want to double-check that they are compatible
with Python 3.x!

Cheers :)

On Sun, Dec 19, 2021 at 08:45:39AM +0400, Joel Brobecker wrote:
> Quick update:
> 
> I have set up the hooks wrappers at the following location:
> 
>     /home/gdbadmin/shared-scripts/git-hooks-wrapper
> 
> For the record, here is the list of commands I used to create it:
> 
>     # Clone the git-hooks-wrapper scrips
> 
>       $ mkdir shared-scripts
>       $ cd shared-scripts/
>       $ git clone $HOME/GDBADMIN-BARE-REPOS/git-hooks-wrapper/
>       $ cd git-hooks-wrapper/
> 
>     # Add a Python 3.9 install, and then the venv for the wrappers:
> 
>       $ tar xf ~/brobecke/py3-git-hooks/python3.9-3.9.7-x86_64-linux-bin.tar.gz
>       $ mv python3.9-3.9.7-x86_64-linux-bin/ python-3.9.7
>       $ export PATH=`pwd`/python-3.9.7/bin:$PATH
>       $ python3 -m venv python3-for-git-hooks
>       $ . ./python3-for-git-hooks/bin/activate
>       $ python3 -m pip install pip --upgrade
>       $ python3 -m pip install black e3-core flake8 pre-commit \
>           pytest pytest-cov pytest-xdist
> 
>     # Clone the git-hooks, and run the validation test to make sure
>     # the Python venv has everything the git-hooks need (note that
>     # this doesn't include the wrappers in the testing, unfortunately).
>     #
>     # I might look at enhancing the testsuite to include the use of
>     # those wrappers instead of the hooks themselves, at some point,
>     # but it's a bit of work, so only if we find the regular need to
>     # test the wrappers.
> 
>       $ git clone https://github.com/adacore/git-hooks
>       $ cd git-hooks/testsuite/
>       $ ./run-validation-tests
> 
> My plan is to transition the binutils-gdb repository to it on Monday
> morning (European timezone). To do so, what I will do is:
> 
>     $ /git/binutils-gdb.git
>     $ mv hooks{,.legacy-python2} \
>        && ln -s /home/gdbadmin/shared-scripts/git-hooks-wrapper/hooks hooks
> 
> I'll monitor the hooks behavior throughout the end of the year,
> and if all goes well, I suggest other projects who are ready
> (after reviewing their python scripts used by their project's config)
> do the same. I can provide assistance towards the transition,
> if you'd like.
> 
> -- 
> Joel

-- 
Joel