From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: ptrace improvement: PTRACE_O_INHERIT
Date: Sat, 12 Feb 2011 19:11:00 -0000 [thread overview]
Message-ID: <20110212190253.GA31866@redhat.com> (raw)
In-Reply-To: <20110212005855.E764C1814A4@magilla.sf.frob.com>
On 02/11, Roland McGrath wrote:
>
> > > > Or. Suppose that clone() under PTRACE_O_INHERIT notifies the tracer
> > > > (sends SIGCHLD), and the new tracee gets the new PTRACE_O_INHERITed
> > > > mark. Then we can implement wait(W_WHO_WAS_CLONNED) which clears
> > > > PTRACE_O_INHERITed and reports the new tracee (just in case, this
> > > > doesn't need the stopped tracee).
> > >
> > > I don't really follow this idea at all, sorry.
> >
> > I meant, we can intoduce the new W*** flag for do_wait(). If the new
> > tracee was PTRACE_O_INHERIT'ed, do_wait() returns its pid.
>
> I still don't understand the proposal.
To simplify the explanation, suppose we add task_struct->unknown_tracee
boolean.
if tracehook_finish_clone()->ptrace_init_task() does __ptrace_link()
because of PTRACE_O_INHERIT, it also sets child->unknown_tracee and
notifies the tracee via do_notify_parent_cldstop().
Then we add WCLONNED and modify wait_consider_task(),
- if (likely(!ptrace) && unlikely(task_ptrace(p))) {
- /*
- * This child is hidden by ptrace.
- * We aren't allowed to see it now, but eventually we will.
- */
- wo->notask_error = 0;
- return 0;
- }
+ if (unlikely(ptrace) {
+ if (unlikely(p->unknown_tracee) && (wo->wo_flags & WCLONNED)) {
+ // of course, this is racy
+ p->unknown_tracee = 0;
+
+ // we need wait_task_ptrace_inherited(wo, p);
+ read_unlock(&tasklist_lock);
+ return p->pid;
+ }
+
+ } else if (unlikely(task_ptrace(p))) {
+ /*
+ * This child is hidden by ptrace.
+ * We aren't allowed to see it now, but eventually we will.
+ */
+ wo->notask_error = 0;
+ return 0;
+ }
Of course this is just incomplete pseudo-code to explain what I mean.
> > Well yes, but /proc/PID/task/ is not convenient and reliable.
> > Especially if we do not trace all threads.
>
> Tracing some threads but not all is really an artifact of the ptrace
> interface and not something that any real userland debugger-like thing
> ever wants to do.
Off-topic note: I disagree very much, but this doesn't matter. I agree
that ptrace nterface should not be per-thread, and gdb always traces all
threads.
> But, again, we want to see what GDB really wants to use and only add that.
Yes, yes, agreed.
Oleg.
next prev parent reply other threads:[~2011-02-12 19:11 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 22:39 ptrace improvement ideas Roland McGrath
2011-02-04 18:56 ` Oleg Nesterov
2011-02-04 18:58 ` Roland McGrath
2011-02-07 21:11 ` Jan Kratochvil
2011-02-08 1:58 ` Roland McGrath
2011-02-08 20:41 ` Jan Kratochvil
2011-02-09 2:48 ` Roland McGrath
2011-02-08 21:07 ` Oleg Nesterov
2011-02-08 23:18 ` hw_breakpoint userland interface Roland McGrath
2011-02-10 21:03 ` Oleg Nesterov
2011-02-10 21:14 ` Roland McGrath
2011-02-11 20:17 ` Oleg Nesterov
2011-02-10 20:00 ` ptrace improvement: PTRACE_O_INHERIT Oleg Nesterov
2011-02-11 19:24 ` Roland McGrath
2011-02-11 20:46 ` Oleg Nesterov
2011-02-12 0:59 ` Roland McGrath
2011-02-12 19:11 ` Oleg Nesterov [this message]
2011-02-14 19:31 ` Roland McGrath
2011-02-14 19:46 ` Oleg Nesterov
2011-02-15 0:36 ` Roland McGrath
2011-02-15 13:16 ` Oleg Nesterov
2011-02-15 21:43 ` Jan Kratochvil
2011-02-15 21:56 ` Roland McGrath
2011-02-16 19:42 ` Oleg Nesterov
2011-02-16 19:45 ` Roland McGrath
2011-02-16 20:09 ` Oleg Nesterov
2011-02-16 20:16 ` Roland McGrath
2011-02-19 19:48 ` Jan Kratochvil
2011-02-19 20:37 ` Oleg Nesterov
2011-02-20 8:18 ` Jan Kratochvil
2011-02-20 21:05 ` Oleg Nesterov
2011-02-21 19:54 ` Roland McGrath
2011-02-22 19:39 ` Oleg Nesterov
2011-02-22 20:49 ` Roland McGrath
2011-02-22 21:10 ` Oleg Nesterov
2011-02-22 22:16 ` Roland McGrath
2011-02-21 19:44 ` Roland McGrath
2011-02-15 22:02 ` Roland McGrath
2011-02-16 16:02 ` Jan Kratochvil
2011-02-16 18:28 ` Roland McGrath
2011-02-16 20:00 ` Oleg Nesterov
2011-02-16 20:07 ` Roland McGrath
2011-02-16 20:32 ` Oleg Nesterov
2011-02-16 19:48 ` Oleg Nesterov
2011-02-16 20:02 ` Roland McGrath
2011-02-16 20:15 ` Oleg Nesterov
2011-02-16 20:31 ` Roland McGrath
2011-02-16 21:04 ` Oleg Nesterov
2011-02-16 21:51 ` Roland McGrath
2011-02-16 19:38 ` Oleg Nesterov
2011-02-16 19:40 ` Roland McGrath
2011-02-15 22:17 ` Roland McGrath
2011-02-16 20:48 ` Oleg Nesterov
2011-02-16 11:31 ` ptrace improvement ideas (QPassSignals) Jan Kratochvil
2011-02-16 18:36 ` Roland McGrath
2011-02-16 20:21 ` Oleg Nesterov
2011-02-18 20:24 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212190253.GA31866@redhat.com \
--to=oleg@redhat.com \
--cc=archer@sourceware.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).