From: "Jiang, Haochen" <haochen.jiang@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "Zhang, Jun" <jun.zhang@intel.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH v2] Support Intel FRED LKGS
Date: Wed, 24 May 2023 06:36:15 +0000 [thread overview]
Message-ID: <SA1PR11MB5946C64D2291F72078CEDDD3EC419@SA1PR11MB5946.namprd11.prod.outlook.com> (raw)
In-Reply-To: <6ed7cdcd-c7e5-587b-9d4b-95c1cc18f703@suse.com>
> Well, there are two ways of approaching this, but imo in either case via
> a prereq change to the other insns that use this operand descriptor in a
> questionable manner. We could split decode at the ModR/M.mod level, but
> perhaps better is to follow MOV to/from sreg, SLDT, and STR in using a D
> suffix and an Sv operand.
I suppose the latter is better since Sv will go back to OP_E then split decode
ad ModR/M.mod level.
I will go through that to make the change.
Thx,
Haochen
>
> If, however, you're not happy about making the prereq change first, I'd
> be kind of okay with the change being committed as is, and I'd then try
> to remember to follow up accordingly. One minor adjustment request,
> though: In the opcode table comments, can you please use singular for
> LKGS (while plural is fine for FRED)?
>
> Jan
next prev parent reply other threads:[~2023-05-24 6:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 6:07 Zhang, Jun
2023-05-22 9:11 ` Jan Beulich
2023-05-24 6:36 ` Jiang, Haochen [this message]
2023-05-25 7:57 ` Jiang, Haochen
2023-05-25 8:42 ` Jan Beulich
2023-05-26 6:50 ` Jiang, Haochen
2023-05-26 7:00 ` Jan Beulich
2023-05-26 8:26 ` [PATCH] x86: Add Evw to emit w suffix for several instrctions for word ptr Haochen Jiang
2023-05-26 8:46 ` Jan Beulich
2023-05-26 8:54 ` Jiang, Haochen
2023-05-26 10:52 ` Jan Beulich
2023-05-29 2:01 ` Jiang, Haochen
2023-05-29 2:08 ` Jiang, Haochen
2023-05-30 8:09 ` Jan Beulich
2023-05-31 5:48 ` Jiang, Haochen
2023-05-31 8:43 ` Jan Beulich
2023-06-01 2:14 ` H.J. Lu
-- strict thread matches above, loose matches on Subject: below --
2023-05-22 6:00 [PATCH v2] Support Intel FRED LKGS Zhang, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR11MB5946C64D2291F72078CEDDD3EC419@SA1PR11MB5946.namprd11.prod.outlook.com \
--to=haochen.jiang@intel.com \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=jun.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).