From: Jan Beulich <jbeulich@suse.com>
To: "Jiang, Haochen" <haochen.jiang@intel.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"Zhang, Jun" <jun.zhang@intel.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH] x86: Add Evw to emit w suffix for several instrctions for word ptr
Date: Fri, 26 May 2023 12:52:15 +0200 [thread overview]
Message-ID: <37736f27-73d5-6564-e27e-5e7cd5bf27da@suse.com> (raw)
In-Reply-To: <SA1PR11MB59463513831F4204EFC42748EC479@SA1PR11MB5946.namprd11.prod.outlook.com>
On 26.05.2023 10:54, Jiang, Haochen wrote:
>> On 26.05.2023 10:26, Haochen Jiang wrote:
>>> Currently, for instructions lldt/ltr/verr/verw/lkgs, we are missing w
>>> suffix for memory operands like sldt/str do. Also the Ew usage is not
>>> that precise under this scenario. Add Evw to fix this problem.
>>
>> So why not Sv? It's used solely for segment register moves, sldt, str, and
>> smsw right now. We're aiming for consistency among all insns loading /
>> storing segment selector values (and smsw fits that pattern, but note that
>> lmsw does not), so introducing a new Evw can't be the solution (or else Sv
>> users would also need switching).
>
> There is a little difference between lldt/ltr/lkgs/verr/verw and sldt/str. We need
> to fix the register to 16 bit while sldt/str did not. That is why I am not using Sv. Sv
> will emit 'lldt %eax' but not 'lldt %ax' for current testcases and I suppose that is not
> desired.
Did you read my reply on one of the "Support Intel FRED LKGS" threads,
which I think I sent before this patch was sent? I do not follow why
you think "we need to fix the register to 16 bit".
Jan
next prev parent reply other threads:[~2023-05-26 10:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 6:07 [PATCH v2] Support Intel FRED LKGS Zhang, Jun
2023-05-22 9:11 ` Jan Beulich
2023-05-24 6:36 ` Jiang, Haochen
2023-05-25 7:57 ` Jiang, Haochen
2023-05-25 8:42 ` Jan Beulich
2023-05-26 6:50 ` Jiang, Haochen
2023-05-26 7:00 ` Jan Beulich
2023-05-26 8:26 ` [PATCH] x86: Add Evw to emit w suffix for several instrctions for word ptr Haochen Jiang
2023-05-26 8:46 ` Jan Beulich
2023-05-26 8:54 ` Jiang, Haochen
2023-05-26 10:52 ` Jan Beulich [this message]
2023-05-29 2:01 ` Jiang, Haochen
2023-05-29 2:08 ` Jiang, Haochen
2023-05-30 8:09 ` Jan Beulich
2023-05-31 5:48 ` Jiang, Haochen
2023-05-31 8:43 ` Jan Beulich
2023-06-01 2:14 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37736f27-73d5-6564-e27e-5e7cd5bf27da@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=haochen.jiang@intel.com \
--cc=hjl.tools@gmail.com \
--cc=jun.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).