From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Corinna Vinschen <corinna-cygwin@cygwin.com>
Cc: cygwin-patches@cygwin.com
Subject: Re: [PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined
Date: Mon, 3 Apr 2023 08:45:32 +0200 (CEST) [thread overview]
Message-ID: <97e5226e-60c6-9d03-0c71-72e3192abe59@gmx.de> (raw)
In-Reply-To: <ZCK+v7yBxRBft3UK@calimero.vinschen.de>
Hi Corinna,
On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> On Mar 28 10:17, Johannes Schindelin wrote:
> > In particular when we cannot figure out a uid for the current user, we
> > should still respect the `db_home: env` setting. Such a situation occurs
> > for example when the domain returned by `LookupAccountSid()` is not our
> > machine name and at the same time our machine is no domain member: In
> > that case, we have nobody to ask for the POSIX offset necessary to come
> > up with the uid.
> >
> > It is important that even in such cases, the `HOME` environment variable
> > can be used to override the home directory, e.g. when Git for Windows is
> > used by an account that was generated on the fly, e.g. for transient use
> > in a cloud scenario.
>
> How does this kind of account look like? I'd like to see the contants
> of name, domain, and the SID. Isn't that just an account closely
> resembling Micorosft Accounts or AzureAD accounts? Can't we somehow
> handle them alike?
It took a good while to remind me what was going on there. Essentially, I
had to dig up a mail from 2016 that David Ebbo sent me via my work email
(because he was working on Kudu, the Azure shell, where this issue arose).
Sadly, David is no longer a colleague of mine (he seems to work at Google
now), so I cannot pester him about details. Besides, it might be too long
ago to remember details, anyways.
What I _can_ do is try to recreate the problem (the report said that this
happens in a Kudu console of an Azure Web App, see
https://github.com/projectkudu/kudu/wiki/Kudu-console) by creating a new
Azure Web App and opening that console and run Cygwin within it, which is
what I am going to do now.
> > Reported by David Ebbo.
>
> This should be
>
> Reported-By: David Ebbo <email address>
Will fix. Naturally, it won't be his Microsoft email address any longer,
but the recent patches I obtained from repositories at
https://github.com/davidebbo/ have a GMail address on record.
> > diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
> > index d493d29b3b..b01bcff5cb 100644
> > --- a/winsup/cygwin/uinfo.cc
> > +++ b/winsup/cygwin/uinfo.cc
> > @@ -883,6 +883,8 @@ fetch_from_path (cyg_ldap *pldap, PUSER_INFO_3 ui, cygpsid &sid, PCWSTR str,
> > case L'u':
> > if (full_qualified)
> > {
> > + if (!dom)
> > + break;
>
> No domain? Really?
Yes, I distinctly remember that I had to do that, otherwise the code would
not work as intended.
Ciao,
Johannes
next prev parent reply other threads:[~2023-04-03 6:45 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:06 [PATCH] Allow overriding the home directory via the HOME variable Johannes Schindelin
2015-10-21 18:32 ` Corinna Vinschen
2015-10-22 15:38 ` Johannes Schindelin
2015-10-23 9:10 ` Corinna Vinschen
2015-10-23 9:41 ` Corinna Vinschen
2015-10-23 12:00 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 0/2] Support deriving the current user's home directory via HOME Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2015-12-17 20:20 ` Corinna Vinschen
2022-09-21 11:58 ` Johannes Schindelin
2022-10-18 17:02 ` Corinna Vinschen
2022-10-23 21:04 ` Johannes Schindelin
2022-10-24 11:37 ` Corinna Vinschen
2022-11-10 15:16 ` Johannes Schindelin
2022-11-10 15:22 ` Corinna Vinschen
2022-11-18 8:18 ` Johannes Schindelin
2022-11-21 11:41 ` Corinna Vinschen
2023-03-28 8:21 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 2/2] Respect `db_home` setting even for the SYSTEM account Johannes Schindelin
2015-12-17 20:49 ` Corinna Vinschen
2015-12-17 21:02 ` Corinna Vinschen
2022-09-21 12:00 ` Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-03-28 10:35 ` Corinna Vinschen
2023-03-28 12:34 ` Jon Turney
2023-03-28 13:31 ` Corinna Vinschen
2023-03-29 8:36 ` Corinna Vinschen
2023-04-03 6:39 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-03-28 10:16 ` Corinna Vinschen
2023-04-03 6:36 ` Johannes Schindelin
2023-04-03 10:59 ` Corinna Vinschen
2023-04-03 13:32 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 10:17 ` Corinna Vinschen
2023-04-03 6:45 ` Johannes Schindelin [this message]
2023-04-03 13:12 ` Johannes Schindelin
2023-04-03 13:29 ` Corinna Vinschen
2023-04-03 13:57 ` Johannes Schindelin
2023-04-03 19:23 ` Corinna Vinschen
2023-04-04 15:11 ` Johannes Schindelin
2023-04-03 13:19 ` Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-03 18:36 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-03 18:37 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-04-06 8:37 ` Corinna Vinschen
2023-04-06 9:54 ` Johannes Schindelin
2023-04-06 10:28 ` Corinna Vinschen
2023-05-22 11:12 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-05-22 11:13 ` [PATCH v7 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-06-06 13:33 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e5226e-60c6-9d03-0c71-72e3192abe59@gmx.de \
--to=johannes.schindelin@gmx.de \
--cc=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).