From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH v6 4/4] Do not rely on `getenv ("HOME")`'s path conversion
Date: Thu, 6 Apr 2023 12:28:35 +0200 [thread overview]
Message-ID: <ZC6e00dkKQeOgpNh@calimero.vinschen.de> (raw)
In-Reply-To: <097f16c8-9df1-4dad-6eb4-30fe090c9f05@gmx.de>
On Apr 6 11:54, Johannes Schindelin wrote:
> On Thu, 6 Apr 2023, Corinna Vinschen wrote:
> > While the description is clear on the colon problem, shouldn't this
> > catch UNC paths as well? I. e., just check for strchr(home, '\\')?
>
> Good idea! I do not know off-hand how well things work when `HOME` is an
> UNC path, but we can fix those things when (and if) they arrive.
>
> I'll use `isdrive (home) || home[0] == '\\'` as is used elsewhere, okay?
I was thinking of simplifying this to the strchr test for backslash
because all paths with a backslash are handled as Windows paths.
Without actually checking the source, I'd guess the above is checking
for an absolute path in the first place. Hopefully everybody is
aware that HOME should be a full path... :)
But yes, your above expression is ok, too.
Corinna
next prev parent reply other threads:[~2023-04-06 10:28 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:06 [PATCH] Allow overriding the home directory via the HOME variable Johannes Schindelin
2015-10-21 18:32 ` Corinna Vinschen
2015-10-22 15:38 ` Johannes Schindelin
2015-10-23 9:10 ` Corinna Vinschen
2015-10-23 9:41 ` Corinna Vinschen
2015-10-23 12:00 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 0/2] Support deriving the current user's home directory via HOME Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 2/2] Respect `db_home` setting even for the SYSTEM account Johannes Schindelin
2015-12-17 20:49 ` Corinna Vinschen
2015-12-17 21:02 ` Corinna Vinschen
2022-09-21 12:00 ` Johannes Schindelin
2015-12-17 18:05 ` [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2015-12-17 20:20 ` Corinna Vinschen
2022-09-21 11:58 ` Johannes Schindelin
2022-10-18 17:02 ` Corinna Vinschen
2022-10-23 21:04 ` Johannes Schindelin
2022-10-24 11:37 ` Corinna Vinschen
2022-11-10 15:16 ` Johannes Schindelin
2022-11-10 15:22 ` Corinna Vinschen
2022-11-18 8:18 ` Johannes Schindelin
2022-11-21 11:41 ` Corinna Vinschen
2023-03-28 8:21 ` Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2022-09-21 11:51 ` [PATCH v3 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2022-09-21 11:52 ` [PATCH v3 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-03-28 10:35 ` Corinna Vinschen
2023-03-28 12:34 ` Jon Turney
2023-03-28 13:31 ` Corinna Vinschen
2023-03-29 8:36 ` Corinna Vinschen
2023-04-03 6:39 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-03-28 10:16 ` Corinna Vinschen
2023-04-03 6:36 ` Johannes Schindelin
2023-04-03 10:59 ` Corinna Vinschen
2023-04-03 13:32 ` Johannes Schindelin
2023-03-28 8:17 ` [PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-03-28 10:17 ` Corinna Vinschen
2023-04-03 6:45 ` Johannes Schindelin
2023-04-03 13:12 ` Johannes Schindelin
2023-04-03 13:29 ` Corinna Vinschen
2023-04-03 13:57 ` Johannes Schindelin
2023-04-03 19:23 ` Corinna Vinschen
2023-04-04 15:11 ` Johannes Schindelin
2023-04-03 13:19 ` Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 0/3] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-03 14:44 ` [PATCH v5 1/3] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-03 18:36 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-03 18:37 ` Corinna Vinschen
2023-04-04 15:12 ` Johannes Schindelin
2023-04-03 14:45 ` [PATCH v5 3/3] Respect `db_home: env` even when no uid can be determined Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-04-04 15:07 ` [PATCH v6 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-04-06 8:37 ` Corinna Vinschen
2023-04-06 9:54 ` Johannes Schindelin
2023-04-06 10:28 ` Corinna Vinschen [this message]
2023-05-22 11:12 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 1/4] Allow deriving the current user's home directory via the HOME variable Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 2/4] Respect `db_home` setting even for SYSTEM/Microsoft accounts Johannes Schindelin
2023-05-22 11:12 ` [PATCH v7 3/4] uinfo: special-case IIS APPPOOL accounts Johannes Schindelin
2023-05-22 11:13 ` [PATCH v7 4/4] Do not rely on `getenv ("HOME")`'s path conversion Johannes Schindelin
2023-06-06 13:33 ` [PATCH v7 0/4] Support deriving the current user's home directory via HOME Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC6e00dkKQeOgpNh@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).