[PATCH] RISC-V: Remove unit-stride store from ta attribute

[PATCH] RISC-V: Remove unit-stride store from ta attribute

[juzhe.zhong]

From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>

Since store instructions doesn't care about tail policy, we remove 
vste from "ta" attribute. Hence, we could have more fusion chances
and better optimization.

gcc/ChangeLog:

        * config/riscv/vector.md: Remove vste.

---
 gcc/config/riscv/vector.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/riscv/vector.md b/gcc/config/riscv/vector.md
index 7dfadaa96b6..84adbb9974a 100644
--- a/gcc/config/riscv/vector.md
+++ b/gcc/config/riscv/vector.md
@@ -221,7 +221,7 @@
 
 ;; The tail policy op value.
 (define_attr "ta" ""
-  (cond [(eq_attr "type" "vlde,vste,vimov,vfmov,vlds")
+  (cond [(eq_attr "type" "vlde,vimov,vfmov,vlds")
 	   (symbol_ref "riscv_vector::get_ta(operands[5])")]
 	(const_int INVALID_ATTRIBUTE)))
 
-- 
2.36.3

Re: [PATCH] RISC-V: Remove unit-stride store from ta attribute

[Jeff Law]

On 12/14/22 04:36, juzhe.zhong@rivai.ai wrote:
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
> 
> Since store instructions doesn't care about tail policy, we remove
> vste from "ta" attribute. Hence, we could have more fusion chances
> and better optimization.
> 
> gcc/ChangeLog:
> 
>          * config/riscv/vector.md: Remove vste.
Just to confirm that I understand the basic model.  Vector stores only 
update active elements, thus they don't care about tail policy, right?

Assuming that's the case, then this is OK.

jeff

Re: [PATCH] RISC-V: Remove unit-stride store from ta attribute

[Palmer Dabbelt]

On Fri, 16 Dec 2022 12:01:04 PST (-0800), jeffreyalaw@gmail.com wrote:
>
>
> On 12/14/22 04:36, juzhe.zhong@rivai.ai wrote:
>> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>>
>> Since store instructions doesn't care about tail policy, we remove
>> vste from "ta" attribute. Hence, we could have more fusion chances
>> and better optimization.
>>
>> gcc/ChangeLog:
>>
>>          * config/riscv/vector.md: Remove vste.
> Just to confirm that I understand the basic model.  Vector stores only
> update active elements, thus they don't care about tail policy, right?
>
> Assuming that's the case, then this is OK.

That had been my assumption as well, but I don't see that explicitly 
called out in the ISA manual.  I see

   Masked vector stores only update active memory elements.

where "active" is defined as

    * The _body_ elements are those whose element index is greater than or equal
    to the initial value in the `vstart` register, and less than the current
    vector length setting in `vl`. The body can be split into two disjoint subsets:

    ** The _active_ elements during a vector instruction's execution are the
    elements within the body and where the current mask is enabled at that element
    position.  The active elements can raise exceptions and update the destination
    vector register group.

but I don't see anything about the unmasked stores.  The blurb about 
tail elements only applies to registers groups, not memory addresses, so 
I think that's kind of a grey area there too.  I was pretty sure the intent
here was to have tail elements not updated in memory, so hopefully I'm just
missing something in the spec.

I open an issue to check: https://github.com/riscv/riscv-v-spec/issues/846

Re: [PATCH] RISC-V: Remove unit-stride store from ta attribute

[Andrew Waterman]

On Fri, Dec 16, 2022 at 1:59 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Fri, 16 Dec 2022 12:01:04 PST (-0800), jeffreyalaw@gmail.com wrote:
> >
> >
> > On 12/14/22 04:36, juzhe.zhong@rivai.ai wrote:
> >> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
> >>
> >> Since store instructions doesn't care about tail policy, we remove
> >> vste from "ta" attribute. Hence, we could have more fusion chances
> >> and better optimization.
> >>
> >> gcc/ChangeLog:
> >>
> >>          * config/riscv/vector.md: Remove vste.
> > Just to confirm that I understand the basic model.  Vector stores only
> > update active elements, thus they don't care about tail policy, right?
> >
> > Assuming that's the case, then this is OK.
>
> That had been my assumption as well, but I don't see that explicitly
> called out in the ISA manual.  I see
>
>    Masked vector stores only update active memory elements.
>
> where "active" is defined as
>
>     * The _body_ elements are those whose element index is greater than or equal
>     to the initial value in the `vstart` register, and less than the current
>     vector length setting in `vl`. The body can be split into two disjoint subsets:
>
>     ** The _active_ elements during a vector instruction's execution are the
>     elements within the body and where the current mask is enabled at that element
>     position.  The active elements can raise exceptions and update the destination
>     vector register group.
>
> but I don't see anything about the unmasked stores.  The blurb about
> tail elements only applies to registers groups, not memory addresses, so
> I think that's kind of a grey area there too.  I was pretty sure the intent
> here was to have tail elements not updated in memory, so hopefully I'm just
> missing something in the spec.

As discussed on the github issue, I think there is sufficient
justification in the spec to say that vector stores are forbidden from
accessing tail elements even if unmasked.  (And of course the ISA
would be pretty useless if that weren't the case...) But there's no
reason not to clarify the language in the spec, so as to make it
easier for readers to grok.

>
> I open an issue to check: https://github.com/riscv/riscv-v-spec/issues/846

Re: Re: [PATCH] RISC-V: Remove unit-stride store from ta attribute

[钟居哲]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

Yes, the vector stores doesn't care about policy no matter mask or tail.
Removing it can allow VSETVL PASS have more optimization chances
since VSETVL PASS has backward demands fusion.

For example:
vadd tama
vse.v
VSETVL PASS will choose to set tama for vse.v

vadd tumu
vse.v
VSETVL PASS will choose to set tumu for vse.v



juzhe.zhong@rivai.ai
 
From: Jeff Law
Date: 2022-12-17 04:01
To: juzhe.zhong; gcc-patches
CC: kito.cheng; palmer
Subject: Re: [PATCH] RISC-V: Remove unit-stride store from ta attribute
 
 
On 12/14/22 04:36, juzhe.zhong@rivai.ai wrote:
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
> 
> Since store instructions doesn't care about tail policy, we remove
> vste from "ta" attribute. Hence, we could have more fusion chances
> and better optimization.
> 
> gcc/ChangeLog:
> 
>          * config/riscv/vector.md: Remove vste.
Just to confirm that I understand the basic model.  Vector stores only 
update active elements, thus they don't care about tail policy, right?
 
Assuming that's the case, then this is OK.
 
jeff
 

Re: Re: [PATCH] RISC-V: Remove unit-stride store from ta attribute

[Kito Cheng]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

Commited to trunk, thanks:)


钟居哲 <juzhe.zhong@rivai.ai> 於 2022年12月17日 週六 09:22 寫道：

> Yes, the vector stores doesn't care about policy no matter mask or tail.
> Removing it can allow VSETVL PASS have more optimization chances
> since VSETVL PASS has backward demands fusion.
>
> For example:
> vadd tama
> vse.v
> VSETVL PASS will choose to set tama for vse.v
>
> vadd tumu
> vse.v
> VSETVL PASS will choose to set tumu for vse.v
>
>
>
> juzhe.zhong@rivai.ai
>
> From: Jeff Law
> Date: 2022-12-17 04:01
> To: juzhe.zhong; gcc-patches
> CC: kito.cheng; palmer
> Subject: Re: [PATCH] RISC-V: Remove unit-stride store from ta attribute
>
>
> On 12/14/22 04:36, juzhe.zhong@rivai.ai wrote:
> > From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
> >
> > Since store instructions doesn't care about tail policy, we remove
> > vste from "ta" attribute. Hence, we could have more fusion chances
> > and better optimization.
> >
> > gcc/ChangeLog:
> >
> >          * config/riscv/vector.md: Remove vste.
> Just to confirm that I understand the basic model.  Vector stores only
> update active elements, thus they don't care about tail policy, right?
>
> Assuming that's the case, then this is OK.
>
> jeff
>
>