From: Mark Wielaard <mark@klomp.org>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 10/10] gdb: remote the get_remote_exec_file function
Date: Wed, 23 Aug 2023 15:42:42 +0200 [thread overview]
Message-ID: <2776c0b933342ed8e34b6217d836cc1042ea7d4e.camel@klomp.org> (raw)
In-Reply-To: <c699ccc89e5ec96396db38d29d7ae5ca9b49341f.1692200989.git.aburgess@redhat.com>
Hi Andrew,
On Wed, 2023-08-16 at 16:55 +0100, Andrew Burgess wrote:
> After the previous commit, the get_remote_exec_file function is only
> used in one place, so inline it and delete get_remote_exec_file.
>
> There should be no user visible changes after this commit.
This looks sane to me. Is the subject a clever joke or a typo?
It made me smile, but also I had to read it three times before I
understood what was really going on. Maybe s/remote the/remove the/ for
clarity?
Reviewed-by: Mark Wielaard <mark@klomp.org>
> ---
> gdb/remote.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/gdb/remote.c b/gdb/remote.c
> index e2d21c65b70..966bacd7fb5 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -1864,16 +1864,6 @@ remote_target::get_remote_state ()
> return &m_remote_state;
> }
>
> -/* Fetch the remote exec-file from the current program space. */
> -
> -static const std::string &
> -get_remote_exec_file ()
> -{
> - const remote_exec_file_info &info
> - = get_remote_exec_file_info (current_program_space);
> - return info.first;
> -}
> -
> /* Set the remote exec file for PSPACE. */
>
> static void
> @@ -1900,7 +1890,9 @@ set_remote_exec_file_cb (const std::string &filename)
> static const std::string &
> get_remote_exec_file_cb ()
> {
> - return get_remote_exec_file ();
> + const remote_exec_file_info &info
> + = get_remote_exec_file_info (current_program_space);
> + return info.first;
> }
>
> /* Implement the "show remote exec-file" command. */
next prev parent reply other threads:[~2023-08-23 13:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:54 [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Andrew Burgess
2023-08-16 15:54 ` [PATCH 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-23 9:30 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-23 8:44 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-23 11:36 ` Mark Wielaard
2023-08-24 8:56 ` Alexandra Petlanova Hajkova
2023-08-16 15:55 ` [PATCH 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-16 16:36 ` Eli Zaretskii
2023-08-28 15:35 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-16 15:55 ` [PATCH 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-23 13:35 ` Mark Wielaard
2023-08-16 15:55 ` [PATCH 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-16 16:34 ` Eli Zaretskii
2023-08-25 14:49 ` Andrew Burgess
2023-08-25 15:01 ` Eli Zaretskii
2023-09-26 14:42 ` Andrew Burgess
2023-09-29 7:45 ` Eli Zaretskii
2023-08-22 2:39 ` Thiago Jung Bauermann
2023-08-23 9:24 ` Mark Wielaard
2023-08-23 11:36 ` Andrew Burgess
2023-08-28 16:06 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-16 16:40 ` Eli Zaretskii
2023-08-16 15:55 ` [PATCH 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-16 15:55 ` [PATCH 10/10] gdb: remote the get_remote_exec_file function Andrew Burgess
2023-08-23 13:42 ` Mark Wielaard [this message]
2023-08-22 10:41 ` [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Alexandra Petlanova Hajkova
2023-08-23 14:32 ` Mark Wielaard
2023-08-23 15:26 ` Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 " Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-26 6:46 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-26 6:54 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-26 6:49 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 10/10] gdb: remove the get_remote_exec_file function Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2776c0b933342ed8e34b6217d836cc1042ea7d4e.camel@klomp.org \
--to=mark@klomp.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).