Re: [PATCH 08/10] gdb: remote filesystem can be local to GDB in some cases

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Wed, 16 Aug 2023 16:55:04 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index d83f097d937..99ed057c412 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -106,6 +106,13 @@
>    subsequent runs of the inferior will use the same arguments as the
>    first run.
>  
> +* For remote targets that support the qMachineId packet, if GDB
> +  believes that the remote target is on the same host as GDB itself,
> +  and that GDB can access the same files as the remote target, then
> +  GDB will take advantage of this to access files directly, rather
> +  than copying them from the remote target.  This behaviour can be
> +  disable using the new command 'set remote local-filesystem off'.
> +
>  * New commands
>  
>  set debug breakpoint on|off
> @@ -133,6 +140,24 @@ show always-read-ctf
>  info main
>    Get main symbol to identify entry point into program.
>  
> +set remote local-filesystem on|off|auto
> +show remote local-filesystem
> +  When 'on' GDB will assume that its local filesystem is the same
> +  filesystem as the remote target, this effectively means GDB will
> +  ignore any 'target:' prefix in the sysroot setting.  When 'off' GDB
> +  will use the sysroot value to determine if a path is remote or not;
> +  a sysroot starting 'target:' indicates that paths should be treated
> +  as remote.
> +
> +  The default value for this setting is 'auto', in this mode GDB will
> +  make use of the qMachineId packet to determine if the remote target
> +  is on the same host as GDB or not.  For remote targets that don't
> +  support qMachineId, or in cases where the qMachineId indicates that
> +  the remote target is truly remote, GDB will behave as if this
> +  setting is 'off'.  Only when qMachineId is supported, and qMachineId
> +  indicates the remote target is on the same host as GDB, will GDB
> +  treat this setting as 'on'.
> +

This part is OK.

> +@anchor{set remote local-filesystem}
> +@item set remote local-filesystem @r{[}auto@r{|}on@r{|}off@r{]}
> +@itemx show remote local-filesystem
> +@cindex filesystem, for remote target

@cindex before @item again.

> +  add_setshow_auto_boolean_cmd ("local-filesystem", class_files,
> +				&remote_filesystem_is_local, _("\
> +Set whether the remote's filesystem is local to GDB."), _("\
> +Show whether the remote's filesystem is local to GDB."), _("\
> +When 'on' GDB assumes that the remote target's filesystem is the same\n\
            ^
Comma missing there.

> +When 'off' GDB will always fetch files using the remote protocol,\n\
             ^
And there.

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>