From: Mark Wielaard <mark@klomp.org>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 06/10] gdb: make use of is_target_filename
Date: Wed, 23 Aug 2023 15:35:02 +0200 [thread overview]
Message-ID: <d3f19ef16ae847583a1315b9fa580e1997efe383.camel@klomp.org> (raw)
In-Reply-To: <eacb536dcaf8adc823016d30f611c8b100beaf5b.1692200989.git.aburgess@redhat.com>
Hi Andrew,
On Wed, 2023-08-16 at 16:55 +0100, Andrew Burgess wrote:
> Spotted a place where is_target_filename could be used, except that
> is_target_filename takes 'const char *' and in the location I spotted
> we have a std::string. So I've added an overload for
> is_target_filename that takes a std::string.
>
> There should be no user visible change after this commit.
This makes sense to me given that all is_target_filename really does
is: return startswith (name, TARGET_SYSROOT_PREFIX);
So this just moves the logic in one place.
Reviewed-by: Mark Wielaard <mark@klomp.org>
> ---
> gdb/build-id.c | 2 +-
> gdb/gdb_bfd.h | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/build-id.c b/gdb/build-id.c
> index f68384f0197..6abf04ffacd 100644
> --- a/gdb/build-id.c
> +++ b/gdb/build-id.c
> @@ -90,7 +90,7 @@ build_id_to_debug_bfd_1 (const std::string &link, size_t build_id_len,
> /* lrealpath() is expensive even for the usually non-existent files. */
> gdb::unique_xmalloc_ptr<char> filename_holder;
> const char *filename = nullptr;
> - if (startswith (link, TARGET_SYSROOT_PREFIX))
> + if (is_target_filename (link))
> filename = link.c_str ();
> else if (access (link.c_str (), F_OK) == 0)
> {
> diff --git a/gdb/gdb_bfd.h b/gdb/gdb_bfd.h
> index d15b1106d9a..5e9468dcdfd 100644
> --- a/gdb/gdb_bfd.h
> +++ b/gdb/gdb_bfd.h
> @@ -44,6 +44,14 @@ struct registry_accessor<bfd>
>
> int is_target_filename (const char *name);
>
> +/* Like the above, but for std::string. */
> +
> +static inline int
> +is_target_filename (const std::string &name)
> +{
> + return is_target_filename (name.c_str ());
> +}
> +
> /* Returns nonzero if the filename associated with ABFD starts with
> TARGET_SYSROOT_PREFIX, zero otherwise. */
>
next prev parent reply other threads:[~2023-08-23 13:35 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:54 [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Andrew Burgess
2023-08-16 15:54 ` [PATCH 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-23 9:30 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-23 8:44 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-23 11:36 ` Mark Wielaard
2023-08-24 8:56 ` Alexandra Petlanova Hajkova
2023-08-16 15:55 ` [PATCH 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-16 16:36 ` Eli Zaretskii
2023-08-28 15:35 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-16 15:55 ` [PATCH 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-23 13:35 ` Mark Wielaard [this message]
2023-08-16 15:55 ` [PATCH 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-16 16:34 ` Eli Zaretskii
2023-08-25 14:49 ` Andrew Burgess
2023-08-25 15:01 ` Eli Zaretskii
2023-09-26 14:42 ` Andrew Burgess
2023-09-29 7:45 ` Eli Zaretskii
2023-08-22 2:39 ` Thiago Jung Bauermann
2023-08-23 9:24 ` Mark Wielaard
2023-08-23 11:36 ` Andrew Burgess
2023-08-28 16:06 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-16 16:40 ` Eli Zaretskii
2023-08-16 15:55 ` [PATCH 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-16 15:55 ` [PATCH 10/10] gdb: remote the get_remote_exec_file function Andrew Burgess
2023-08-23 13:42 ` Mark Wielaard
2023-08-22 10:41 ` [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Alexandra Petlanova Hajkova
2023-08-23 14:32 ` Mark Wielaard
2023-08-23 15:26 ` Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 " Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-26 6:46 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-26 6:54 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-26 6:49 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 10/10] gdb: remove the get_remote_exec_file function Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f19ef16ae847583a1315b9fa580e1997efe383.camel@klomp.org \
--to=mark@klomp.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).