From: Mark Wielaard <mark@klomp.org>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Cc: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Subject: Re: [PATCH 07/10] gdb: add qMachineId packet
Date: Wed, 23 Aug 2023 11:24:17 +0200 [thread overview]
Message-ID: <62e6f9f8bf689e8f64b986afaefc4928bde3093a.camel@klomp.org> (raw)
In-Reply-To: <94e68e6c1400ede2e9e46fc8ef76bd82aa533e0e.1692200989.git.aburgess@redhat.com>
Hi Andrew,
On Wed, 2023-08-16 at 16:55 +0100, Andrew Burgess wrote:
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index e749194e039..ae40e885e70 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -51,6 +51,8 @@
> #include "gdbsupport/scoped_restore.h"
> #include "gdbsupport/search.h"
>
> +#include <systemd/sd-id128.h>
> +
> /* PBUFSIZ must also be at least as big as IPA_CMD_BUF_SIZE, because
> the client state data is passed directly to some agent
> functions. */
This include is only available when systemd-devel headers are
installed. But it seems not to be used, so can just be removed as far
as I can tell.
Cheers,
Mark
next prev parent reply other threads:[~2023-08-23 9:24 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:54 [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Andrew Burgess
2023-08-16 15:54 ` [PATCH 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-23 9:30 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-23 8:44 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-23 11:36 ` Mark Wielaard
2023-08-24 8:56 ` Alexandra Petlanova Hajkova
2023-08-16 15:55 ` [PATCH 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-16 16:36 ` Eli Zaretskii
2023-08-28 15:35 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-16 15:55 ` [PATCH 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-23 13:35 ` Mark Wielaard
2023-08-16 15:55 ` [PATCH 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-16 16:34 ` Eli Zaretskii
2023-08-25 14:49 ` Andrew Burgess
2023-08-25 15:01 ` Eli Zaretskii
2023-09-26 14:42 ` Andrew Burgess
2023-09-29 7:45 ` Eli Zaretskii
2023-08-22 2:39 ` Thiago Jung Bauermann
2023-08-23 9:24 ` Mark Wielaard [this message]
2023-08-23 11:36 ` Andrew Burgess
2023-08-28 16:06 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-16 16:40 ` Eli Zaretskii
2023-08-16 15:55 ` [PATCH 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-16 15:55 ` [PATCH 10/10] gdb: remote the get_remote_exec_file function Andrew Burgess
2023-08-23 13:42 ` Mark Wielaard
2023-08-22 10:41 ` [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Alexandra Petlanova Hajkova
2023-08-23 14:32 ` Mark Wielaard
2023-08-23 15:26 ` Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 " Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-26 6:46 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-26 6:54 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-26 6:49 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 10/10] gdb: remove the get_remote_exec_file function Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62e6f9f8bf689e8f64b986afaefc4928bde3093a.camel@klomp.org \
--to=mark@klomp.org \
--cc=aburgess@redhat.com \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).