Re: [PATCH 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Wed, 16 Aug 2023 16:55:00 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index ef2b3b3a4f5..9839330c46d 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -98,6 +98,14 @@
>    user that the end of file has been reached, refers the user to the
>    newly added '.' argument
>  
> +* When connecting to a remote server, if the server supports the
> +  qDefaultExecAndArgs packet, then GDB will copy the argument string
> +  from the server and update the 'args' setting, as if 'set args ...'
> +  had been used.  This means that the arguments are visible from GDB
> +  using 'show args', and that, if using the extended-remote protocol,
> +  subsequent runs of the inferior will use the same arguments as the
> +  first run.
> +
>  * New commands
>  
>  set debug breakpoint on|off
> @@ -257,6 +265,13 @@ info main
>    ** gdb.Progspace now has the new method "objfile_for_address".  This
>       returns the gdb.Objfile, if any, that covers a given address.
>  
> +* New remote packets
> +
> +qDefaultExecAndArgs
> +  This packet returns the executable filename and argument string with
> +  which the server was started.  If no such information was given to
> +  the server then this is reflected in the reply.
> +
>  *** Changes in GDB 13

This part is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -44718,6 +44718,36 @@
>  A badly formed request or an error was encountered.
>  @end table
>  
> +@item qDefaultExecAndArgs
> +@cindex query executable, remote request
> +@cindex query program arguments, remote request
> +@cindex @samp{qDefaultExecAndArgs} packet

Once again, the @cindex entries should be before the @item line.

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>