From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2 07/10] gdb: add qMachineId packet
Date: Sat, 26 Aug 2023 09:54:47 +0300 [thread overview]
Message-ID: <83edjqmgy0.fsf@gnu.org> (raw)
In-Reply-To: <050e4522564ed979d49880203cd7ac7b9af6ec48.1692977354.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Fri, 25 Aug 2023 16:34:40 +0100)
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Fri, 25 Aug 2023 16:34:40 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
>
> gdb/Makefile.in | 3 +
> gdb/NEWS | 5 ++
> gdb/configure.nat | 2 +-
> gdb/doc/gdb.texinfo | 126 +++++++++++++++++++++++++++
> gdb/linux-nat.c | 42 +++++++++
> gdb/nat/linux-machine-id.c | 85 +++++++++++++++++++
> gdb/nat/linux-machine-id.h | 75 ++++++++++++++++
> gdb/nat/linux-namespaces.c | 13 +++
> gdb/nat/linux-namespaces.h | 14 +++
> gdb/remote-machine-id.c | 69 +++++++++++++++
> gdb/remote-machine-id.h | 108 ++++++++++++++++++++++++
> gdb/remote.c | 169 +++++++++++++++++++++++++++++++++++++
> gdbserver/Makefile.in | 1 +
> gdbserver/configure.srv | 2 +-
> gdbserver/linux-low.cc | 24 ++++++
> gdbserver/linux-low.h | 2 +
> gdbserver/server.cc | 12 +++
> gdbserver/target.cc | 8 ++
> gdbserver/target.h | 9 ++
> 19 files changed, 767 insertions(+), 2 deletions(-)
> create mode 100644 gdb/nat/linux-machine-id.c
> create mode 100644 gdb/nat/linux-machine-id.h
> create mode 100644 gdb/remote-machine-id.c
> create mode 100644 gdb/remote-machine-id.h
Thanks.
> diff --git a/gdb/NEWS b/gdb/NEWS
> index d78929c1398..2b1f265f5b8 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -293,6 +293,11 @@ qDefaultExecAndArgs
> which the server was started. If no such information was given to
> the server then this is reflected in the reply.
>
> +qMachineId
> + This packet returns an identifier that allows GDB to determine if
> + the remote server and GDB are running on the same host, and can see
> + the same filesystem.
> +
> *** Changes in GDB 13
This part is OK.
> +The @var{mnt-id} and @var{user-id} are either the character @samp{-}
> +if the particular namespace is not support on this host, or is the
^^^^^^^
"supported"
> +When matching a machine-id @value{GDBN} first checks the reply for a
> +master key that it understands. If a suitable key is found
> +@value{GDBN} checks that the value for the master key matches its
> +value for the master key. If the master key value matches, then
> +@value{GDBN} checks all the remaining @var{key}/@var{value} pairs;
> +each @var{key} must be known secondary key associated with the
^^^^^^^^^^^^^^^^^^^^^^^^^^^
"must be a known secondary key"
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-08-26 6:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:54 [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Andrew Burgess
2023-08-16 15:54 ` [PATCH 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-23 9:30 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-23 8:44 ` Alexandra Petlanova Hajkova
2023-08-16 15:54 ` [PATCH 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-23 11:36 ` Mark Wielaard
2023-08-24 8:56 ` Alexandra Petlanova Hajkova
2023-08-16 15:55 ` [PATCH 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-16 16:36 ` Eli Zaretskii
2023-08-28 15:35 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-16 15:55 ` [PATCH 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-23 13:35 ` Mark Wielaard
2023-08-16 15:55 ` [PATCH 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-16 16:34 ` Eli Zaretskii
2023-08-25 14:49 ` Andrew Burgess
2023-08-25 15:01 ` Eli Zaretskii
2023-09-26 14:42 ` Andrew Burgess
2023-09-29 7:45 ` Eli Zaretskii
2023-08-22 2:39 ` Thiago Jung Bauermann
2023-08-23 9:24 ` Mark Wielaard
2023-08-23 11:36 ` Andrew Burgess
2023-08-28 16:06 ` Tom Tromey
2023-08-16 15:55 ` [PATCH 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-16 16:40 ` Eli Zaretskii
2023-08-16 15:55 ` [PATCH 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-16 15:55 ` [PATCH 10/10] gdb: remote the get_remote_exec_file function Andrew Burgess
2023-08-23 13:42 ` Mark Wielaard
2023-08-22 10:41 ` [PATCH 00/10] Improve GDB/gdbserver experience when using a local gdbserver Alexandra Petlanova Hajkova
2023-08-23 14:32 ` Mark Wielaard
2023-08-23 15:26 ` Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 " Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 01/10] gdb: have remote_target::extended_remote_run take the exec filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 02/10] gdb: improve how 'remote exec-file' is stored and accessed Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 03/10] gdb: improve show text and help text for 'remote exec-file' Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 04/10] gdb/gdbserver: add new qDefaultExecAndArgs packet Andrew Burgess
2023-08-26 6:46 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 05/10] gdb: detect when gdbserver has no default executable set Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 06/10] gdb: make use of is_target_filename Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 07/10] gdb: add qMachineId packet Andrew Burgess
2023-08-26 6:54 ` Eli Zaretskii [this message]
2023-08-25 15:34 ` [PATCHv2 08/10] gdb: remote filesystem can be local to GDB in some cases Andrew Burgess
2023-08-26 6:49 ` Eli Zaretskii
2023-08-25 15:34 ` [PATCHv2 09/10] gdb: use exec_file with remote targets when possible Andrew Burgess
2023-08-25 15:34 ` [PATCHv2 10/10] gdb: remove the get_remote_exec_file function Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edjqmgy0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).