Re: GDB 12.0.90 available for testing

[Pedro Alves <pedro@palves.net>]

On 2022-03-31 07:21, Eli Zaretskii via Gdb-patches wrote:
>> Date: Sat, 26 Mar 2022 20:59:04 +0300
>> From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
>> Cc: gdb-patches@sourceware.org
>>
>> Second, one of the selftests fails:
>>
>>   Running selftest dw2_expand_symtabs_matching.
>>   warning: charset conversion failure for 'u8função'.
>>   You may have the wrong value for 'set ada source-charset'.
>>   warning: could not convert 'yfunc ' from the host encoding (CP1255) to UTF-32.
>>   This normally should not happen, please file a bug report.
>>
>> AFAIU, this is because the names of these two functions are,
>> respectively, in UTF-8 and in Latin-1, but the charset conversion
>> thinks they are in CP1255.  Where does the test tell the conversion
>> functions what is the source encoding?
> 
> Ping!  Can someone please help me debugging this selftest failure?
> Where should I look for the definitions of the host charset used by
> this selftest?

This is not really a failure, it's just a warning, though the message
gdb prints sounds scary.  I chatted with Tromey about it last week, and the
issue is that there's a unit test that always exercises a symbol with a
latin-1 character (0xff).  I added that testcase originally, and IIRC, that
was about making sure that the name lookup index was able to sort
strings properly with the 0xff character, because the code
does "ch+1" at some point in the sorting/lookup algorithm, which overflows
in that case.

It may be that fix is to make the unit test temporarily set the
host charset, and also to remove that "should not happen" warning, as
I think that it should be possible to come up with such symbol names
with escape codes, thus it's not always really a bug.

But in nutshell, this isn't really a GDB bug, and it shouldn't block the release.