Re: GDB 12.0.90 available for testing

[Pedro Alves <pedro@palves.net>]

On 2022-04-08 14:38, Tom Tromey wrote:
>>> # The gnulib commit ID to use for the update.
>>> -GNULIB_COMMIT_SHA1="776af40e09b476a41073131a90022572f448c189"
>>> +GNULIB_COMMIT_SHA1="58c597d13bc57dce3e97ea97856573f2d68ccb8c"
>>>
>>> # The expected version number for the various auto tools we will
>>> # use after the import.
> 
> Joel> Is it just code, or does this update also cause the imports to
> Joel> somehow change? The import changes would be the only thing that
> Joel> might raise red-flags for me. Other than that, I don't think
> Joel> I'd need to see the diff, really. The import process being
> Joel> automated IIRC, it's all mechanical, as you say.
> 
> I don't really know how to check this.
> I re-ran update-gnulib.sh and it printed the appended module list.
> 

It used to be that the update would tell you what dependencies were
new, and which were removed.  Either gnulib changed and doesn't print the same
helpful info anymore, or the dependencies really didn't change.
To be sure, I'd diff the logs of two different re-imports from scratch:

 - reimport gnulib at the current hash from scratch: 
     rm -rf gnulib/import
     mkdir gnulib/import/ #to keep our script happy
     ./update-gnulib.sh .... 2>&1 | tee org

 - import gnulib at the new hash from scratch: 

     rm -rf gnulib/import
     mkdir gnulib/import/ #to keep our script happy
     ./update-gnulib.sh .... 2>&1 | tee new

  diff org new, look out for new/dropped dependencies, see if we're 
  losing something that we really do no want to lose but missed
  adding as explicit dependency, check if we gained some new
  dependency that actually eliminates the need for our own portability
  code, etc.

Regardless, I would suggest that updating is useful to see the
dependency updates, and other helpful info, but for final & real
update, I'd suggest always reimporting from scratch, to avoid
trusting that gnulib's update logic worked as well, that it
removed stale files correctly, etc.

Pedro Alves