From: Joel Brobecker <brobecker@adacore.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>, binutils@sourceware.org
Cc: Luis Machado <luis.machado@arm.com>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org, vapier@gentoo.org
Subject: Re: GDB 12.0.90 available for testing
Date: Sun, 17 Apr 2022 10:33:59 -0700 [thread overview]
Message-ID: <YlxPh8H/e3Av4elZ@adacore.com> (raw)
In-Reply-To: <87pmllq7jr.fsf@oracle.com>
Adding binutils@ to the list, since opcode is part of binutils.
Can someone take a look at Luis' patch below, please? Luis noticed
this when he tried to build the GDB 12 release candidate with
--enable-target=all.
Thank you!
On Wed, Apr 13, 2022 at 06:20:24PM +0200, Jose E. Marchesi wrote:
>
> > This particular combination of switches and host has not been built in
> > a while, so bugs might've been introduced/uncovered.
> >
> > Mike, Jose, does this look reasonable?
>
> Sure, for BPF.
>
> I wonder how we missed TARGET32_LIBOCODES_CFILES back when we integrated
> the bpf backend...
>
> Thanks for fixing this.
>
> > From 387ef2492403c89ac7ac817488a49a3fd7d9d4ba Mon Sep 17 00:00:00 2001
> > From: Luis Machado <luis.machado@arm.com>
> > Date: Wed, 13 Apr 2022 11:39:36 +0100
> > Subject: [PATCH] Fix 32-bit build for --enable-targets=all
> >
> > The following fixes the GDB build for 32-bit (tested on 32-bit arm)
> > for the following combinations:
> >
> > * --enable-targets=all --disable-sim
> > * --enable-targets=all
> >
> > I do see quite a few internal errors when running
> > gdb.base/all-architectures.exp on arm 32-bit Ubuntu 18.04. They all
> > fail when checking for a default disassembling function, which doesn't
> > exists for some targets.
> >
> > This particular combination of switches has not been tested for 32-bit
> > hosts in a while (since November/December 2021), so there might be bugs
> > that we need to address. The patch makes things build cleanly though.
> >
> > Tested on aarch64-linux Ubuntu 20.04 and armhf-linux-gnueabi Ubuntu 18.04.
> >
> > It would be nice to exercise this on other 32-bit targets.
> > ---
> > opcodes/Makefile.am | 10 ++++++++++
> > opcodes/Makefile.in | 10 ++++++++++
> > 2 files changed, 20 insertions(+)
> >
> > diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am
> > index afd19fa7785..681fbc07584 100644
> > --- a/opcodes/Makefile.am
> > +++ b/opcodes/Makefile.am
> > @@ -124,6 +124,11 @@ TARGET32_LIBOPCODES_CFILES = \
> > arm-dis.c \
> > avr-dis.c \
> > bfin-dis.c \
> > + bpf-asm.c \
> > + bpf-desc.c \
> > + bpf-dis.c \
> > + bpf-ibld.c \
> > + bpf-opc.c \
> > cgen-asm.c \
> > cgen-bitset.c \
> > cgen-dis.c \
> > @@ -178,6 +183,9 @@ TARGET32_LIBOPCODES_CFILES = \
> > lm32-ibld.c \
> > lm32-opc.c \
> > lm32-opinst.c \
> > + loongarch-opc.c \
> > + loongarch-dis.c \
> > + loongarch-coder.c \
> > m10200-dis.c \
> > m10200-opc.c \
> > m10300-dis.c \
> > @@ -234,6 +242,8 @@ TARGET32_LIBOPCODES_CFILES = \
> > ppc-opc.c \
> > pru-dis.c \
> > pru-opc.c \
> > + riscv-dis.c \
> > + riscv-opc.c \
> > rl78-decode.c \
> > rl78-dis.c \
> > rx-decode.c \
> > diff --git a/opcodes/Makefile.in b/opcodes/Makefile.in
> > index 3ab8bfb0548..d3eee49b169 100644
> > --- a/opcodes/Makefile.in
> > +++ b/opcodes/Makefile.in
> > @@ -516,6 +516,11 @@ TARGET32_LIBOPCODES_CFILES = \
> > arm-dis.c \
> > avr-dis.c \
> > bfin-dis.c \
> > + bpf-asm.c \
> > + bpf-desc.c \
> > + bpf-dis.c \
> > + bpf-ibld.c \
> > + bpf-opc.c \
> > cgen-asm.c \
> > cgen-bitset.c \
> > cgen-dis.c \
> > @@ -570,6 +575,9 @@ TARGET32_LIBOPCODES_CFILES = \
> > lm32-ibld.c \
> > lm32-opc.c \
> > lm32-opinst.c \
> > + loongarch-opc.c \
> > + loongarch-dis.c \
> > + loongarch-coder.c \
> > m10200-dis.c \
> > m10200-opc.c \
> > m10300-dis.c \
> > @@ -626,6 +634,8 @@ TARGET32_LIBOPCODES_CFILES = \
> > ppc-opc.c \
> > pru-dis.c \
> > pru-opc.c \
> > + riscv-dis.c \
> > + riscv-opc.c \
> > rl78-decode.c \
> > rl78-dis.c \
> > rx-decode.c \
--
Joel
next prev parent reply other threads:[~2022-04-17 17:34 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 5:58 Joel Brobecker
2022-03-26 15:26 ` Eli Zaretskii
2022-03-26 15:53 ` Joel Brobecker
2022-03-26 16:15 ` Eli Zaretskii
2022-04-07 16:08 ` Tom Tromey
2022-04-07 16:12 ` Eli Zaretskii
2022-04-07 18:00 ` Joel Brobecker
2022-04-07 18:04 ` Simon Marchi
2022-04-07 19:02 ` Tom Tromey
2022-04-07 19:11 ` Joel Brobecker
2022-04-08 13:38 ` Tom Tromey
2022-04-08 14:33 ` Pedro Alves
2022-04-18 15:26 ` Tom Tromey
2022-04-18 16:13 ` Tom Tromey
2022-04-07 18:30 ` Tom Tromey
2022-04-08 6:58 ` Eli Zaretskii
2022-04-18 19:28 ` Tom Tromey
2022-03-26 17:59 ` Eli Zaretskii
2022-03-26 18:34 ` Eli Zaretskii
2022-03-26 18:51 ` Eli Zaretskii
2022-03-27 6:27 ` Eli Zaretskii
2022-03-31 6:23 ` Eli Zaretskii
2022-03-31 9:48 ` Pedro Alves
2022-03-31 11:55 ` Eli Zaretskii
2022-04-01 10:12 ` Andrew Burgess
2022-04-01 11:18 ` Eli Zaretskii
2022-04-01 11:25 ` Eli Zaretskii
2022-04-01 15:21 ` Andrew Burgess
2022-04-01 16:18 ` Eli Zaretskii
2022-04-03 13:02 ` Hannes Domani
2022-04-03 13:34 ` Eli Zaretskii
2022-04-03 14:03 ` Joel Brobecker
2022-04-03 15:26 ` Hannes Domani
2022-04-03 15:38 ` Eli Zaretskii
2022-04-07 11:09 ` Eli Zaretskii
2022-04-07 18:03 ` Joel Brobecker
2022-04-10 19:06 ` Joel Brobecker
2022-04-11 11:42 ` Eli Zaretskii
2022-04-17 17:28 ` Joel Brobecker
2022-04-19 16:12 ` Andrew Burgess
2022-04-19 16:16 ` Eli Zaretskii
2022-04-20 13:26 ` Andrew Burgess
2022-04-20 17:11 ` Joel Brobecker
2022-04-20 17:30 ` Eli Zaretskii
2022-04-24 15:56 ` Joel Brobecker
2022-04-25 8:48 ` Andrew Burgess
2022-04-07 18:28 ` Tom Tromey
2022-04-07 19:22 ` Pedro Alves
2022-04-08 4:04 ` Eli Zaretskii
2022-04-01 12:36 ` Joel Brobecker
2022-04-01 12:50 ` Eli Zaretskii
2022-04-01 14:12 ` Joel Brobecker
2022-04-01 14:27 ` Eli Zaretskii
2022-04-01 14:31 ` Joel Brobecker
2022-04-08 14:44 ` Pedro Alves
2022-04-08 20:05 ` Eli Zaretskii
2022-03-27 9:55 ` Eli Zaretskii
2022-03-27 1:55 ` Simon Marchi
2022-03-27 5:20 ` Eli Zaretskii
2022-04-07 16:13 ` Tom Tromey
2022-04-07 16:39 ` Eli Zaretskii
2022-03-31 6:21 ` Eli Zaretskii
2022-03-31 9:44 ` Pedro Alves
2022-03-31 11:58 ` Eli Zaretskii
2022-03-31 12:05 ` Pedro Alves
2022-03-31 14:00 ` Eli Zaretskii
2022-04-12 14:01 ` Luis Machado
2022-04-12 17:57 ` Joel Brobecker
2022-04-13 7:36 ` Luis Machado
2022-04-13 12:19 ` Luis Machado
2022-04-13 16:20 ` Jose E. Marchesi
2022-04-17 17:33 ` Joel Brobecker [this message]
2022-04-18 1:48 ` Alan Modra
2022-04-26 13:54 ` Luis Machado
2022-04-26 14:56 ` Joel Brobecker
2022-04-26 15:15 ` Luis Machado
2022-04-20 17:33 ` Pedro Alves
2022-04-20 17:52 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlxPh8H/e3Av4elZ@adacore.com \
--to=brobecker@adacore.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
--cc=luis.machado@arm.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).