Re: GDB 12.0.90 available for testing

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu, 7 Apr 2022 20:22:55 +0100
> Cc: ssbssa@yahoo.de, gdb-patches@sourceware.org, brobecker@adacore.com
> From: Pedro Alves <pedro@palves.net>
> 
> On 2022-04-07 12:09, Eli Zaretskii wrote:
> > --- gdb/event-top.c~0	2022-03-20 06:59:56.000000000 +0200
> > +++ gdb/event-top.c	2022-04-01 14:06:22.164500000 +0300
> > @@ -821,19 +821,6 @@ gdb_readline_no_editing_callback (gdb_cl
> >    FILE *stream = ui->instream != nullptr ? ui->instream : ui->stdin_stream;
> >    gdb_assert (stream != nullptr);
> >  
> > -  /* Unbuffer the input stream, so that, later on, the calls to fgetc
> > -     fetch only one char at the time from the stream.  The fgetc's will
> > -     get up to the first newline, but there may be more chars in the
> > -     stream after '\n'.  If we buffer the input and fgetc drains the
> > -     stream, getting stuff beyond the newline as well, a select, done
> > -     afterwards will not trigger.
> > -
> > -     This unbuffering was, at one point, not applied if the input stream
> > -     was a tty, however, the buffering can cause problems, even for a tty,
> > -     in some cases.  Please ensure that any changes in this area run the MI
> > -     tests with the FORCE_SEPARATE_MI_TTY=1 flag being passed.  */
> 
> Don't we want to preserve this comment?
> 
> > -  setbuf (stream, NULL);
> > -

This part of the patch is from Andrew, so I have no opinion about
that.  If we want to preserver it, I guess it should be moved to one
of the places where we call setbuf instead of this single place?