Re: GDB 12.0.90 available for testing

[Pedro Alves <pedro@palves.net>]

[Adding Andrew]

On 2022-03-31 07:23, Eli Zaretskii via Gdb-patches wrote:
>> Date: Sun, 27 Mar 2022 09:27:52 +0300
>> From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
>> Cc: gdb-patches@sourceware.org
>>
>>> Date: Sat, 26 Mar 2022 21:51:49 +0300
>>> From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
>>> Cc: gdb-patches@sourceware.org
>>>
>>> And yet another issue: if I start GDB with the MI interface:
>>>
>>>    gdb -i=mi PROGRAM
>>>
>>> then whatever I type at the prompt GDB thinks I typed "g":
>>>
>>>   (gdb)
>>>   r -Q
>>>   &"g\n"
>>>   &"Ambiguous command \"g\": gcore, generate-core-file, goto-bookmark, gr, gu, guile, guile-repl.\n"
>>>   ^error,msg="Ambiguous command \"g\": gcore, generate-core-file, goto-bookmark, gr, gu, guile, guile-repl."
>>>   (gdb)
>>>
>>> As you see, I typed "r -Q", but GDB thinks I typed "g".
>>
>> This is now a Bugzilla PR 29002.  I posted my proposed solution there,
>> see
>>
>>   https://sourceware.org/bugzilla/show_bug.cgi?id=29002
> 
> Ping!  The two issues described in this PR are IMO serious and should
> be fixed before GDB 12.1 is released.  Could someone please respond to
> what I wrote there, and propose how to fix this without adversely
> affecting GNU/Linux (and possibly other non-Windows platforms)?

So from the bugzilla discussion, it sounds like calling setvbuf all the
time is a bad idea.  So we should call it once for a given stream early
on, just once.  That sounds reasonable to me.  However, the patch you
attached in bugzilla doesn't seem to be doing that correctly:


836	  if (!done_once && !ISATTY (stream))
837	    {
838	      setbuf (stream, NULL);
839	      done_once = 1;
840	    }
836	
841	

because that will only do it once for all streams, and we need to do this
once per stream.