public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: GDB 12.0.90 available for testing
Date: Sun, 27 Mar 2022 08:20:13 +0300	[thread overview]
Message-ID: <83k0cg9dki.fsf@gnu.org> (raw)
In-Reply-To: <a675c4c6-9624-df61-8cec-6099eaafb764@polymtl.ca> (message from Simon Marchi on Sat, 26 Mar 2022 21:55:38 -0400)

> Date: Sat, 26 Mar 2022 21:55:38 -0400
> Cc: gdb-patches@sourceware.org
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> >        CXX    infrun.o
> >      In file included from btrace.h:30,
> > 		      from gdbthread.h:29,
> > 		      from infrun.h:21,
> > 		      from infrun.c:23:
> >      target/waitstatus.h: In function 'void stop_all_threads()':
> >      target/waitstatus.h:175:13: warning: 'ws.target_waitstatus::m_value' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >        175 |     m_value = other.m_value;
> > 	   |     ~~~~~~~~^~~~~~~~~~~~~~~
> > 
> > Is this a real problem?
> 
> I think this one is not really a problem.  It complains about this code:
> 
> 	  target_waitstatus ws;
> 	  ws.set_no_resumed ();
> 	  return {NULL, minus_one_ptid, std::move (ws)};
> 
> When settnig `ws` using `set_no_resumed`, the union field ws::m_value is
> left untouched, meaning it contains random bytes.  When we move `ws`, we
> copy random bytes.  But that doesn't matter, because the destination
> target_waitstatus is of kind TARGET_WAITKIND_NO_RESUMED, so doesn't care
> about m_value.

Maybe we should initialize ws::m_value, just to shut up the compiler?
Because GDB 12 compiles cleanly other than this warning.

  reply	other threads:[~2022-03-27  5:20 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-20  5:58 Joel Brobecker
2022-03-26 15:26 ` Eli Zaretskii
2022-03-26 15:53   ` Joel Brobecker
2022-03-26 16:15     ` Eli Zaretskii
2022-04-07 16:08       ` Tom Tromey
2022-04-07 16:12         ` Eli Zaretskii
2022-04-07 18:00           ` Joel Brobecker
2022-04-07 18:04             ` Simon Marchi
2022-04-07 19:02             ` Tom Tromey
2022-04-07 19:11               ` Joel Brobecker
2022-04-08 13:38                 ` Tom Tromey
2022-04-08 14:33                   ` Pedro Alves
2022-04-18 15:26                     ` Tom Tromey
2022-04-18 16:13                       ` Tom Tromey
2022-04-07 18:30           ` Tom Tromey
2022-04-08  6:58             ` Eli Zaretskii
2022-04-18 19:28               ` Tom Tromey
2022-03-26 17:59 ` Eli Zaretskii
2022-03-26 18:34   ` Eli Zaretskii
2022-03-26 18:51     ` Eli Zaretskii
2022-03-27  6:27       ` Eli Zaretskii
2022-03-31  6:23         ` Eli Zaretskii
2022-03-31  9:48           ` Pedro Alves
2022-03-31 11:55             ` Eli Zaretskii
2022-04-01 10:12               ` Andrew Burgess
2022-04-01 11:18                 ` Eli Zaretskii
2022-04-01 11:25                   ` Eli Zaretskii
2022-04-01 15:21                     ` Andrew Burgess
2022-04-01 16:18                       ` Eli Zaretskii
2022-04-03 13:02                         ` Hannes Domani
2022-04-03 13:34                           ` Eli Zaretskii
2022-04-03 14:03                           ` Joel Brobecker
2022-04-03 15:26                             ` Hannes Domani
2022-04-03 15:38                               ` Eli Zaretskii
2022-04-07 11:09                                 ` Eli Zaretskii
2022-04-07 18:03                                   ` Joel Brobecker
2022-04-10 19:06                                     ` Joel Brobecker
2022-04-11 11:42                                       ` Eli Zaretskii
2022-04-17 17:28                                         ` Joel Brobecker
2022-04-19 16:12                                           ` Andrew Burgess
2022-04-19 16:16                                             ` Eli Zaretskii
2022-04-20 13:26                                               ` Andrew Burgess
2022-04-20 17:11                                               ` Joel Brobecker
2022-04-20 17:30                                                 ` Eli Zaretskii
2022-04-24 15:56                                             ` Joel Brobecker
2022-04-25  8:48                                               ` Andrew Burgess
2022-04-07 18:28                                   ` Tom Tromey
2022-04-07 19:22                                   ` Pedro Alves
2022-04-08  4:04                                     ` Eli Zaretskii
2022-04-01 12:36                   ` Joel Brobecker
2022-04-01 12:50                     ` Eli Zaretskii
2022-04-01 14:12                       ` Joel Brobecker
2022-04-01 14:27                         ` Eli Zaretskii
2022-04-01 14:31                           ` Joel Brobecker
2022-04-08 14:44                             ` Pedro Alves
2022-04-08 20:05                               ` Eli Zaretskii
2022-03-27  9:55     ` Eli Zaretskii
2022-03-27  1:55   ` Simon Marchi
2022-03-27  5:20     ` Eli Zaretskii [this message]
2022-04-07 16:13       ` Tom Tromey
2022-04-07 16:39         ` Eli Zaretskii
2022-03-31  6:21   ` Eli Zaretskii
2022-03-31  9:44     ` Pedro Alves
2022-03-31 11:58       ` Eli Zaretskii
2022-03-31 12:05         ` Pedro Alves
2022-03-31 14:00           ` Eli Zaretskii
2022-04-12 14:01 ` Luis Machado
2022-04-12 17:57   ` Joel Brobecker
2022-04-13  7:36     ` Luis Machado
2022-04-13 12:19       ` Luis Machado
2022-04-13 16:20         ` Jose E. Marchesi
2022-04-17 17:33           ` Joel Brobecker
2022-04-18  1:48             ` Alan Modra
2022-04-26 13:54             ` Luis Machado
2022-04-26 14:56               ` Joel Brobecker
2022-04-26 15:15                 ` Luis Machado
2022-04-20 17:33 ` Pedro Alves
2022-04-20 17:52   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83k0cg9dki.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).