public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
* RE: [PATCH] Add missing prototype in gdbtk.c
@ 2012-03-30 13:48 Roland Schwingel
  0 siblings, 0 replies; 7+ messages in thread
From: Roland Schwingel @ 2012-03-30 13:48 UTC (permalink / raw)
  To: Pierre Muller, insight, Keith Seitz

Hi Pierre...

insight-owner@sourceware.org wrote on 30.03.2012 15:31:24:

 >
 >   I wasn't sure about the fact that this is a real
 > Prototype requirement or not, so I wanted to ask anyway...
 >
 >   Patch committed.
 >
 >   Roland, could you please confirm that
 > this also works for mingw64.
You have been faster than me on this...
Yes it works here, too - as already replied in my other post.

 >
 >   By the way, I got a working insight for mingw32,
 > which I was unable to get for a lllloooonnngggg time!
 >   A really big thank to Roland for this!
You are welcome. I am also happy to have both a 32bit and 64bit insight! 
It was worth the effort.

 > PS: I treid to compiled a mingw64 version of insight,
 > but I get failures here:
There is IMHO no way to get insight running on 64bit windows using the 
current intree tcl/tk 8.4. I am using tcl/tk 8.6 for this. I am not done 
with sending all my patches for building a 64bit windows insight. There 
is still some way to go!

See my description here
http://sourceware.org/ml/insight/2012-q1/msg00050.html
and here
http://sourceware.org/ml/insight/2012-q1/msg00017.html

If you like to I can supply you a 64bit binary (but have to check 
whether I have enabled pascal in my gdb sources ;-)

Roland

^ permalink raw reply	[flat|nested] 7+ messages in thread
* RE: [PATCH] Add missing prototype in gdbtk.c
@ 2012-03-30 13:36 Roland Schwingel
  0 siblings, 0 replies; 7+ messages in thread
From: Roland Schwingel @ 2012-03-30 13:36 UTC (permalink / raw)
  To: Keith Seitz, insight

Hi ...

"Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr> wrote on 30.03.2012 
15:02:30:
 > In fact, the same error also appears when
 > trying to compile a mingw32 version.
 >
 > I hope that I found the reason:
 > Prototypes apparently require (void) instead of ().
 >
 > The following patch fixes the problem for mingw32,
 >
 > Is this patch OK?
Ah yes that's it. I got the error and thought that there would be no
prototype at all. Work here now too and so obsoletes my patch.

Roland

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] Add missing prototype in gdbtk.c
@ 2012-03-19 12:10 Roland Schwingel
  2012-03-29 23:02 ` Keith Seitz
  0 siblings, 1 reply; 7+ messages in thread
From: Roland Schwingel @ 2012-03-19 12:10 UTC (permalink / raw)
  To: insight

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

Hi...

In gdbtk.c there is a protoype missing for the windows only function 
close_bfds(). This is required due to recently enabled 
-Wmissing-prototype compilation.

Changelog:

2012-03-19  Roland Schwingel <roland.schwingel@onevision.com>

         * generic/gdbtk.c: Add prototype for close_bfds().

Any comments? Is this ok?

Roland

[-- Attachment #2: missing_prototype_gdbtk.c.patch --]
[-- Type: text/plain, Size: 518 bytes --]

Index: //subnet-homes/Entwicklung/User/roland/local/gdb/head/source/gdb/gdbtk/generic/gdbtk.c
===================================================================
--- //subnet-homes/Entwicklung/User/roland/local/gdb/head/source/gdb/gdbtk/generic/gdbtk.c	(revision 115571)
+++ //subnet-homes/Entwicklung/User/roland/local/gdb/head/source/gdb/gdbtk/generic/gdbtk.c	(working copy)
@@ -165,6 +165,8 @@
  * this will cost us if and when we need to reopen it.
  */
 
+extern void close_bfds (void);
+
 void
 close_bfds ()
 {

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-03-30 13:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-30 13:48 [PATCH] Add missing prototype in gdbtk.c Roland Schwingel
  -- strict thread matches above, loose matches on Subject: below --
2012-03-30 13:36 Roland Schwingel
2012-03-19 12:10 Roland Schwingel
2012-03-29 23:02 ` Keith Seitz
2012-03-30 13:03   ` Pierre Muller
2012-03-30 13:10     ` Keith Seitz
2012-03-30 13:32       ` Pierre Muller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).