* Add SRFI-197 Implementation for Kawa
@ 2021-03-06 9:04 Alcides Flores Pineda
2021-03-06 19:11 ` Per Bothner
0 siblings, 1 reply; 8+ messages in thread
From: Alcides Flores Pineda @ 2021-03-06 9:04 UTC (permalink / raw)
To: Kawa Community
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
Hello everybody:
I hope you are all fine and in good health.
After being searching for something like the "threading-macros" that
exist in a couple of Lisp dialects out there, I finally managed to
add/integrate a syntax-case implementation of SRFI-197 for Kawa as it is
shown in the reference implementation.
* https://github.com/ar-nelson/srfi-197
* https://srfi.schemers.org/srfi-197/srfi-197.html
I have already opened a merge request with the changes in GitLab, and
also by this means I'm sending the patch with the changes, if some of you
want to test/review/use the SRFI implementation integrated in the Kawa
source tree.
Altough I've been a Kawa user/enthusiast for some years, nevertheless
this is my very first attempt to contribute to the source code, so I
guess peer review is required.
[-- Attachment #2: Add SRFI-197 --]
[-- Type: application/gzip, Size: 9154 bytes --]
[-- Attachment #3: Type: text/plain, Size: 63 bytes --]
Thank you in advance.
Greetings.
--
Alcides Flores Pineda.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Add SRFI-197 Implementation for Kawa
2021-03-06 9:04 Add SRFI-197 Implementation for Kawa Alcides Flores Pineda
@ 2021-03-06 19:11 ` Per Bothner
2021-03-06 21:50 ` Alcides Flores Pineda
0 siblings, 1 reply; 8+ messages in thread
From: Per Bothner @ 2021-03-06 19:11 UTC (permalink / raw)
To: Alcides Flores Pineda, Kawa Community
Mostly looks good, but one litle problem:
As a general rule, it's a good idea to separate out
formatting changes (whitespace errors and re-indentation)
from substantive changes, as separate commits. One reason is if we
need to go back and figure out what changes caused a problem.
Another is it makes review easier.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Add SRFI-197 Implementation for Kawa
2021-03-06 19:11 ` Per Bothner
@ 2021-03-06 21:50 ` Alcides Flores Pineda
2021-03-07 2:37 ` Per Bothner
0 siblings, 1 reply; 8+ messages in thread
From: Alcides Flores Pineda @ 2021-03-06 21:50 UTC (permalink / raw)
To: Per Bothner; +Cc: Kawa Community
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
Hi Per.
Thank you very much for your response and feedback.
You are right. I do apologize for sendig such a dirty patch.
I have now removed the unwanted changes and cleaned it.
Here it is in a much better state I hope.
[-- Attachment #2: Add SRFI-197 clean patch --]
[-- Type: application/gzip, Size: 4104 bytes --]
[-- Attachment #3: Type: text/plain, Size: 444 bytes --]
Thanks again for your feedback.
Greetings.
--
Alcides Flores Pineda.
In, mar 06 2021, Per Bothner scripsit:
> Mostly looks good, but one litle problem:
>
> As a general rule, it's a good idea to separate out
> formatting changes (whitespace errors and re-indentation)
> from substantive changes, as separate commits. One reason is if we
> need to go back and figure out what changes caused a problem.
> Another is it makes review easier.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Add SRFI-197 Implementation for Kawa
2021-03-06 21:50 ` Alcides Flores Pineda
@ 2021-03-07 2:37 ` Per Bothner
2021-03-07 22:12 ` Alcides Flores Pineda
0 siblings, 1 reply; 8+ messages in thread
From: Per Bothner @ 2021-03-07 2:37 UTC (permalink / raw)
To: Alcides Flores Pineda; +Cc: Kawa Community
On 3/6/21 1:50 PM, Alcides Flores Pineda wrote:
> Hi Per.
>
> Thank you very much for your response and feedback.
> You are right. I do apologize for sendig such a dirty patch.
>
> I have now removed the unwanted changes and cleaned it.
>
> Here it is in a much better state I hope.
Looks good.
I can apply the diff and check it in, or you can prepare a pull-request,
It should be added to this list:
http://www.gnu.org/software/kawa/Implemented-SRFIs.html
for which the source file is doc/kawa.texi
I can handle that.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Add SRFI-197 Implementation for Kawa
2021-03-07 2:37 ` Per Bothner
@ 2021-03-07 22:12 ` Alcides Flores Pineda
2021-04-30 16:36 ` Alcides Flores Pineda
0 siblings, 1 reply; 8+ messages in thread
From: Alcides Flores Pineda @ 2021-03-07 22:12 UTC (permalink / raw)
To: Per Bothner; +Cc: Kawa Community
Hello Per:
I have closed the old pull-request !30 (AKA merge-request in GitLab) and
created a new one with the clean changes (!31).
* https://gitlab.com/kashell/Kawa/-/merge_requests/31
This doesn't include the documentation file `doc/kawa.texi`.
Greetings.
--
Alcides Flores Pineda.
On mar 06 2021, Per Bothner wrote:
> On 3/6/21 1:50 PM, Alcides Flores Pineda wrote:
>> Hi Per.
>> Thank you very much for your response and feedback.
>> You are right. I do apologize for sendig such a dirty patch.
>> I have now removed the unwanted changes and cleaned it.
>> Here it is in a much better state I hope.
>
> Looks good.
>
> I can apply the diff and check it in, or you can prepare a pull-request,
>
> It should be added to this list:
> http://www.gnu.org/software/kawa/Implemented-SRFIs.html
> for which the source file is doc/kawa.texi
> I can handle that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Add SRFI-197 Implementation for Kawa
2021-03-07 22:12 ` Alcides Flores Pineda
@ 2021-04-30 16:36 ` Alcides Flores Pineda
2021-04-30 20:23 ` Per Bothner
0 siblings, 1 reply; 8+ messages in thread
From: Alcides Flores Pineda @ 2021-04-30 16:36 UTC (permalink / raw)
To: Per Bothner; +Cc: Kawa Community
Hello Per:
I finally managed to update the documentation file and added srfi-197 to
the list of implemented SRFIs.
Here is the pull-request !32 with the added lines.
* https://gitlab.com/kashell/Kawa/-/merge_requests/32
Greetings
--
Alcides Flores Pineda.
Sistemas Movivendor.
On, mar 07 2021, Alcides Flores Pineda wrote:
> Hello Per:
>
> I have closed the old pull-request !30 (AKA merge-request in GitLab) and
> created a new one with the clean changes (!31).
>
> * https://gitlab.com/kashell/Kawa/-/merge_requests/31
>
> This doesn't include the documentation file `doc/kawa.texi`.
>
> Greetings.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Add SRFI-197 Implementation for Kawa
2021-04-30 16:36 ` Alcides Flores Pineda
@ 2021-04-30 20:23 ` Per Bothner
0 siblings, 0 replies; 8+ messages in thread
From: Per Bothner @ 2021-04-30 20:23 UTC (permalink / raw)
To: Alcides Flores Pineda; +Cc: Kawa Community
On 4/30/21 9:36 AM, Alcides Flores Pineda wrote:
> I finally managed to update the documentation file and added srfi-197 to
> the list of implemented SRFIs.
>
> Here is the pull-request !32 with the added lines.
>
> * https://gitlab.com/kashell/Kawa/-/merge_requests/32
Thanks. Merged.
--
--Per Bothner
per@bothner.com http://per.bothner.com/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Add SRFI-197 Implementation for Kawa
@ 2021-03-06 9:15 Alcides Flores Pineda
0 siblings, 0 replies; 8+ messages in thread
From: Alcides Flores Pineda @ 2021-03-06 9:15 UTC (permalink / raw)
To: Kawa Mailing List
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
*Hello everybody:*
I hope you are all fine and in good health.
After being searching for something like the "threading-macros" that
exist in a couple of Lisp dialects out there, I finally managed to
add/integrate a syntax-case implementation of SRFI-197 for Kawa as it is
shown in the reference implementation.
* https://github.com/ar-nelson/srfi-197
* https://srfi.schemers.org/srfi-197/srfi-197.html
I have already opened a merge request with the changes in GitLab, and
also by this means I'm sending the patch with the changes, if some of you
want to test/review/use the SRFI implementation integrated in the Kawa
source tree.
Although I've been a Kawa user/enthusiast for some years, nevertheless
this is my very first attempt to contribute to the source code, so I
guess peer review is required.
Thank you in advance.
*Greetings.-- Alcides Flores Pineda.*
[-- Attachment #2: add-srfi-197.patch.gz --]
[-- Type: application/gzip, Size: 9154 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-30 20:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-06 9:04 Add SRFI-197 Implementation for Kawa Alcides Flores Pineda
2021-03-06 19:11 ` Per Bothner
2021-03-06 21:50 ` Alcides Flores Pineda
2021-03-07 2:37 ` Per Bothner
2021-03-07 22:12 ` Alcides Flores Pineda
2021-04-30 16:36 ` Alcides Flores Pineda
2021-04-30 20:23 ` Per Bothner
2021-03-06 9:15 Alcides Flores Pineda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).