public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/mirror.c Date: Fri, 10 Nov 2006 19:35:00 -0000 [thread overview] Message-ID: <20061110193504.11580.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2006-11-10 19:35:03 Modified files: . : WHATS_NEW lib/metadata : mirror.c Log message: Fix adjusted_mirror_region_size() for 64-bit size. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.492&r2=1.493 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35 --- LVM2/WHATS_NEW 2006/11/10 18:24:11 1.492 +++ LVM2/WHATS_NEW 2006/11/10 19:35:02 1.493 @@ -1,6 +1,7 @@ Version 2.02.14 - =================================== - Add some missing bounds checks on 32 bit extent counters. + Fix adjusted_mirror_region_size() to handle 64-bit size. + Add some missing bounds checks on 32-bit extent counters. Add Petabyte and Exabyte support. Fix lvcreate error message when 0 extents requested. lvremove man page: volumes must be cluster inactive before being removed. --- LVM2/lib/metadata/mirror.c 2006/10/18 18:01:52 1.34 +++ LVM2/lib/metadata/mirror.c 2006/11/10 19:35:03 1.35 @@ -36,20 +36,20 @@ } /* - * Ensure region size is compatible with volume size. + * Reduce the region size if necessary to ensure + * the volume size is a multiple of the region size. */ uint32_t adjusted_mirror_region_size(uint32_t extent_size, uint32_t extents, uint32_t region_size) { - uint32_t region_max; + uint64_t region_max; region_max = (1 << (ffs((int)extents) - 1)) * extent_size; - if (region_max < region_size) { - region_size = region_max; + if (region_max < UINT32_MAX && region_size > region_max) { + region_size = (uint32_t) region_max; log_print("Using reduced mirror region size of %" PRIu32 - " sectors", region_max); - return region_max; + " sectors", region_size); } return region_size;
next reply other threads:[~2006-11-10 19:35 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-11-10 19:35 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 16:28 mbroz 2012-02-01 13:50 zkabelac 2011-10-25 13:17 jbrassow 2011-10-06 14:49 jbrassow 2011-09-14 2:45 jbrassow 2011-09-13 21:13 jbrassow 2011-09-13 14:37 jbrassow 2011-09-13 13:59 jbrassow 2011-09-01 19:22 jbrassow 2011-06-17 14:27 zkabelac 2010-08-16 18:02 jbrassow 2010-07-13 22:24 jbrassow 2010-07-13 21:48 jbrassow 2010-07-09 15:08 jbrassow 2010-06-28 14:19 jbrassow 2010-06-21 16:12 jbrassow 2010-04-27 15:27 jbrassow 2010-04-27 14:57 jbrassow 2009-12-09 19:53 mbroz 2009-12-09 18:09 mbroz 2009-04-10 9:53 mbroz 2008-10-17 10:50 agk 2008-09-18 19:09 agk 2008-06-13 12:15 meyering 2008-02-22 13:28 agk 2007-11-22 13:57 agk 2006-11-30 17:52 agk 2006-07-20 20:37 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20061110193504.11580.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).