public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: jbrassow@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/metadata/mirror.c Date: Mon, 28 Jun 2010 14:19:00 -0000 [thread overview] Message-ID: <20100628141953.3420.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: jbrassow@sourceware.org 2010-06-28 14:19:46 Modified files: . : WHATS_NEW lib/metadata : mirror.c Log message: Fix for bz608048 from Taka... The same region size is used for both mirror volume and mirrored log volume, but when the physical extent size is bigger than region size, the size of mirror leg for mirrored log is smaller than the region size and lvcreate command fails. This patch adjusts a region size of mirrored log to a smaller value of region size or physical extent size. [This patch ensures that the region_size of the mirrored log does not exceed the size of the mirrored log itself, which would violate the kernel constraint: (region_size <= ti->len).] Signed-off-by: Takahiro Yasui <takahiro.yasui@hds.com> Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1637&r2=1.1638 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.120&r2=1.121 --- LVM2/WHATS_NEW 2010/06/25 18:17:38 1.1637 +++ LVM2/WHATS_NEW 2010/06/28 14:19:41 1.1638 @@ -1,5 +1,6 @@ Version 2.02.69 - ================================ + Ensure region_size of mirrored log does not exceed its full size. Generate liblvm2app and libdevmapper exported symbols from header file. Preload libc locale messages to prevent reading it in memory locked state. Fix handling of simultaneous mirror image and mirrored log image failure. --- LVM2/lib/metadata/mirror.c 2010/06/23 13:57:26 1.120 +++ LVM2/lib/metadata/mirror.c 2010/06/28 14:19:45 1.121 @@ -1816,7 +1816,9 @@ * create and initialize mirror log */ if (log_count && - !(log_lv = _set_up_mirror_log(cmd, ah, lv, log_count, region_size, + !(log_lv = _set_up_mirror_log(cmd, ah, lv, log_count, + (region_size > lv->vg->extent_size) ? + lv->vg->extent_size : region_size, alloc, mirror_in_sync()))) { stack; goto out_remove_images;
next reply other threads:[~2010-06-28 14:19 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-06-28 14:19 jbrassow [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-23 16:28 mbroz 2012-02-01 13:50 zkabelac 2011-10-25 13:17 jbrassow 2011-10-06 14:49 jbrassow 2011-09-14 2:45 jbrassow 2011-09-13 21:13 jbrassow 2011-09-13 14:37 jbrassow 2011-09-13 13:59 jbrassow 2011-09-01 19:22 jbrassow 2011-06-17 14:27 zkabelac 2010-08-16 18:02 jbrassow 2010-07-13 22:24 jbrassow 2010-07-13 21:48 jbrassow 2010-07-09 15:08 jbrassow 2010-06-21 16:12 jbrassow 2010-04-27 15:27 jbrassow 2010-04-27 14:57 jbrassow 2009-12-09 19:53 mbroz 2009-12-09 18:09 mbroz 2009-04-10 9:53 mbroz 2008-10-17 10:50 agk 2008-09-18 19:09 agk 2008-06-13 12:15 meyering 2008-02-22 13:28 agk 2007-11-22 13:57 agk 2006-11-30 17:52 agk 2006-11-10 19:35 agk 2006-07-20 20:37 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100628141953.3420.qmail@sourceware.org \ --to=jbrassow@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).