From: Lillian Angel <langel@redhat.com>
To: "Steve McKay☄" <smckay@google.com>
Cc: Thomas Fitzsimmons <fitzsim@redhat.com>,
David Herron <David.Herron@sun.com>,
mauve-discuss@sources.redhat.com,
Dan Kegel <dkegel@google.com>
Subject: Re: Tweaking default java.awt.Robot settings
Date: Thu, 04 Oct 2007 13:04:00 -0000 [thread overview]
Message-ID: <4704E4DA.90900@redhat.com> (raw)
In-Reply-To: <4f2ee4520710031742u7a569385j60bf46067be98359@mail.gmail.com>
Looks good, I tested it out and committed it for you:
2007-10-03 Steve McKay <smckay@google.com>
* gnu/testlet/java/awt/Component/keyPressTest.java: Fixed test so
event is not created and dispatched. Completely waits for the
frame to
receive and respond keypress events.
Lillian
Steve McKayâ wrote:
> Here's a patch for the test. Everything seems to be working well. I
> haven't looked through the other tests yet to see how this might be
> shared.
>
> --steve
>
> On 9/25/07, Steve McKayâ <smckay@google.com> wrote:
>
>> Thomas,
>>
>>
>>> Even after you've ensured that the frame has responded, subsequent checks will
>>> still need to be synchronized, since Robot calls are not synchronous.
>>>
>> That was just a code snippet to demonstrate how to solve one part of
>> the problem. The code that does the actual testing is synchronized on
>> the lock as well. But like I said, there were liveness issues. I'll
>> try to work those out. Still, I can't honestly say that I'd want to go
>> through the same amount of effort for every test involving Robot, so
>> this change is sorta speculative rather than practical.
>>
>> --
>> Steve McKay <smckay@google.com>
>>
>>
>
>
>
next prev parent reply other threads:[~2007-10-04 13:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 20:31 Steve McKay☄
2007-09-24 20:50 ` David Herron
2007-09-24 21:22 ` Steve McKay☄
2007-09-24 21:41 ` David Herron
2007-09-25 18:33 ` Lillian Angel
2007-09-25 19:13 ` Steve McKay☄
2007-09-25 19:27 ` Lillian Angel
2007-09-25 19:37 ` Steve McKay☄
2007-09-25 19:45 ` Lillian Angel
2007-09-25 19:27 ` David Herron
2007-09-25 18:33 ` Thomas Fitzsimmons
2007-09-25 18:57 ` Steve McKay☄
2007-09-25 19:58 ` Thomas Fitzsimmons
2007-09-25 20:28 ` Steve McKay☄
2007-10-04 0:43 ` Steve McKay☄
2007-10-04 13:04 ` Lillian Angel [this message]
2007-09-25 19:24 ` David Herron
2007-09-25 18:10 ` Thomas Fitzsimmons
2007-09-25 18:14 ` Steve McKay☄
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4704E4DA.90900@redhat.com \
--to=langel@redhat.com \
--cc=David.Herron@sun.com \
--cc=dkegel@google.com \
--cc=fitzsim@redhat.com \
--cc=mauve-discuss@sources.redhat.com \
--cc=smckay@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).