Re: [PATCH v6 3/7] ppc/svp64: support setvl instructions

[lkcl <luke.leighton@gmail.com>]

On Sun, Aug 21, 2022 at 3:53 PM Jan Beulich <jbeulich@suse.com> wrote:
> On 15.08.2022 14:58, lkcl wrote:
> > ah appreciated, i've added examples.  more will be needed now that
> > there's also setvl-from-CTR as well.
>
> Since you've added the further examples without altering the first
> register operand for the expansion of setvli - is that really meant
> to be r5, not r0?

well-spotted: the addition of the CTR mode post-dates the creation
of those pseudo-ops, i've now corrected them.  it is slightly irksome
that the cost of adding CTR mode was at the expense of losing the
ability to set RT to an immediate, but this may be achieved with
addi RT,0,#N. go figure.

> Is there any preferred way for providing feedback, just in case I
> would spot further little issues? I've responded to the patches
> to binutils mainly because I didn't know anything "better" ...

appreciated. in order of approx precedence (coincidentally,
reverse-convenience):

* directly on the bugtracker bugs.libre-soc.org although contact
  me privately about that, i had to disable account-creation after
  someone used the bugtracker to advertise juniper networks at us
* the mailing list (mailman: i can authorise sending permission if
   you prefer not to subscribe: i.e. just send, and i'll deal with it)
   https://lists.libre-soc.org/mailman/listinfo/libre-soc-dev
* IRC - libera.chat - #libre-soc channel: if you prefer there is a
   Matrix Bridge (run by the libera team) and yet _another_ way
   is via the OPF's mattermost bridge
   https://chat.openpower.foundation/opf/channels/libre-soc
   all messages are logged  https://libre-soc.org/irclog/index.html

as we're under Audit Conditions (EU Funding, NLnet "works for
public good") everything is logged/public, but obviously if you're
used to FOSS then nothing's new :)

l.