public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@sifive.com>
To: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com,
	patrick@rivosinc.com,  vineetg@rivosinc.com,
	jlaw@ventanamicro.com
Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp
Date: Mon, 22 May 2023 17:17:47 +0800	[thread overview]
Message-ID: <CALLt3ThLXA_2w==K1VQXH2ueqeha1Ah4s+N0u1r-jWjjzDJrOw@mail.gmail.com> (raw)
In-Reply-To: <20230522064138.74056-1-kito.cheng@sifive.com>

Ooops, seems still some issue around here, but I found something might
related this issue:

https://github.com/gcc-mirror/gcc/commit/d6654a4be3ba44c0d57be7c8a51d76d9721345e1
https://github.com/gcc-mirror/gcc/commit/23c49bb8d09bc3bfce9a08be637cf32ac014de56

On Mon, May 22, 2023 at 2:42 PM Kito Cheng <kito.cheng@sifive.com> wrote:
>
> Hi Vineet:
>
> Could you help to test this patch, this could resolve that issue on our
> machine, but I would like to also work for other env.
>
> Thanks :)
>
> ---
>
> We got bunch of following error message for multi-lib run:
>
> ERROR: torture-init: torture_without_loops is not empty as expected
> ERROR: tcl error code NONE
>
> And seems we need torture-init and torture-finish around the test
> loop.
>
> gcc/testsuite/ChangeLog:
>
>         * gcc.target/riscv/rvv/rvv.exp: Add torture-init and
>         torture-finish.
> ---
>  gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> index bc99cc0c3cf4..19179564361a 100644
> --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> @@ -39,6 +39,7 @@ if [istarget riscv32-*-*] then {
>
>  # Initialize `dg'.
>  dg-init
> +torture-init
>
>  # Main loop.
>  set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3"
> @@ -69,5 +70,7 @@ foreach op $AUTOVEC_TEST_OPTS {
>  dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/autovec/vls-vlmax/*.\[cS\]]] \
>         "-std=c99 -O3 -ftree-vectorize --param riscv-autovec-preference=fixed-vlmax" $CFLAGS
>
> +torture-finish
> +
>  # All done.
>  dg-finish
> --
> 2.40.1
>

  reply	other threads:[~2023-05-22  9:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22  6:41 Kito Cheng
2023-05-22  9:17 ` Kito Cheng [this message]
2023-05-23  3:52   ` Vineet Gupta
2023-05-24 18:18     ` Vineet Gupta
2023-05-24 20:34       ` Thomas Schwinge
2023-05-24 22:13         ` Vineet Gupta
2023-05-24 23:12           ` Vineet Gupta
2023-05-24 23:13             ` Palmer Dabbelt
2023-05-25  3:43               ` RISC-V Bootstrap problems Jeff Law
2023-05-25  3:46                 ` juzhe.zhong
2023-05-25  3:53                   ` Kito Cheng
2023-05-25  3:54                     ` juzhe.zhong
2023-05-25  4:07                       ` Jeff Law
2023-05-25  4:19                         ` juzhe.zhong
2023-05-25 13:55                           ` Jeff Law
2023-05-25  4:06                     ` Jeff Law
2023-05-25  4:08                       ` Kito Cheng
2023-05-25  3:51                 ` juzhe.zhong
2023-05-24 23:15             ` [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp Jeff Law
2023-05-25 20:26             ` Thomas Schwinge
2023-05-26 23:38               ` Vineet Gupta
2023-05-30 18:43                 ` Vineet Gupta
2023-05-31 16:28                   ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLt3ThLXA_2w==K1VQXH2ueqeha1Ah4s+N0u1r-jWjjzDJrOw@mail.gmail.com' \
    --to=kito.cheng@sifive.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jlaw@ventanamicro.com \
    --cc=kito.cheng@gmail.com \
    --cc=patrick@rivosinc.com \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).