Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp

[Palmer Dabbelt <palmer@dabbelt.com>]

On Wed, 24 May 2023 16:12:20 PDT (-0700), Vineet Gupta wrote:
>
>
> On 5/24/23 15:13, Vineet Gupta wrote:
>>
>> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects  (test for excess errors)
>> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects   scan-assembler-times mul\t 1
>> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects   scan-assembler-not div\t
>> PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects   scan-assembler-not rem\t
>> testcase
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/riscv.exp
>> completed in 60 seconds
>> Running
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>> ...
>> ERROR: tcl error sourcing
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp.
>> ERROR: tcl error code NONE
>> ERROR: torture-init: torture_without_loops is not empty as expected
>>     while executing
>> "error "torture-init: torture_without_loops is not empty as expected""
>>     invoked from within
>> "if [info exists torture_without_loops] {
>>     error "torture-init: torture_without_loops is not empty as expected"
>>     }"
>>     (procedure "torture-init" line 4)
>>     invoked from within
>> "torture-init"
>>     (file
>> "/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"
>> line 42)
>>     invoked from within
>> "source
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"
>>     ("uplevel" body line 1)
>>     invoked from within
>> "uplevel #0 source
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"
>>     invoked from within
>> "catch "uplevel #0 source $test_file_name" msg"
>> UNRESOLVED: testcase
>> '/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp'
>> aborted due to Tcl error
>> testcase
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>> completed in 0 seconds
>> Running
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/rl78/rl78.exp
>> ...
>> ...
>>
>
> Never mind. Looks like I found the issue - with just trial and error and
> no idea of how this stuff works.
> The torture-{init,finish} needs to be in riscv.exp not rvv.exp
> Running full tests now.

Thanks!

>
> -Vineet