From: Thomas Schwinge <thomas.schwinge@siemens.com>
To: Vineet Gupta <vineetg@rivosinc.com>, Kito Cheng <kito.cheng@sifive.com>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com,
patrick@rivosinc.com, jlaw@ventanamicro.com,
"Maciej W . Rozycki" <macro@embecosm.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp
Date: Thu, 25 May 2023 22:26:49 +0200 [thread overview]
Message-ID: <87sfbkqhrq.fsf@dem-tschwing-1.ger.mentorg.com> (raw)
In-Reply-To: <5070d049-f3ee-e175-4bad-21cd2528e42b@rivosinc.com>
Hi!
On 2023-05-24T15:13:19-0700, Vineet Gupta <vineetg@rivosinc.com> wrote:
> On 5/24/23 13:34, Thomas Schwinge wrote:
>> Yeah, at this point I'm not sure whether my recent changes really are
>> related/relevant here.
>>
>>> Apparently in addition to Kito's patch below, If I comment out the
>>> additional torture options, failures go down drastically.
>> Meaning that *all* those ERRORs disappear?
>
> No but they reduced significantly. Anyhow I think the issue should be
> simple enough for someone familiar with how the tcl stuff works...
I'm here to help -- but you'll have to help me to help you, please.
>>> diff --git a/gcc/testsuite/gcc.target/riscv/riscv.exp
>>> b/gcc/testsuite/gcc.target/riscv/riscv.exp
>>>
>>> -lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz}
>>> +#lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz}
>>>
>>> @Thomas, do you have some thoughts on how to fix riscv.exp properly in
>>> light of recent changes to exp files.
>> I'm trying to understand this, but so far don't. Can I please see a
>> complete 'gcc.log' file where the ERRORs are visible?
> So we are at bleeding edge gcc from today
> 2023-05-24 ec2e86274427 Fortran: reject bad DIM argument of SIZE
> intrinsic in simplification [PR104350]
>
> With an additional fix from Kito along the lines of..
>
> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
> b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>
> dg-init
> +torture-init
>
> # All done.
> +torture-finish
> dg-finish
That shouldn't be necessary here?
> I'm pasting a snippet of gcc.log. Issue is indeed triggered by rvv.exp
> which needs some love.
I'd intentionally asked to "see a complete 'gcc.log' file where the
ERRORs are visible".
On 2023-05-24T16:12:20-0700, Vineet Gupta <vineetg@rivosinc.com> wrote:
> On 5/24/23 15:13, Vineet Gupta wrote:
>>
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects (test for excess errors)
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects scan-assembler-times mul\t 1
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects scan-assembler-not div\t
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects scan-assembler-not rem\t
>> testcase
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/riscv.exp
>> completed in 60 seconds
>> Running
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>> ...
>> ERROR: tcl error sourcing
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp.
>> ERROR: tcl error code NONE
>> ERROR: torture-init: torture_without_loops is not empty as expected
I'd seen this before, in your earlier emails.
> Never mind. Looks like I found the issue - with just trial and error and
> no idea of how this stuff works.
Instead of "magic", let's please try to properly work this out.
> The torture-{init,finish} needs to be in riscv.exp not rvv.exp
> Running full tests now.
I still don't understand this.
My current theory would be that some other '*.exp' file runs
'torture-init' and then prematurely ends without 'torture-finish', and
thus the torture testing state bleeds into the next '*.exp' file(s). I'd
hoped that I could pinpoint that via "a complete 'gcc.log' file where the
ERRORs are visible".
Grüße
Thomas
next prev parent reply other threads:[~2023-05-25 20:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 6:41 Kito Cheng
2023-05-22 9:17 ` Kito Cheng
2023-05-23 3:52 ` Vineet Gupta
2023-05-24 18:18 ` Vineet Gupta
2023-05-24 20:34 ` Thomas Schwinge
2023-05-24 22:13 ` Vineet Gupta
2023-05-24 23:12 ` Vineet Gupta
2023-05-24 23:13 ` Palmer Dabbelt
2023-05-25 3:43 ` RISC-V Bootstrap problems Jeff Law
2023-05-25 3:46 ` juzhe.zhong
2023-05-25 3:53 ` Kito Cheng
2023-05-25 3:54 ` juzhe.zhong
2023-05-25 4:07 ` Jeff Law
2023-05-25 4:19 ` juzhe.zhong
2023-05-25 13:55 ` Jeff Law
2023-05-25 4:06 ` Jeff Law
2023-05-25 4:08 ` Kito Cheng
2023-05-25 3:51 ` juzhe.zhong
2023-05-24 23:15 ` [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp Jeff Law
2023-05-25 20:26 ` Thomas Schwinge [this message]
2023-05-26 23:38 ` Vineet Gupta
2023-05-30 18:43 ` Vineet Gupta
2023-05-31 16:28 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfbkqhrq.fsf@dem-tschwing-1.ger.mentorg.com \
--to=thomas.schwinge@siemens.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=macro@embecosm.com \
--cc=palmer@dabbelt.com \
--cc=patrick@rivosinc.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).