From: Jeff Law <jlaw@ventanamicro.com>
To: Vineet Gupta <vineetg@rivosinc.com>,
Thomas Schwinge <thomas.schwinge@siemens.com>,
Kito Cheng <kito.cheng@sifive.com>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com,
patrick@rivosinc.com, "Maciej W . Rozycki" <macro@embecosm.com>
Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp
Date: Wed, 24 May 2023 17:15:11 -0600 [thread overview]
Message-ID: <a258ccc5-7b5b-503b-b5eb-6afcf58ac97c@ventanamicro.com> (raw)
In-Reply-To: <5070d049-f3ee-e175-4bad-21cd2528e42b@rivosinc.com>
On 5/24/23 17:12, Vineet Gupta wrote:
>
>
> On 5/24/23 15:13, Vineet Gupta wrote:
>>
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects (test for excess errors)
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects scan-assembler-times mul\t 1
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects scan-assembler-not div\t
>> PASS: gcc.target/riscv/zmmul-2.c -O2 -flto -fuse-linker-plugin
>> -fno-fat-lto-objects scan-assembler-not rem\t
>> testcase
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/riscv.exp completed in 60 seconds
>> Running
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp ...
>> ERROR: tcl error sourcing
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp.
>> ERROR: tcl error code NONE
>> ERROR: torture-init: torture_without_loops is not empty as expected
>> while executing
>> "error "torture-init: torture_without_loops is not empty as expected""
>> invoked from within
>> "if [info exists torture_without_loops] {
>> error "torture-init: torture_without_loops is not empty as expected"
>> }"
>> (procedure "torture-init" line 4)
>> invoked from within
>> "torture-init"
>> (file
>> "/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp" line 42)
>> invoked from within
>> "source
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"
>> ("uplevel" body line 1)
>> invoked from within
>> "uplevel #0 source
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"
>> invoked from within
>> "catch "uplevel #0 source $test_file_name" msg"
>> UNRESOLVED: testcase
>> '/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp' aborted due to Tcl error
>> testcase
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp completed in 0 seconds
>> Running
>> /scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/rl78/rl78.exp ...
>> ...
>>
>
> Never mind. Looks like I found the issue - with just trial and error and
> no idea of how this stuff works.
> The torture-{init,finish} needs to be in riscv.exp not rvv.exp
> Running full tests now.
Trial and error is how I think most of us deal with the TCL insanity.
I have found send_user (aka printf debugging) to be quite helpful
through the years. There's also verbosity and trace options, but they
can be painfully hard to interpret.
jeff
next prev parent reply other threads:[~2023-05-24 23:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 6:41 Kito Cheng
2023-05-22 9:17 ` Kito Cheng
2023-05-23 3:52 ` Vineet Gupta
2023-05-24 18:18 ` Vineet Gupta
2023-05-24 20:34 ` Thomas Schwinge
2023-05-24 22:13 ` Vineet Gupta
2023-05-24 23:12 ` Vineet Gupta
2023-05-24 23:13 ` Palmer Dabbelt
2023-05-25 3:43 ` RISC-V Bootstrap problems Jeff Law
2023-05-25 3:46 ` juzhe.zhong
2023-05-25 3:53 ` Kito Cheng
2023-05-25 3:54 ` juzhe.zhong
2023-05-25 4:07 ` Jeff Law
2023-05-25 4:19 ` juzhe.zhong
2023-05-25 13:55 ` Jeff Law
2023-05-25 4:06 ` Jeff Law
2023-05-25 4:08 ` Kito Cheng
2023-05-25 3:51 ` juzhe.zhong
2023-05-24 23:15 ` Jeff Law [this message]
2023-05-25 20:26 ` [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp Thomas Schwinge
2023-05-26 23:38 ` Vineet Gupta
2023-05-30 18:43 ` Vineet Gupta
2023-05-31 16:28 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a258ccc5-7b5b-503b-b5eb-6afcf58ac97c@ventanamicro.com \
--to=jlaw@ventanamicro.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=macro@embecosm.com \
--cc=patrick@rivosinc.com \
--cc=thomas.schwinge@siemens.com \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).