Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp

[Vineet Gupta <vineetg@rivosinc.com>]

On 5/24/23 13:34, Thomas Schwinge wrote:
> Yeah, at this point I'm not sure whether my recent changes really are
> related/relevant here.
>
>> Apparently in addition to Kito's patch below, If I comment out the
>> additional torture options, failures go down drastically.
> Meaning that *all* those ERRORs disappear?

No but they reduced significantly. Anyhow I think the issue should be 
simple enough for someone familiar with how the tcl stuff works...

>
>> diff --git a/gcc/testsuite/gcc.target/riscv/riscv.exp
>> b/gcc/testsuite/gcc.target/riscv/riscv.exp
>>
>> -lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz}
>> +#lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz}
>>
>> @Thomas, do you have some thoughts on how to fix riscv.exp properly in
>> light of recent changes to exp files.
> I'm trying to understand this, but so far don't.  Can I please see a
> complete 'gcc.log' file where the ERRORs are visible?

So we are at bleeding edge gcc from today
      2023-05-24 ec2e86274427 Fortran: reject bad DIM argument of SIZE 
intrinsic in simplification [PR104350]

With an additional fix from Kito along the lines of..

diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp 
b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp

  dg-init
+torture-init

  # All done.
+torture-finish
  dg-finish

I'm pasting a snippet of gcc.log. Issue is indeed triggered by rvv.exp 
which needs some love.


PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin 
-fno-fat-lto-objects  (test for excess errors)
PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin 
-fno-fat-lto-objects   scan-assembler-times mul\t 1
PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin 
-fno-fat-lto-objects   scan-assembler-not div\t
PASS: gcc.target/riscv/zmmul-2.c   -O2 -flto -fuse-linker-plugin 
-fno-fat-lto-objects   scan-assembler-not rem\t
testcase 
/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/riscv.exp 
completed in 60 seconds
Running 
/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp 
...
ERROR: tcl error sourcing 
/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp.
ERROR: tcl error code NONE
ERROR: torture-init: torture_without_loops is not empty as expected
     while executing
"error "torture-init: torture_without_loops is not empty as expected""
     invoked from within
"if [info exists torture_without_loops] {
     error "torture-init: torture_without_loops is not empty as expected"
     }"
     (procedure "torture-init" line 4)
     invoked from within
"torture-init"
     (file 
"/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp" 
line 42)
     invoked from within
"source 
/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"
     ("uplevel" body line 1)
     invoked from within
"uplevel #0 source 
/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp"
     invoked from within
"catch "uplevel #0 source $test_file_name" msg"
UNRESOLVED: testcase 
'/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp' 
aborted due to Tcl error
testcase 
/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp 
completed in 0 seconds
Running 
/scratch/vineetg/gnu/toolchain-upstream/gcc/gcc/testsuite/gcc.target/rl78/rl78.exp 
...
...