From: "Paul Edwards" <mutazilah@gmail.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: <gcc@gcc.gnu.org>
Subject: Re: i370 port
Date: Sat, 07 Apr 2012 04:12:00 -0000 [thread overview]
Message-ID: <A2B09373823448AC993BC6BA123FE257@PaulHP> (raw)
In-Reply-To: <201204061815.q36IFjJ4021718@d06av02.portsmouth.uk.ibm.com>
> Ah, yes. The problem is that reload assumes any valid address
> can be loaded into a register with a single instruction, and
> it will thus simply generate such instructions unconditionally
> -- and if the target then doesn't actually provide such a pattern,
> it will fail with "unrecognizable insn".
Hi Ulrich. Thanks for your reply.
This approach seems to be quite complicated. What do you think
about the option of NOT adding this (which triggers off errors I
hadn't seen before):
#define EXTRA_MEMORY_CONSTRAINT(C, STR) \
((C) == 'S')
and instead making a change similar to what I have already put in
under "hack" below? Is that legitimate?
;
; movstrsi instruction pattern(s).
; block must be less than 16M (24 bits) in length
(define_expand "movstrsi"
[(set (match_operand:BLK 0 "general_operand" "")
(match_operand:BLK 1 "general_operand" ""))
(use (match_operand:SI 2 "general_operand" ""))
(match_operand 3 "" "")]
""
"
{
rtx op0, op1;
op0 = XEXP (operands[0], 0);
if (GET_CODE (op0) == REG
|| (GET_CODE (op0) == PLUS && GET_CODE (XEXP (op0, 0)) == REG
&& GET_CODE (XEXP (op0, 1)) == CONST_INT
&& (unsigned) INTVAL (XEXP (op0, 1)) < 4096))
op0 = operands[0];
else
op0 = replace_equiv_address (operands[0], copy_to_mode_reg (SImode,
op0));
op1 = XEXP (operands[1], 0);
if (GET_CODE (op1) == REG
|| (GET_CODE (op1) == PLUS && GET_CODE (XEXP (op1, 0)) == REG
&& GET_CODE (XEXP (op1, 1)) == CONST_INT
&& (unsigned) INTVAL (XEXP (op1, 1)) < 4096))
op1 = operands[1];
else
op1 = replace_equiv_address (operands[1], copy_to_mode_reg (SImode,
op1));
/* first line is a hack - if target address involves two registers,
we can't use an MVC, even if the length to move is less than 256,
because MVC takes an S parameter. I'm unsure of the best way to
distinguish a two-register target. */
if (!((GET_CODE(op0) == MEM) && REG_P(XEXP(op0,0))) &&
GET_CODE (operands[2]) == CONST_INT && INTVAL (operands[2]) < 256)
emit_insn (gen_rtx_PARALLEL (VOIDmode,
gen_rtvec (2,
gen_rtx_SET (VOIDmode, op0, op1),
gen_rtx_USE (VOIDmode, operands[2]))));
else
{
/* implementation provided by Richard Henderson <rth@cygnus.com> */
rtx reg1 = gen_reg_rtx (DImode);
rtx reg2 = gen_reg_rtx (DImode);
rtx mem1 = operands[0];
rtx mem2 = operands[1];
rtx len = operands[2];
if (!CONSTANT_P (len))
len = force_reg (SImode, len);
/* Load up the address+length pairs. */
emit_insn (gen_rtx_CLOBBER (VOIDmode, reg1));
emit_move_insn (gen_rtx_SUBREG (SImode, reg1, 0),
force_operand (XEXP (mem1, 0), NULL_RTX));
emit_move_insn (gen_rtx_SUBREG (SImode, reg1, GET_MODE_SIZE
(SImode)), len);
emit_insn (gen_rtx_CLOBBER (VOIDmode, reg2));
emit_move_insn (gen_rtx_SUBREG (SImode, reg2, 0),
force_operand (XEXP (mem2, 0), NULL_RTX));
emit_move_insn (gen_rtx_SUBREG (SImode, reg2, GET_MODE_SIZE
(SImode)), len);
/* Copy! */
emit_insn (gen_movstrsi_1 (reg1, reg2));
}
DONE;
}")
Thanks. Paul.
next prev parent reply other threads:[~2012-04-07 4:12 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 12:49 Paul Edwards
2012-04-06 18:16 ` Ulrich Weigand
2012-04-07 4:12 ` Paul Edwards [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-13 4:23 Paul Edwards
2012-04-07 5:45 Paul Edwards
2012-04-08 17:43 ` Ulrich Weigand
2014-02-11 17:01 ` Paul Edwards
2012-04-06 5:51 Paul Edwards
2011-08-20 12:15 Paul Edwards
2011-08-22 12:23 ` Ulrich Weigand
2012-04-05 13:32 ` Paul Edwards
2012-04-06 18:13 ` Ulrich Weigand
2011-08-20 10:09 Paul Edwards
2011-08-20 7:44 Paul Edwards
2009-09-22 12:31 Paul Edwards
2009-09-09 22:33 Paul Edwards
2009-09-14 15:42 ` Ulrich Weigand
2009-09-15 12:59 ` Paul Edwards
2009-09-15 13:51 ` Ulrich Weigand
2009-09-17 13:00 ` Paul Edwards
2009-09-17 17:55 ` Ulrich Weigand
2009-09-18 0:35 ` Paul Edwards
2009-09-18 12:06 ` Ulrich Weigand
2009-09-18 12:23 ` Paul Edwards
2009-09-18 13:27 ` Ulrich Weigand
2009-09-18 13:42 ` Paul Edwards
2009-09-18 16:08 ` Ulrich Weigand
2009-09-19 12:57 ` Paul Edwards
2009-09-25 10:19 ` Paul Edwards
2009-09-25 15:20 ` Ulrich Weigand
2009-11-04 5:21 ` Paul Edwards
2009-11-04 16:47 ` Ulrich Weigand
2009-11-09 14:55 ` Paul Edwards
2009-11-09 15:57 ` Ian Lance Taylor
2009-11-09 23:10 ` Paul Edwards
2009-11-10 14:58 ` Paul Edwards
2009-11-10 15:36 ` Ian Lance Taylor
2009-11-10 15:51 ` Paul Edwards
2009-11-10 15:56 ` Ian Lance Taylor
2009-12-02 22:03 ` Paul Edwards
2011-08-13 8:34 ` Paul Edwards
2011-08-15 14:32 ` Ulrich Weigand
2011-08-15 15:26 ` Paul Edwards
2011-08-15 17:23 ` Ulrich Weigand
2011-08-16 11:20 ` Paul Edwards
2011-08-16 13:26 ` Ulrich Weigand
2011-08-18 12:15 ` Paul Edwards
2011-08-18 13:14 ` Ulrich Weigand
2011-08-18 14:18 ` Paul Edwards
2009-08-23 8:50 Paul Edwards
2009-08-26 22:13 ` Henrik Sorensen
2009-06-05 12:45 Paul Edwards
2009-06-05 14:33 ` Joseph S. Myers
2009-06-05 14:57 ` Paul Edwards
2009-06-05 15:03 ` Joseph S. Myers
2009-06-05 15:24 ` Paul Edwards
2009-06-05 15:47 ` Joseph S. Myers
2017-03-31 10:34 ` Paul Edwards
2009-09-12 12:41 ` Paul Edwards
2009-06-05 15:21 ` Ulrich Weigand
2009-06-05 15:39 ` Paul Edwards
2009-06-05 15:49 ` Daniel Jacobowitz
2009-06-05 15:57 ` Paul Edwards
2009-06-05 20:20 ` Joseph S. Myers
2009-06-05 20:45 ` Paul Edwards
2009-06-06 15:00 ` Paul Edwards
2009-06-15 17:46 ` Ulrich Weigand
2009-06-19 0:06 ` Paul Edwards
2009-06-19 12:28 ` Ulrich Weigand
2009-07-18 11:28 ` Paul Edwards
2009-07-20 14:27 ` Ulrich Weigand
2009-08-08 12:04 ` Paul Edwards
2009-08-10 21:25 ` Ulrich Weigand
2009-08-11 0:34 ` Paul Edwards
2009-08-11 15:21 ` Ulrich Weigand
2009-08-12 11:52 ` Paul Edwards
2009-08-12 15:27 ` Paolo Bonzini
2009-08-12 16:35 ` Ulrich Weigand
2009-08-12 17:27 ` Paul Edwards
2009-08-12 17:56 ` Paolo Bonzini
2009-08-12 19:46 ` Ulrich Weigand
2009-08-12 20:31 ` Paul Edwards
2009-08-19 12:07 ` Paul Edwards
2009-08-19 12:27 ` Paolo Bonzini
2009-08-20 12:49 ` Paul Edwards
2009-08-20 22:48 ` Ulrich Weigand
2009-08-21 2:37 ` Paul Edwards
2009-08-21 16:46 ` Ulrich Weigand
2009-06-05 15:44 ` Joseph S. Myers
2009-06-05 15:52 ` Paul Edwards
2009-09-08 15:55 ` Paul Edwards
2009-09-14 15:32 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2B09373823448AC993BC6BA123FE257@PaulHP \
--to=mutazilah@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).