From: "Paul Edwards" <mutazilah@gmail.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>,
"Ulrich Weigand" <uweigand@de.ibm.com>
Cc: <gcc@gcc.gnu.org>
Subject: Re: i370 port
Date: Fri, 05 Jun 2009 15:52:00 -0000 [thread overview]
Message-ID: <174030E531584E68BF5743D433A6E16E@Paullaptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0906051541460.7321@digraph.polyomino.org.uk>
>> I understand current GCC supports various source and target character
>> sets a lot better out of the box, so it may be EBCDIC isn't even an
>> issue any more. If there are other problems related to MVS host
>
> I think the EBCDIC support is largely theoretical and not tested on any
> actual EBCDIC host (or target). cpplib knows the character set name
> UTF-EBCDIC, but whenever it does anything internally that involves the
> encoding of its internal character set it uses UTF-8 rules (which is not
> something valid to do with UTF-EBCDIC).
From the hercules-os380 files section, here's the relevant change
to 3.4.6 to stop it being theoretical:
Index: gccnew/gcc/cppcharset.c
diff -c gccnew/gcc/cppcharset.c:1.1.1.1 gccnew/gcc/cppcharset.c:1.6
*** gccnew/gcc/cppcharset.c:1.1.1.1 Wed Apr 15 16:26:16 2009
--- gccnew/gcc/cppcharset.c Wed May 13 11:07:08 2009
***************
*** 23,28 ****
--- 23,30 ----
#include "cpplib.h"
#include "cpphash.h"
#include "cppucnid.h"
+ #include "coretypes.h"
+ #include "tm.h"
/* Character set handling for C-family languages.
***************
*** 529,534 ****
--- 531,561 ----
return conversion_loop (one_utf32_to_utf8, cd, from, flen, to);
}
+ #ifdef MAP_OUTCHAR
+ /* convert ASCII to EBCDIC */
+ static bool
+ convert_asc_ebc (iconv_t cd ATTRIBUTE_UNUSED,
+ const uchar *from, size_t flen, struct _cpp_strbuf *to)
+ {
+ size_t x;
+ int c;
+
+ if (to->len + flen > to->asize)
+ {
+ to->asize = to->len + flen;
+ to->text = xrealloc (to->text, to->asize);
+ }
+ for (x = 0; x < flen; x++)
+ {
+ c = from[x];
+ c = MAP_OUTCHAR(c);
+ to->text[to->len + x] = c;
+ }
+ to->len += flen;
+ return true;
+ }
+ #endif
+
/* Identity conversion, used when we have no alternative. */
static bool
convert_no_conversion (iconv_t cd ATTRIBUTE_UNUSED,
***************
*** 606,611 ****
--- 633,641 ----
{ "UTF-32BE/UTF-8", convert_utf32_utf8, (iconv_t)1 },
{ "UTF-16LE/UTF-8", convert_utf16_utf8, (iconv_t)0 },
{ "UTF-16BE/UTF-8", convert_utf16_utf8, (iconv_t)1 },
+ #if defined(TARGET_EBCDIC)
+ { "UTF-8/UTF-EBCDIC", convert_asc_ebc, (iconv_t)0 },
+ #endif
};
/* Subroutine of cpp_init_iconv: initialize and return a
***************
*** 683,688 ****
--- 713,722 ----
bool be = CPP_OPTION (pfile, bytes_big_endian);
+ #if defined(TARGET_EBCDIC)
+ ncset = "UTF-EBCDIC";
+ wcset = "UTF-EBCDIC";
+ #else
if (CPP_OPTION (pfile, wchar_precision) >= 32)
default_wcset = be ? "UTF-32BE" : "UTF-32LE";
else if (CPP_OPTION (pfile, wchar_precision) >= 16)
***************
*** 696,701 ****
--- 730,736 ----
ncset = SOURCE_CHARSET;
if (!wcset)
wcset = default_wcset;
+ #endif
pfile->narrow_cset_desc = init_iconv_desc (pfile, ncset,
SOURCE_CHARSET);
pfile->wide_cset_desc = init_iconv_desc (pfile, wcset, SOURCE_CHARSET);
The generated code appears to be fine from visual inspection.
BFN. Paul.
next prev parent reply other threads:[~2009-06-05 15:52 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 12:45 Paul Edwards
2009-06-05 14:33 ` Joseph S. Myers
2009-06-05 14:57 ` Paul Edwards
2009-06-05 15:03 ` Joseph S. Myers
2009-06-05 15:24 ` Paul Edwards
2009-06-05 15:47 ` Joseph S. Myers
2009-09-11 17:35 ` i370 port - in search of hooks Paul Edwards
2017-03-31 10:34 ` i370 port Paul Edwards
2009-09-12 12:41 ` Paul Edwards
2009-06-05 15:21 ` Ulrich Weigand
2009-06-05 15:39 ` Paul Edwards
2009-06-05 15:49 ` Daniel Jacobowitz
2009-06-05 15:57 ` Paul Edwards
2009-06-05 20:20 ` Joseph S. Myers
2009-06-05 20:45 ` Paul Edwards
2009-06-06 15:00 ` Paul Edwards
2009-06-15 17:46 ` Ulrich Weigand
2009-06-19 0:06 ` Paul Edwards
2009-06-19 12:28 ` Ulrich Weigand
2009-07-18 11:28 ` Paul Edwards
2009-07-20 14:27 ` Ulrich Weigand
2009-08-08 12:04 ` Paul Edwards
2009-08-10 21:25 ` Ulrich Weigand
2009-08-11 0:34 ` Paul Edwards
2009-08-11 15:21 ` Ulrich Weigand
2009-08-12 11:52 ` Paul Edwards
2009-08-12 15:27 ` Paolo Bonzini
2009-08-12 16:35 ` Ulrich Weigand
2009-08-12 17:27 ` Paul Edwards
2009-08-12 17:56 ` Paolo Bonzini
2009-08-12 19:46 ` Ulrich Weigand
2009-08-12 20:31 ` Paul Edwards
2009-08-19 12:07 ` Paul Edwards
2009-08-19 12:27 ` Paolo Bonzini
2009-08-20 12:49 ` Paul Edwards
2009-08-20 22:48 ` Ulrich Weigand
2009-08-21 2:37 ` Paul Edwards
2009-08-21 16:46 ` Ulrich Weigand
2009-06-05 15:44 ` Joseph S. Myers
2009-06-05 15:52 ` Paul Edwards [this message]
2009-09-08 15:55 ` Paul Edwards
2009-09-14 15:32 ` Ulrich Weigand
2021-09-02 8:15 ` s390 port Paul Edwards
2021-09-02 14:34 ` Ulrich Weigand
2021-09-02 14:50 ` Paul Edwards
2021-09-02 14:53 ` Ulrich Weigand
2021-09-02 15:01 ` Paul Edwards
2021-09-02 15:13 ` Ulrich Weigand
2021-09-02 15:26 ` Paul Edwards
2021-09-02 19:46 ` Ulrich Weigand
2021-09-02 20:05 ` Paul Edwards
2021-09-02 20:16 ` Andreas Schwab
2021-09-03 11:18 ` Ulrich Weigand
2021-09-03 11:35 ` Paul Edwards
2021-09-03 12:12 ` Ulrich Weigand
2021-09-03 12:38 ` Paul Edwards
2021-09-03 12:53 ` Jakub Jelinek
2021-09-03 13:12 ` Paul Edwards
2022-12-20 4:27 ` Paul Edwards
2009-08-23 8:50 i370 port Paul Edwards
2009-08-26 22:13 ` Henrik Sorensen
2009-09-09 22:33 Paul Edwards
2009-09-14 15:42 ` Ulrich Weigand
2009-09-15 12:59 ` Paul Edwards
2009-09-15 13:51 ` Ulrich Weigand
2009-09-17 13:00 ` Paul Edwards
2009-09-17 17:55 ` Ulrich Weigand
2009-09-18 0:35 ` Paul Edwards
2009-09-18 12:06 ` Ulrich Weigand
2009-09-18 12:23 ` Paul Edwards
2009-09-18 13:27 ` Ulrich Weigand
2009-09-18 13:42 ` Paul Edwards
2009-09-18 16:08 ` Ulrich Weigand
2009-09-19 12:57 ` Paul Edwards
2009-09-25 10:19 ` Paul Edwards
2009-09-25 15:20 ` Ulrich Weigand
2009-11-04 5:21 ` Paul Edwards
2009-11-04 16:47 ` Ulrich Weigand
2009-11-09 14:55 ` Paul Edwards
2009-11-09 15:57 ` Ian Lance Taylor
2009-11-09 23:10 ` Paul Edwards
2009-11-10 14:58 ` Paul Edwards
2009-11-10 15:36 ` Ian Lance Taylor
2009-11-10 15:51 ` Paul Edwards
2009-11-10 15:56 ` Ian Lance Taylor
2009-12-02 22:03 ` Paul Edwards
2011-08-13 8:34 ` Paul Edwards
2011-08-15 14:32 ` Ulrich Weigand
2011-08-15 15:26 ` Paul Edwards
2011-08-15 17:23 ` Ulrich Weigand
2011-08-16 11:20 ` Paul Edwards
2011-08-16 13:26 ` Ulrich Weigand
2011-08-18 12:15 ` Paul Edwards
2011-08-18 13:14 ` Ulrich Weigand
2011-08-18 14:18 ` Paul Edwards
2009-09-22 12:31 Paul Edwards
2011-08-20 7:44 Paul Edwards
2011-08-20 10:09 Paul Edwards
2011-08-20 12:15 Paul Edwards
2011-08-22 12:23 ` Ulrich Weigand
2012-04-05 13:32 ` Paul Edwards
2012-04-06 18:13 ` Ulrich Weigand
2012-04-06 5:51 Paul Edwards
2012-04-06 12:49 Paul Edwards
2012-04-06 18:16 ` Ulrich Weigand
2012-04-07 4:12 ` Paul Edwards
2012-04-07 5:45 Paul Edwards
2012-04-08 17:43 ` Ulrich Weigand
2014-02-11 17:01 ` Paul Edwards
2014-02-13 4:23 Paul Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174030E531584E68BF5743D433A6E16E@Paullaptop \
--to=mutazilah@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).