public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cel at us dot ibm.com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/29247] [gdb, tdep] ../../gdb/ppc-sysv-tdep.c:1945: internal-error: ppc64_sysv_abi_return_value: Assertion `ok' failed
Date: Wed, 13 Jul 2022 17:46:31 +0000	[thread overview]
Message-ID: <bug-29247-4717-AIunb2sEn4@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29247-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29247

--- Comment #20 from Carl E Love <cel at us dot ibm.com> ---
Created attachment 14207
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14207&action=edit
Patch to fix the final error

Yes,the control flow is executing the ABI (version 1.9) code as noted by Ulrich
for ELFv1 when the system is actually using ELFv2,

First, added support for IEEE 128-bit float to the code pointed out in comment
19.  This fixes the final error even though we are actually not supposed to be
executing this code for ELFv2.  

Second, added a check for ELFv1 so the code is only executed with ELFv1.  The
test still passes given the previous fixes to the homogeneous aggregate rule.

The attachment shows the new code to fix the final bug.  Posting it separately
to make it easy to review.

I will merge the two patches and post the patch on the mailing list for review
and approval.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-07-13 17:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  8:58 [Bug tdep/29247] New: " vries at gcc dot gnu.org
2022-06-14 14:51 ` [Bug tdep/29247] " vries at gcc dot gnu.org
2022-06-15 11:59 ` vries at gcc dot gnu.org
2022-06-15 13:27 ` vries at gcc dot gnu.org
2022-06-15 14:47 ` vries at gcc dot gnu.org
2022-06-15 14:51 ` vries at gcc dot gnu.org
2022-06-15 15:49 ` vries at gcc dot gnu.org
2022-06-15 15:59 ` vries at gcc dot gnu.org
2022-06-15 22:47 ` vries at gcc dot gnu.org
2022-06-16 13:53 ` jamborm at gcc dot gnu.org
2022-06-20 12:25 ` ulrich.weigand at de dot ibm.com
2022-06-21 16:32 ` cel at us dot ibm.com
2022-06-23 15:19 ` cel at us dot ibm.com
2022-06-23 15:22 ` cel at us dot ibm.com
2022-06-23 15:30 ` ulrich.weigand at de dot ibm.com
2022-06-23 19:56 ` cel at us dot ibm.com
2022-06-24  0:53 ` cel at us dot ibm.com
2022-06-24 11:53 ` ulrich.weigand at de dot ibm.com
2022-06-25  0:42 ` cel at us dot ibm.com
2022-06-25  2:51 ` ulrich.weigand at de dot ibm.com
2022-06-30 22:47 ` cel at us dot ibm.com
2022-07-12  9:15 ` ulrich.weigand at de dot ibm.com
2022-07-13 17:46 ` cel at us dot ibm.com [this message]
2022-07-15 15:32 ` cel at us dot ibm.com
2022-07-15 16:09 ` cel at us dot ibm.com
2022-07-27  8:45 ` vries at gcc dot gnu.org
2022-07-27 15:38 ` cel at us dot ibm.com
2022-07-27 15:42 ` vries at gcc dot gnu.org
2022-07-27 16:54 ` cel at us dot ibm.com
2022-09-02 12:55 ` vries at gcc dot gnu.org
2022-09-02 13:09 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29247-4717-AIunb2sEn4@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).