[Bug tdep/29247] [gdb, tdep] ../../gdb/ppc-sysv-tdep.c:1945: internal-error: ppc64_sysv_abi_return_value: Assertion `ok' failed

["ulrich.weigand at de dot ibm.com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29247

ulrich.weigand at de dot ibm.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ulrich.weigand at de dot ibm.com

--- Comment #8 from ulrich.weigand at de dot ibm.com ---
(In reply to Tom de Vries from comment #7)
> I finally remembered that I can use osc to build the gdb package for the
> tumbleweed distro, even if the powerpc machine isn't running tumbleweed.

Thanks for looking into this!  It seems we indeed forgot to add support for
IEEE long double to ppc-sysv-tdep.c ...

> As a first try, I added this code:
> ...
>   if (tdep->elf_abi == POWERPC_ELF_V2
>       && TYPE_LENGTH (valtype) == 16
>       && valtype->code () == TYPE_CODE_FLT
>       && (gdbarch_long_double_format (gdbarch)
>           == floatformats_ia64_quad))
>     {
>       int regnum = tdep->ppc_vsr0_regnum + 32 + 2 + index;
> 
>       if (writebuf != NULL)
>         {
>           regcache->cooked_write (regnum, writebuf);
>         }
>       if (readbuf != NULL)
>         {
>           regcache->cooked_read (regnum, readbuf);
>         }
>       return 1;
>     }

This looks good to me, except for:

> I'm not sure if the tdep->elf_abi == POWERPC_ELF_V2 and
> gdbarch_long_double_format (gdbarch) == floatformats_ia64_quad are both
> necessary.

I don't think the elf_abi check is needed, the floatformat check should be
enough.

> Still, four fails lefts:
> ...
> FAIL: gdb.base/callfuncs.exp: p t_long_double_complex_values(ldc1, ldc2)
> FAIL: gdb.base/callfuncs.exp: p t_long_double_complex_many_args(ldc1, ldc2,
> ldc3, ldc4, ldc1, ldc2, ldc3, ldc4, ldc1, ldc2, ldc3, ldc4, ldc1, ldc2,
> ldc3, ldc4)
> FAIL: gdb.base/callfuncs.exp: noproto: p t_long_double_complex_values(ldc1,
> ldc2)
> FAIL: gdb.base/callfuncs.exp: noproto: p
> t_long_double_complex_many_args(ldc1, ldc2, ldc3, ldc4, ldc1, ldc2, ldc3,
> ldc4, ldc1, ldc2, ldc3, ldc4, ldc1, ldc2, ldc3, ldc4)
> ...


There are more places in ppc-sysv-tdep.c that need to handle IEEE long double,
in particular ppc64_sysv_abi_push_freg and ppc64_sysv_abi_return_value_base. 
Those should hopefully fix the above inferior call tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.