[Bug tdep/29247] [gdb, tdep] ../../gdb/ppc-sysv-tdep.c:1945: internal-error: ppc64_sysv_abi_return_value: Assertion `ok' failed

["cel at us dot ibm.com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29247

Carl E Love <cel at us dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14164|0                           |1
        is obsolete|                            |

--- Comment #16 from Carl E Love <cel at us dot ibm.com> ---
Created attachment 14167
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14167&action=edit
Add IEEE support for float 128bit, version 2



> The only thing that looks wrong to me is the condition in (new) line 1440.  It
> seems that this erroneously no longer handles any float/double values at all
> anymore.

I think you are referring to this section of code?


-  if (type->code () == TYPE_CODE_FLT
+  /* IBM long double uses floating point registers for the 128-bit value.  */
+  if ((type->code () == TYPE_CODE_FLT
+       && !(gdbarch_long_double_format (gdbarch)
+           == floatformats_ieee_quad) && TYPE_LENGTH (type) == 16)
       || type->code () == TYPE_CODE_DECFLOAT)
     {

I was trying to make sure that the IEEE 128-bit case would be excluded.  I
think it was only taking that one case out.  But, it is hard to read.  I
rewrote it to make it easier to read.  By checking for the IEEE FLOAT 128-bit
case first, then TYPE_CODE_FLT you don't need to modify the existing "if
(type->code () == TYPE_CODE_FLT" statement.

I also found I had missed handling a float case.  I fixed that it reduced the
number of errors from 72 to 12.  I am not sure about the check for aggregate
candidate and homogeneous aggregate.  Not sure yet what a homogeneous
float/vector is and if I need to do something special to check for them in the
case of the IEEE FLOAT 128-bit case?

Attached latest patch.  It has a comments indicating the new code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.