public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cel at us dot ibm.com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/29247] [gdb, tdep] ../../gdb/ppc-sysv-tdep.c:1945: internal-error: ppc64_sysv_abi_return_value: Assertion `ok' failed
Date: Fri, 15 Jul 2022 15:32:43 +0000	[thread overview]
Message-ID: <bug-29247-4717-eOXBwro1yD@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29247-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29247

--- Comment #21 from Carl E Love <cel at us dot ibm.com> ---
Patch approved, committed.

commit ebbac1687d0075c8666b25438fc4f35d3dd1daaa (HEAD -> master, origin/master,
origin/HEAD)
Author: Carl Love <cel@us.ibm.com>
Date:   Fri Jul 15 15:30:43 2022 +0000

    PowerPC: Add support for IEEE 128-bit format.

    The test gdb.base/infcall-nested-structs-c.exp fails on a gdb assert
    in function ppc64_sysv_abi_return_value in file gdb/ppc-sysv-tdep.c.  The
    assert is due to the missing IEEE 128-bit support in file
    gdb/ppc-sysv-tdep.c.

    The IBM long double was the initial float 128-bit support added by IBM
    The IEEE 128-bit support, which is similar IBM long double support, was
    made the default starting with GCC 12.  The floating point format
    differences include the number of bits used to encode the exponent
    and significand.  Also, IBM long double values are passed in a pair of
    floating point registers.  The  IEEE 128-bit value is passed in a single
    vector register.

    This patch fixes the gdb_assert (ok); in function
    ppc64_sysv_abi_return_value in gdb/ppc-sysv-tdep.c by adding IEEE FLOAT
    128-bit type support for PowerPC.

    The patch has been tested on Power 10, ELFv2.  It fixes the following list
    of regression failures on Power 10:

    gdb.base/infcall-nested-structs-c.exp      192
    gdb.base/infcall-nested-structs-c++.exp     76
    gdb.base/structs.exp                         9

    The patch has been tested on Power 8 BE which is ELFv1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-07-15 15:32 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  8:58 [Bug tdep/29247] New: " vries at gcc dot gnu.org
2022-06-14 14:51 ` [Bug tdep/29247] " vries at gcc dot gnu.org
2022-06-15 11:59 ` vries at gcc dot gnu.org
2022-06-15 13:27 ` vries at gcc dot gnu.org
2022-06-15 14:47 ` vries at gcc dot gnu.org
2022-06-15 14:51 ` vries at gcc dot gnu.org
2022-06-15 15:49 ` vries at gcc dot gnu.org
2022-06-15 15:59 ` vries at gcc dot gnu.org
2022-06-15 22:47 ` vries at gcc dot gnu.org
2022-06-16 13:53 ` jamborm at gcc dot gnu.org
2022-06-20 12:25 ` ulrich.weigand at de dot ibm.com
2022-06-21 16:32 ` cel at us dot ibm.com
2022-06-23 15:19 ` cel at us dot ibm.com
2022-06-23 15:22 ` cel at us dot ibm.com
2022-06-23 15:30 ` ulrich.weigand at de dot ibm.com
2022-06-23 19:56 ` cel at us dot ibm.com
2022-06-24  0:53 ` cel at us dot ibm.com
2022-06-24 11:53 ` ulrich.weigand at de dot ibm.com
2022-06-25  0:42 ` cel at us dot ibm.com
2022-06-25  2:51 ` ulrich.weigand at de dot ibm.com
2022-06-30 22:47 ` cel at us dot ibm.com
2022-07-12  9:15 ` ulrich.weigand at de dot ibm.com
2022-07-13 17:46 ` cel at us dot ibm.com
2022-07-15 15:32 ` cel at us dot ibm.com [this message]
2022-07-15 16:09 ` cel at us dot ibm.com
2022-07-27  8:45 ` vries at gcc dot gnu.org
2022-07-27 15:38 ` cel at us dot ibm.com
2022-07-27 15:42 ` vries at gcc dot gnu.org
2022-07-27 16:54 ` cel at us dot ibm.com
2022-09-02 12:55 ` vries at gcc dot gnu.org
2022-09-02 13:09 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29247-4717-eOXBwro1yD@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).